All of lore.kernel.org
 help / color / mirror / Atom feed
* [f2fs-dev] [RFC PATCH] f2fs: do not use CURSEG_ALL_DATA_ATGC in foreground or urgent GC
@ 2021-03-16 13:15 Weichao Guo via Linux-f2fs-devel
  2021-03-17  2:40 ` Chao Yu
  0 siblings, 1 reply; 6+ messages in thread
From: Weichao Guo via Linux-f2fs-devel @ 2021-03-16 13:15 UTC (permalink / raw)
  To: jaegeuk, chao; +Cc: fh, linux-f2fs-devel

CURSEG_ALL_DATA_ATGC is introduced by age threshold based GC for better
hot/cold data seperation and avoiding free segment cost. However, LFS
write mode is preferred in the scenario of foreground or urgent GC, which
should be finished ASAP. So, let's only use CURSEG_ALL_DATA_ATGC when not
urgent in background GC.

Signed-off-by: Weichao Guo <guoweichao@oppo.com>
Signed-off-by: Huang Jianan <huangjianan@oppo.com>
---
 fs/f2fs/gc.c      | 3 ++-
 fs/f2fs/segment.c | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 86ba8ed..ee42f6e 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1120,7 +1120,8 @@ static int move_data_block(struct inode *inode, block_t bidx,
 	block_t newaddr;
 	int err = 0;
 	bool lfs_mode = f2fs_lfs_mode(fio.sbi);
-	int type = fio.sbi->am.atgc_enabled ?
+	int type = fio.sbi->am.atgc_enabled && gc_type == BG_GC &&
+				fio.sbi->gc_mode < GC_URGENT_HIGH ?
 				CURSEG_ALL_DATA_ATGC : CURSEG_COLD_DATA;
 
 	/* do not read out */
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 32b915e..cbfb0d1 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -3264,7 +3264,9 @@ static int __get_segment_type_6(struct f2fs_io_info *fio)
 		struct inode *inode = fio->page->mapping->host;
 
 		if (is_cold_data(fio->page)) {
-			if (fio->sbi->am.atgc_enabled)
+			if (fio->sbi->am.atgc_enabled &&
+				fio->io_type == FS_DATA_IO &&
+				fio->sbi->gc_mode < GC_URGENT_HIGH)
 				return CURSEG_ALL_DATA_ATGC;
 			else
 				return CURSEG_COLD_DATA;
-- 
2.7.4



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-17  7:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 13:15 [f2fs-dev] [RFC PATCH] f2fs: do not use CURSEG_ALL_DATA_ATGC in foreground or urgent GC Weichao Guo via Linux-f2fs-devel
2021-03-17  2:40 ` Chao Yu
2021-03-17  3:44   ` Weichao Guo via Linux-f2fs-devel
2021-03-17  6:41     ` Chao Yu
2021-03-17  7:01       ` Weichao Guo via Linux-f2fs-devel
2021-03-17  7:24         ` Chao Yu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.