* [PATCH RESEND ethtool-next] netlink: settings: add netlink support for coalesce cqe mode parameter
@ 2021-08-27 6:06 Yufeng Mo
2021-08-29 16:57 ` Michal Kubecek
0 siblings, 1 reply; 3+ messages in thread
From: Yufeng Mo @ 2021-08-27 6:06 UTC (permalink / raw)
To: davem, kuba, mkubecek, amitc, idosch, andrew, o.rempel,
f.fainelli, jacob.e.keller, mlxsw
Cc: netdev, lipeng321, moyufeng, linuxarm, linuxarm
Add support for "ethtool -c <dev> cqe-mode-rx/cqe-mode-tx on/off"
for setting coalesce cqe mode.
Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
---
ethtool.c | 2 ++
netlink/coalesce.c | 15 +++++++++++++++
2 files changed, 17 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 2486caa..a6826e9 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -5703,6 +5703,8 @@ static const struct option args[] = {
" [tx-usecs-high N]\n"
" [tx-frames-high N]\n"
" [sample-interval N]\n"
+ " [cqe-mode-rx on|off]\n"
+ " [cqe-mode-tx on|off]\n"
},
{
.opts = "-g|--show-ring",
diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index 75922a9..762d0e3 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -66,6 +66,9 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
show_u32(tb[ETHTOOL_A_COALESCE_TX_USECS_HIGH], "tx-usecs-high: ");
show_u32(tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_HIGH], "tx-frame-high: ");
putchar('\n');
+ show_bool("rx", "CQE mode RX: %s ",
+ tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_RX]);
+ show_bool("tx", "TX: %s\n", tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_TX]);
return MNL_CB_OK;
}
@@ -226,6 +229,18 @@ static const struct param_parser scoalesce_params[] = {
.handler = nl_parse_direct_u32,
.min_argc = 1,
},
+ {
+ .arg = "cqe-mode-rx",
+ .type = ETHTOOL_A_COALESCE_USE_CQE_MODE_RX,
+ .handler = nl_parse_u8bool,
+ .min_argc = 1,
+ },
+ {
+ .arg = "cqe-mode-tx",
+ .type = ETHTOOL_A_COALESCE_USE_CQE_MODE_TX,
+ .handler = nl_parse_u8bool,
+ .min_argc = 1,
+ },
{}
};
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND ethtool-next] netlink: settings: add netlink support for coalesce cqe mode parameter
2021-08-27 6:06 [PATCH RESEND ethtool-next] netlink: settings: add netlink support for coalesce cqe mode parameter Yufeng Mo
@ 2021-08-29 16:57 ` Michal Kubecek
2021-08-30 1:46 ` moyufeng
0 siblings, 1 reply; 3+ messages in thread
From: Michal Kubecek @ 2021-08-29 16:57 UTC (permalink / raw)
To: Yufeng Mo
Cc: davem, kuba, amitc, idosch, andrew, o.rempel, f.fainelli,
jacob.e.keller, mlxsw, netdev, lipeng321, linuxarm, linuxarm
[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]
On Fri, Aug 27, 2021 at 02:06:48PM +0800, Yufeng Mo wrote:
> Add support for "ethtool -c <dev> cqe-mode-rx/cqe-mode-tx on/off"
> for setting coalesce cqe mode.
>
> Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
> ---
> ethtool.c | 2 ++
> netlink/coalesce.c | 15 +++++++++++++++
> 2 files changed, 17 insertions(+)
Please update also the man page (file ethtool.8.in) to show the new
parameters.
Michal
> diff --git a/ethtool.c b/ethtool.c
> index 2486caa..a6826e9 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -5703,6 +5703,8 @@ static const struct option args[] = {
> " [tx-usecs-high N]\n"
> " [tx-frames-high N]\n"
> " [sample-interval N]\n"
> + " [cqe-mode-rx on|off]\n"
> + " [cqe-mode-tx on|off]\n"
> },
> {
> .opts = "-g|--show-ring",
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index 75922a9..762d0e3 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -66,6 +66,9 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> show_u32(tb[ETHTOOL_A_COALESCE_TX_USECS_HIGH], "tx-usecs-high: ");
> show_u32(tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_HIGH], "tx-frame-high: ");
> putchar('\n');
> + show_bool("rx", "CQE mode RX: %s ",
> + tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_RX]);
> + show_bool("tx", "TX: %s\n", tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_TX]);
>
> return MNL_CB_OK;
> }
> @@ -226,6 +229,18 @@ static const struct param_parser scoalesce_params[] = {
> .handler = nl_parse_direct_u32,
> .min_argc = 1,
> },
> + {
> + .arg = "cqe-mode-rx",
> + .type = ETHTOOL_A_COALESCE_USE_CQE_MODE_RX,
> + .handler = nl_parse_u8bool,
> + .min_argc = 1,
> + },
> + {
> + .arg = "cqe-mode-tx",
> + .type = ETHTOOL_A_COALESCE_USE_CQE_MODE_TX,
> + .handler = nl_parse_u8bool,
> + .min_argc = 1,
> + },
> {}
> };
>
> --
> 2.8.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND ethtool-next] netlink: settings: add netlink support for coalesce cqe mode parameter
2021-08-29 16:57 ` Michal Kubecek
@ 2021-08-30 1:46 ` moyufeng
0 siblings, 0 replies; 3+ messages in thread
From: moyufeng @ 2021-08-30 1:46 UTC (permalink / raw)
To: Michal Kubecek
Cc: davem, kuba, amitc, idosch, andrew, o.rempel, f.fainelli,
jacob.e.keller, mlxsw, netdev, lipeng321, linuxarm, linuxarm,
moyufeng
On 2021/8/30 0:57, Michal Kubecek wrote:
> On Fri, Aug 27, 2021 at 02:06:48PM +0800, Yufeng Mo wrote:
>> Add support for "ethtool -c <dev> cqe-mode-rx/cqe-mode-tx on/off"
>> for setting coalesce cqe mode.
>>
>> Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
>> ---
>> ethtool.c | 2 ++
>> netlink/coalesce.c | 15 +++++++++++++++
>> 2 files changed, 17 insertions(+)
>
> Please update also the man page (file ethtool.8.in) to show the new
> parameters.
>
> Michal
>
ok, thanks
>> diff --git a/ethtool.c b/ethtool.c
>> index 2486caa..a6826e9 100644
>> --- a/ethtool.c
>> +++ b/ethtool.c
>> @@ -5703,6 +5703,8 @@ static const struct option args[] = {
>> " [tx-usecs-high N]\n"
>> " [tx-frames-high N]\n"
>> " [sample-interval N]\n"
>> + " [cqe-mode-rx on|off]\n"
>> + " [cqe-mode-tx on|off]\n"
>> },
>> {
>> .opts = "-g|--show-ring",
>> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>> index 75922a9..762d0e3 100644
>> --- a/netlink/coalesce.c
>> +++ b/netlink/coalesce.c
>> @@ -66,6 +66,9 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>> show_u32(tb[ETHTOOL_A_COALESCE_TX_USECS_HIGH], "tx-usecs-high: ");
>> show_u32(tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_HIGH], "tx-frame-high: ");
>> putchar('\n');
>> + show_bool("rx", "CQE mode RX: %s ",
>> + tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_RX]);
>> + show_bool("tx", "TX: %s\n", tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_TX]);
>>
>> return MNL_CB_OK;
>> }
>> @@ -226,6 +229,18 @@ static const struct param_parser scoalesce_params[] = {
>> .handler = nl_parse_direct_u32,
>> .min_argc = 1,
>> },
>> + {
>> + .arg = "cqe-mode-rx",
>> + .type = ETHTOOL_A_COALESCE_USE_CQE_MODE_RX,
>> + .handler = nl_parse_u8bool,
>> + .min_argc = 1,
>> + },
>> + {
>> + .arg = "cqe-mode-tx",
>> + .type = ETHTOOL_A_COALESCE_USE_CQE_MODE_TX,
>> + .handler = nl_parse_u8bool,
>> + .min_argc = 1,
>> + },
>> {}
>> };
>>
>> --
>> 2.8.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-30 1:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 6:06 [PATCH RESEND ethtool-next] netlink: settings: add netlink support for coalesce cqe mode parameter Yufeng Mo
2021-08-29 16:57 ` Michal Kubecek
2021-08-30 1:46 ` moyufeng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.