* RE: [PATCH] megaraid: Use the proper type to hold the irq number.
@ 2006-08-07 21:19 ` Ju, Seokmann
0 siblings, 0 replies; 4+ messages in thread
From: Ju, Seokmann @ 2006-08-07 21:19 UTC (permalink / raw)
To: Eric W. Biederman, Andrew Morton
Cc: Kolli, Neela, linux-scsi, Protasevich, Natalie, linux-kernel
Hi
> This patches fixes that problem and the driver now appears
> to work.
>
> The ioctl interface appears fundamentally broken as it exports
> the irq number to user space in an unsigned char.
Thank you for your findings.
As you mentioned above, driver needs more changes besides your patch.
I will submit a patch covers all required changes, soon.
Thank you again,
Seokmann
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org
> [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Eric
> W. Biederman
> Sent: Monday, August 07, 2006 11:29 AM
> To: Andrew Morton
> Cc: Kolli, Neela; linux-scsi@vger.kernel.org; Protasevich,
> Natalie; linux-kernel@vger.kernel.org
> Subject: [PATCH] megaraid: Use the proper type to hold the irq number.
>
>
> When testing on a Unisys machine it was discovered that
> the megaraid driver would not initialize as it was
> requesting irq 162 instead of irq 1442 it was assigned.
> The problem was the irq number had been truncated by being
> stored in an unsigned char.
>
> This patches fixes that problem and the driver now appears
> to work.
>
> The ioctl interface appears fundamentally broken as it exports
> the irq number to user space in an unsigned char.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> ---
> drivers/scsi/megaraid/mega_common.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/mega_common.h
> b/drivers/scsi/megaraid/mega_common.h
> index 8cd0bd1..b50e27e 100644
> --- a/drivers/scsi/megaraid/mega_common.h
> +++ b/drivers/scsi/megaraid/mega_common.h
> @@ -175,7 +175,7 @@ typedef struct {
> uint8_t max_lun;
>
> uint32_t unique_id;
> - uint8_t irq;
> + int irq;
> uint8_t ito;
> caddr_t ibuf;
> dma_addr_t ibuf_dma_h;
> --
> 1.4.2.rc3.g7e18e
>
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] megaraid: Use the proper type to hold the irq number.
@ 2006-08-07 21:19 ` Ju, Seokmann
0 siblings, 0 replies; 4+ messages in thread
From: Ju, Seokmann @ 2006-08-07 21:19 UTC (permalink / raw)
To: Eric W. Biederman, Andrew Morton
Cc: Kolli, Neela, linux-scsi, Protasevich, Natalie, linux-kernel
Hi
> This patches fixes that problem and the driver now appears
> to work.
>
> The ioctl interface appears fundamentally broken as it exports
> the irq number to user space in an unsigned char.
Thank you for your findings.
As you mentioned above, driver needs more changes besides your patch.
I will submit a patch covers all required changes, soon.
Thank you again,
Seokmann
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org
> [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Eric
> W. Biederman
> Sent: Monday, August 07, 2006 11:29 AM
> To: Andrew Morton
> Cc: Kolli, Neela; linux-scsi@vger.kernel.org; Protasevich,
> Natalie; linux-kernel@vger.kernel.org
> Subject: [PATCH] megaraid: Use the proper type to hold the irq number.
>
>
> When testing on a Unisys machine it was discovered that
> the megaraid driver would not initialize as it was
> requesting irq 162 instead of irq 1442 it was assigned.
> The problem was the irq number had been truncated by being
> stored in an unsigned char.
>
> This patches fixes that problem and the driver now appears
> to work.
>
> The ioctl interface appears fundamentally broken as it exports
> the irq number to user space in an unsigned char.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> ---
> drivers/scsi/megaraid/mega_common.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/mega_common.h
> b/drivers/scsi/megaraid/mega_common.h
> index 8cd0bd1..b50e27e 100644
> --- a/drivers/scsi/megaraid/mega_common.h
> +++ b/drivers/scsi/megaraid/mega_common.h
> @@ -175,7 +175,7 @@ typedef struct {
> uint8_t max_lun;
>
> uint32_t unique_id;
> - uint8_t irq;
> + int irq;
> uint8_t ito;
> caddr_t ibuf;
> dma_addr_t ibuf_dma_h;
> --
> 1.4.2.rc3.g7e18e
>
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] megaraid: Use the proper type to hold the irq number.
@ 2006-08-07 15:28 ` Eric W. Biederman
0 siblings, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2006-08-07 15:28 UTC (permalink / raw)
To: Andrew Morton
Cc: Neela Syam Kolli, linux-scsi, Protasevich, Natalie, linux-kernel
When testing on a Unisys machine it was discovered that
the megaraid driver would not initialize as it was
requesting irq 162 instead of irq 1442 it was assigned.
The problem was the irq number had been truncated by being
stored in an unsigned char.
This patches fixes that problem and the driver now appears
to work.
The ioctl interface appears fundamentally broken as it exports
the irq number to user space in an unsigned char.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
drivers/scsi/megaraid/mega_common.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/mega_common.h b/drivers/scsi/megaraid/mega_common.h
index 8cd0bd1..b50e27e 100644
--- a/drivers/scsi/megaraid/mega_common.h
+++ b/drivers/scsi/megaraid/mega_common.h
@@ -175,7 +175,7 @@ typedef struct {
uint8_t max_lun;
uint32_t unique_id;
- uint8_t irq;
+ int irq;
uint8_t ito;
caddr_t ibuf;
dma_addr_t ibuf_dma_h;
--
1.4.2.rc3.g7e18e
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] megaraid: Use the proper type to hold the irq number.
@ 2006-08-07 15:28 ` Eric W. Biederman
0 siblings, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2006-08-07 15:28 UTC (permalink / raw)
To: Andrew Morton
Cc: Neela Syam Kolli, linux-scsi, Protasevich, Natalie, linux-kernel
When testing on a Unisys machine it was discovered that
the megaraid driver would not initialize as it was
requesting irq 162 instead of irq 1442 it was assigned.
The problem was the irq number had been truncated by being
stored in an unsigned char.
This patches fixes that problem and the driver now appears
to work.
The ioctl interface appears fundamentally broken as it exports
the irq number to user space in an unsigned char.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
drivers/scsi/megaraid/mega_common.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/mega_common.h b/drivers/scsi/megaraid/mega_common.h
index 8cd0bd1..b50e27e 100644
--- a/drivers/scsi/megaraid/mega_common.h
+++ b/drivers/scsi/megaraid/mega_common.h
@@ -175,7 +175,7 @@ typedef struct {
uint8_t max_lun;
uint32_t unique_id;
- uint8_t irq;
+ int irq;
uint8_t ito;
caddr_t ibuf;
dma_addr_t ibuf_dma_h;
--
1.4.2.rc3.g7e18e
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-07 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-07 21:19 [PATCH] megaraid: Use the proper type to hold the irq number Ju, Seokmann
2006-08-07 21:19 ` Ju, Seokmann
-- strict thread matches above, loose matches on Subject: below --
2006-08-07 15:28 Eric W. Biederman
2006-08-07 15:28 ` Eric W. Biederman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.