All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at system_reset
Date: Tue, 2 Aug 2016 13:00:35 -0400 (EDT)	[thread overview]
Message-ID: <891632335.13100661.1470157235734.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <e36b9d2f-847b-0774-8154-d50109ae3b59@redhat.com>


> I'd prefer if Paolo's remark (about blk_drain()'s ability to produce
> more failed requests, stashed in s->rq) were captured in either the
> commit message, or in a code comment. Something like:
> 
>   /* We drop queued requests after blk_drain() because blk_drain()
>    * itself can produce them. */

It's also (perhaps especially) because blk_drain() can consume them.  Fam's
patch to do blk_drain() first would cause a double-free.

Paolo

> What do you think? It's your call. I certainly lacked that bit of
> information.
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks!
> Laszlo
> 

  reply	other threads:[~2016-08-02 17:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 13:00 [Qemu-devel] [PATCH v2 0/2] Two virtio-blk fixes Fam Zheng
2016-08-02 13:00 ` [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at system_reset Fam Zheng
2016-08-02 13:31   ` Laszlo Ersek
2016-08-02 17:00     ` Paolo Bonzini [this message]
2016-08-03  0:52       ` Fam Zheng
2016-08-04 12:42         ` Paolo Bonzini
2016-08-02 13:00 ` [Qemu-devel] [PATCH v2 2/2] virtio-blk: Remove stale comment about draining Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=891632335.13100661.1470157235734.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.