[PATCH v2] nvme-fabrics: request transport module

[PATCH v2] nvme-fabrics: request transport module

[Sagi Grimberg]

Help userspace to not make sure transport module is
loaded.

Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
Changes from v1:
- got rid of redundant module name resolution code and ignore request_module
  retcode

 drivers/nvme/host/fabrics.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 6d68738f01ea..ef38552911d4 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -945,6 +945,9 @@ nvmf_create_ctrl(struct device *dev, const char *buf, size_t count)
 	if (ret)
 		goto out_free_opts;
 
+
+	request_module("nvme-%s", opts->transport);
+
 	/*
 	 * Check the generic options first as we need a valid transport for
 	 * the lookup below.  Then clear the generic flags so that transport
-- 
2.7.4

[PATCH v2] nvme-fabrics: request transport module

[Damien Le Moal]

Sagi,

On 9/24/17 15:15, Sagi Grimberg wrote:
> Help userspace to not make sure transport module is
> loaded.
> 
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>

Shouldn't this read "Help userspace to make sure transport module is
loaded." ?
Extra "not"...

-- 
Damien Le Moal
Western Digital Research

[PATCH v2] nvme-fabrics: request transport module

[Christoph Hellwig]

On Sun, Sep 24, 2017@04:33:14PM +0200, Damien Le Moal wrote:
> > Help userspace to not make sure transport module is
> > loaded.
> > 
> > Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> 
> Shouldn't this read "Help userspace to make sure transport module is
> loaded." ?
> Extra "not"...

It should.  Be except for that typo the patch looks good to me:

Reviewed-by: Christoph Hellwig <hch at lst.de>

[PATCH v2] nvme-fabrics: request transport module

[Johannes Thumshirn]

Looks good (with the typo fix),
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH v2] nvme-fabrics: request transport module

[Christoph Hellwig]

Applied to nvme-4.15.