* [PATCH] nvme_fc: fix missing put reference on controller create failure
@ 2017-06-05 22:03 James Smart
2017-06-06 7:37 ` Sagi Grimberg
0 siblings, 1 reply; 2+ messages in thread
From: James Smart @ 2017-06-05 22:03 UTC (permalink / raw)
The failure case, of a create controller request, called
nvme_uninit_ctrl() but didn't do a put to allow the nvme
controller to be deleted.
Signed-off-by: James Smart <james.smart at broadcom.com>
---
drivers/nvme/host/fc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 4d1e7e1103f9..cd5e1df4399b 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -3216,6 +3216,7 @@ nvme_fc_init_ctrl(struct device *dev, struct nvmf_ctrl_options *opts,
ctrl->ctrl.opts = NULL;
/* initiate nvme ctrl ref counting teardown */
nvme_uninit_ctrl(&ctrl->ctrl);
+ nvme_put_ctrl(&ctrl->ctrl);
/* as we're past the point where we transition to the ref
* counting teardown path, if we return a bad pointer here,
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme_fc: fix missing put reference on controller create failure
2017-06-05 22:03 [PATCH] nvme_fc: fix missing put reference on controller create failure James Smart
@ 2017-06-06 7:37 ` Sagi Grimberg
0 siblings, 0 replies; 2+ messages in thread
From: Sagi Grimberg @ 2017-06-06 7:37 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-06 7:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-05 22:03 [PATCH] nvme_fc: fix missing put reference on controller create failure James Smart
2017-06-06 7:37 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.