All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Martyn Welch <martyn.welch@collabora.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board
Date: Tue, 19 Jul 2022 12:18:45 +0200	[thread overview]
Message-ID: <895e7df5-65e5-7b26-81d6-864e68957ab6@linaro.org> (raw)
In-Reply-To: <YtaEUvP4jpO5Dggg@gaggiata.pivistrello.it>

On 19/07/2022 12:15, Francesco Dolcini wrote:
> Hello Krzysztof,
> 
> On Tue, Jul 19, 2022 at 12:01:34PM +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> +	tca6424: gpio@22 {
>>> +		compatible = "ti,tca6424";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&pinctrl_tca6424>;
>>> +		reg = <0x22>;
>>
>> compatible, then reg, then all other properties. This applies everywhere.
> 
> Is this documented somewhere? It would be easier to enable new people to
> contribute, if it was.

Unfortunately it's not documented. It's a common practice - most
popular, but of course you will find other examples. There is reasoning
behind - compatible is the most important property. Reg is useful to
have at the top as it must match unit address.

> Anyway, I would add to this list status as last, when present, 

Yes, this as well in some trees is recommended/enforced although not
documented.

> and I do
> try to order alphabetically all the other properties.
Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Martyn Welch <martyn.welch@collabora.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board
Date: Tue, 19 Jul 2022 12:18:45 +0200	[thread overview]
Message-ID: <895e7df5-65e5-7b26-81d6-864e68957ab6@linaro.org> (raw)
In-Reply-To: <YtaEUvP4jpO5Dggg@gaggiata.pivistrello.it>

On 19/07/2022 12:15, Francesco Dolcini wrote:
> Hello Krzysztof,
> 
> On Tue, Jul 19, 2022 at 12:01:34PM +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> +	tca6424: gpio@22 {
>>> +		compatible = "ti,tca6424";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&pinctrl_tca6424>;
>>> +		reg = <0x22>;
>>
>> compatible, then reg, then all other properties. This applies everywhere.
> 
> Is this documented somewhere? It would be easier to enable new people to
> contribute, if it was.

Unfortunately it's not documented. It's a common practice - most
popular, but of course you will find other examples. There is reasoning
behind - compatible is the most important property. Reg is useful to
have at the top as it must match unit address.

> Anyway, I would add to this list status as last, when present, 

Yes, this as well in some trees is recommended/enforced although not
documented.

> and I do
> try to order alphabetically all the other properties.
Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-19 10:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 15:23 [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board Martyn Welch
2022-07-18 15:23 ` Martyn Welch
2022-07-19 10:01 ` Krzysztof Kozlowski
2022-07-19 10:01   ` Krzysztof Kozlowski
2022-07-19 10:15   ` Francesco Dolcini
2022-07-19 10:15     ` Francesco Dolcini
2022-07-19 10:18     ` Krzysztof Kozlowski [this message]
2022-07-19 10:18       ` Krzysztof Kozlowski
2022-07-19 16:37   ` Martyn Welch
2022-07-19 16:37     ` Martyn Welch
2022-07-19 18:18     ` Krzysztof Kozlowski
2022-07-19 18:18       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895e7df5-65e5-7b26-81d6-864e68957ab6@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco@dolcini.it \
    --cc=kernel@collabora.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martyn.welch@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.