All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Li Zhengyu <lizhengyu3@huawei.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: linux-next: Tree for May 31 (riscv: arch/riscv/kernel/elf_kexec.c)
Date: Tue, 31 May 2022 12:52:28 -0700	[thread overview]
Message-ID: <8971599c-fc8f-d69c-46b0-07f4c42fb195@infradead.org> (raw)
In-Reply-To: <20220531145458.39c00988@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 3310 bytes --]


838b3e28488f7: RISC-V: Load purgatory in kexec_file


On 5/30/22 21:54, Stephen Rothwell wrote:
> Hi all,
> 
> Note: please do not add any v5.20 material to your linux-next included
> branches until after v5.19-rc1 has been related.
> 
> Changes since 20220527:
> 

When CONFIG_MODULES is not set/enabled:
(oh, also CONFIG_MMU is not set)


../arch/riscv/kernel/elf_kexec.c:346:5: error: redefinition of 'arch_kexec_apply_relocations_add'
  346 | int arch_kexec_apply_relocations_add(struct purgatory_info *pi,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../arch/riscv/kernel/elf_kexec.c:17:
../include/linux/kexec.h:236:1: note: previous definition of 'arch_kexec_apply_relocations_add' with type 'int(struct purgatory_info *, Elf64_Shdr *, const Elf64_Shdr *, const Elf64_Shdr *)' {aka 'int(struct purgatory_info *, struct elf64_shdr *, const struct elf64_shdr *, const struct elf64_shdr *)'}
  236 | arch_kexec_apply_relocations_add(struct purgatory_info *pi, Elf_Shdr *section,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../arch/riscv/kernel/elf_kexec.c: In function 'arch_kexec_apply_relocations_add':
../arch/riscv/kernel/elf_kexec.c:353:9: error: unknown type name 'Elf_Rela'; did you mean 'Elf64_Rela'?
  353 |         Elf_Rela *relas;
      |         ^~~~~~~~
      |         Elf64_Rela
In file included from ../arch/riscv/include/asm/elf.h:11,
                 from ../include/linux/elf.h:6,
                 from ../include/linux/module.h:19,
                 from ../arch/riscv/kernel/elf_kexec.c:15:
../arch/riscv/kernel/elf_kexec.c:371:44: error: request for member 'r_info' in something not a structure or union
  371 |                 sym += ELF64_R_SYM(relas[i].r_info);
      |                                            ^
../include/uapi/linux/elf.h:163:43: note: in definition of macro 'ELF64_R_SYM'
  163 | #define ELF64_R_SYM(i)                  ((i) >> 32)
      |                                           ^
../arch/riscv/kernel/elf_kexec.c:380:32: error: request for member 'r_offset' in something not a structure or union
  380 |                 loc += relas[i].r_offset;
      |                                ^
../arch/riscv/kernel/elf_kexec.c:393:32: error: request for member 'r_addend' in something not a structure or union
  393 |                 val += relas[i].r_addend;
      |                                ^
../arch/riscv/kernel/elf_kexec.c:395:51: error: request for member 'r_offset' in something not a structure or union
  395 |                 addr = section->sh_addr + relas[i].r_offset;
      |                                                   ^
In file included from ../arch/riscv/include/asm/elf.h:11,
                 from ../include/linux/elf.h:6,
                 from ../include/linux/module.h:19,
                 from ../arch/riscv/kernel/elf_kexec.c:15:
../arch/riscv/kernel/elf_kexec.c:397:47: error: request for member 'r_info' in something not a structure or union
  397 |                 r_type = ELF64_R_TYPE(relas[i].r_info);
      |                                               ^
../include/uapi/linux/elf.h:164:43: note: in definition of macro 'ELF64_R_TYPE'
  164 | #define ELF64_R_TYPE(i)                 ((i) & 0xffffffff)
      |                                           ^


Full randconfig file is attached.

-- 
~Randy

[-- Attachment #2: config-r3359.gz --]
[-- Type: application/gzip, Size: 35734 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Li Zhengyu <lizhengyu3@huawei.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: linux-next: Tree for May 31 (riscv: arch/riscv/kernel/elf_kexec.c)
Date: Tue, 31 May 2022 12:52:28 -0700	[thread overview]
Message-ID: <8971599c-fc8f-d69c-46b0-07f4c42fb195@infradead.org> (raw)
In-Reply-To: <20220531145458.39c00988@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 3310 bytes --]


838b3e28488f7: RISC-V: Load purgatory in kexec_file


On 5/30/22 21:54, Stephen Rothwell wrote:
> Hi all,
> 
> Note: please do not add any v5.20 material to your linux-next included
> branches until after v5.19-rc1 has been related.
> 
> Changes since 20220527:
> 

When CONFIG_MODULES is not set/enabled:
(oh, also CONFIG_MMU is not set)


../arch/riscv/kernel/elf_kexec.c:346:5: error: redefinition of 'arch_kexec_apply_relocations_add'
  346 | int arch_kexec_apply_relocations_add(struct purgatory_info *pi,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../arch/riscv/kernel/elf_kexec.c:17:
../include/linux/kexec.h:236:1: note: previous definition of 'arch_kexec_apply_relocations_add' with type 'int(struct purgatory_info *, Elf64_Shdr *, const Elf64_Shdr *, const Elf64_Shdr *)' {aka 'int(struct purgatory_info *, struct elf64_shdr *, const struct elf64_shdr *, const struct elf64_shdr *)'}
  236 | arch_kexec_apply_relocations_add(struct purgatory_info *pi, Elf_Shdr *section,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../arch/riscv/kernel/elf_kexec.c: In function 'arch_kexec_apply_relocations_add':
../arch/riscv/kernel/elf_kexec.c:353:9: error: unknown type name 'Elf_Rela'; did you mean 'Elf64_Rela'?
  353 |         Elf_Rela *relas;
      |         ^~~~~~~~
      |         Elf64_Rela
In file included from ../arch/riscv/include/asm/elf.h:11,
                 from ../include/linux/elf.h:6,
                 from ../include/linux/module.h:19,
                 from ../arch/riscv/kernel/elf_kexec.c:15:
../arch/riscv/kernel/elf_kexec.c:371:44: error: request for member 'r_info' in something not a structure or union
  371 |                 sym += ELF64_R_SYM(relas[i].r_info);
      |                                            ^
../include/uapi/linux/elf.h:163:43: note: in definition of macro 'ELF64_R_SYM'
  163 | #define ELF64_R_SYM(i)                  ((i) >> 32)
      |                                           ^
../arch/riscv/kernel/elf_kexec.c:380:32: error: request for member 'r_offset' in something not a structure or union
  380 |                 loc += relas[i].r_offset;
      |                                ^
../arch/riscv/kernel/elf_kexec.c:393:32: error: request for member 'r_addend' in something not a structure or union
  393 |                 val += relas[i].r_addend;
      |                                ^
../arch/riscv/kernel/elf_kexec.c:395:51: error: request for member 'r_offset' in something not a structure or union
  395 |                 addr = section->sh_addr + relas[i].r_offset;
      |                                                   ^
In file included from ../arch/riscv/include/asm/elf.h:11,
                 from ../include/linux/elf.h:6,
                 from ../include/linux/module.h:19,
                 from ../arch/riscv/kernel/elf_kexec.c:15:
../arch/riscv/kernel/elf_kexec.c:397:47: error: request for member 'r_info' in something not a structure or union
  397 |                 r_type = ELF64_R_TYPE(relas[i].r_info);
      |                                               ^
../include/uapi/linux/elf.h:164:43: note: in definition of macro 'ELF64_R_TYPE'
  164 | #define ELF64_R_TYPE(i)                 ((i) & 0xffffffff)
      |                                           ^


Full randconfig file is attached.

-- 
~Randy

[-- Attachment #2: config-r3359.gz --]
[-- Type: application/gzip, Size: 35734 bytes --]

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Li Zhengyu <lizhengyu3@huawei.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: linux-next: Tree for May 31 (riscv: arch/riscv/kernel/elf_kexec.c)
Date: Tue, 31 May 2022 12:52:28 -0700	[thread overview]
Message-ID: <8971599c-fc8f-d69c-46b0-07f4c42fb195@infradead.org> (raw)
In-Reply-To: <20220531145458.39c00988@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 3310 bytes --]


838b3e28488f7: RISC-V: Load purgatory in kexec_file


On 5/30/22 21:54, Stephen Rothwell wrote:
> Hi all,
> 
> Note: please do not add any v5.20 material to your linux-next included
> branches until after v5.19-rc1 has been related.
> 
> Changes since 20220527:
> 

When CONFIG_MODULES is not set/enabled:
(oh, also CONFIG_MMU is not set)


../arch/riscv/kernel/elf_kexec.c:346:5: error: redefinition of 'arch_kexec_apply_relocations_add'
  346 | int arch_kexec_apply_relocations_add(struct purgatory_info *pi,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../arch/riscv/kernel/elf_kexec.c:17:
../include/linux/kexec.h:236:1: note: previous definition of 'arch_kexec_apply_relocations_add' with type 'int(struct purgatory_info *, Elf64_Shdr *, const Elf64_Shdr *, const Elf64_Shdr *)' {aka 'int(struct purgatory_info *, struct elf64_shdr *, const struct elf64_shdr *, const struct elf64_shdr *)'}
  236 | arch_kexec_apply_relocations_add(struct purgatory_info *pi, Elf_Shdr *section,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../arch/riscv/kernel/elf_kexec.c: In function 'arch_kexec_apply_relocations_add':
../arch/riscv/kernel/elf_kexec.c:353:9: error: unknown type name 'Elf_Rela'; did you mean 'Elf64_Rela'?
  353 |         Elf_Rela *relas;
      |         ^~~~~~~~
      |         Elf64_Rela
In file included from ../arch/riscv/include/asm/elf.h:11,
                 from ../include/linux/elf.h:6,
                 from ../include/linux/module.h:19,
                 from ../arch/riscv/kernel/elf_kexec.c:15:
../arch/riscv/kernel/elf_kexec.c:371:44: error: request for member 'r_info' in something not a structure or union
  371 |                 sym += ELF64_R_SYM(relas[i].r_info);
      |                                            ^
../include/uapi/linux/elf.h:163:43: note: in definition of macro 'ELF64_R_SYM'
  163 | #define ELF64_R_SYM(i)                  ((i) >> 32)
      |                                           ^
../arch/riscv/kernel/elf_kexec.c:380:32: error: request for member 'r_offset' in something not a structure or union
  380 |                 loc += relas[i].r_offset;
      |                                ^
../arch/riscv/kernel/elf_kexec.c:393:32: error: request for member 'r_addend' in something not a structure or union
  393 |                 val += relas[i].r_addend;
      |                                ^
../arch/riscv/kernel/elf_kexec.c:395:51: error: request for member 'r_offset' in something not a structure or union
  395 |                 addr = section->sh_addr + relas[i].r_offset;
      |                                                   ^
In file included from ../arch/riscv/include/asm/elf.h:11,
                 from ../include/linux/elf.h:6,
                 from ../include/linux/module.h:19,
                 from ../arch/riscv/kernel/elf_kexec.c:15:
../arch/riscv/kernel/elf_kexec.c:397:47: error: request for member 'r_info' in something not a structure or union
  397 |                 r_type = ELF64_R_TYPE(relas[i].r_info);
      |                                               ^
../include/uapi/linux/elf.h:164:43: note: in definition of macro 'ELF64_R_TYPE'
  164 | #define ELF64_R_TYPE(i)                 ((i) & 0xffffffff)
      |                                           ^


Full randconfig file is attached.

-- 
~Randy

[-- Attachment #2: config-r3359.gz --]
[-- Type: application/gzip, Size: 35734 bytes --]

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2022-05-31 19:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  4:54 linux-next: Tree for May 31 Stephen Rothwell
2022-05-31 19:52 ` Randy Dunlap [this message]
2022-05-31 19:52   ` linux-next: Tree for May 31 (riscv: arch/riscv/kernel/elf_kexec.c) Randy Dunlap
2022-05-31 19:52   ` Randy Dunlap
2022-06-01  3:54   ` lizhengyu (E)
2022-06-01  3:54     ` lizhengyu
2022-06-01  3:54     ` lizhengyu (E)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8971599c-fc8f-d69c-46b0-07f4c42fb195@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lizhengyu3@huawei.com \
    --cc=palmer@rivosinc.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.