* [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion
@ 2019-05-05 10:51 Yuval Shaia
2019-05-06 13:31 ` Kamal Heib
2019-05-23 15:24 ` Markus Armbruster
0 siblings, 2 replies; 5+ messages in thread
From: Yuval Shaia @ 2019-05-05 10:51 UTC (permalink / raw)
To: marcel.apfelbaum, qemu-devel; +Cc: Yuval Shaia
This is a trivial cleanup patch.
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
hw/rdma/rdma_backend.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index d1660b6474..05f6b03221 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -14,16 +14,9 @@
*/
#include "qemu/osdep.h"
-#include "sysemu/sysemu.h"
-#include "qapi/error.h"
-#include "qapi/qmp/qlist.h"
-#include "qapi/qmp/qnum.h"
#include "qapi/qapi-events-rdma.h"
#include <infiniband/verbs.h>
-#include <infiniband/umad_types.h>
-#include <infiniband/umad.h>
-#include <rdma/rdma_user_cm.h>
#include "contrib/rdmacm-mux/rdmacm-mux.h"
#include "trace.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion
2019-05-05 10:51 [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion Yuval Shaia
@ 2019-05-06 13:31 ` Kamal Heib
2019-05-23 15:24 ` Markus Armbruster
1 sibling, 0 replies; 5+ messages in thread
From: Kamal Heib @ 2019-05-06 13:31 UTC (permalink / raw)
To: Yuval Shaia, marcel.apfelbaum, qemu-devel
On 5/5/19 1:51 PM, Yuval Shaia wrote:
> This is a trivial cleanup patch.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> hw/rdma/rdma_backend.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> index d1660b6474..05f6b03221 100644
> --- a/hw/rdma/rdma_backend.c
> +++ b/hw/rdma/rdma_backend.c
> @@ -14,16 +14,9 @@
> */
>
> #include "qemu/osdep.h"
> -#include "sysemu/sysemu.h"
> -#include "qapi/error.h"
> -#include "qapi/qmp/qlist.h"
> -#include "qapi/qmp/qnum.h"
> #include "qapi/qapi-events-rdma.h"
>
> #include <infiniband/verbs.h>
> -#include <infiniband/umad_types.h>
> -#include <infiniband/umad.h>
> -#include <rdma/rdma_user_cm.h>
>
> #include "contrib/rdmacm-mux/rdmacm-mux.h"
> #include "trace.h"
>
Reviewed-by: Kamal Heib <kheib@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion
2019-05-05 10:51 [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion Yuval Shaia
2019-05-06 13:31 ` Kamal Heib
@ 2019-05-23 15:24 ` Markus Armbruster
2019-05-24 5:29 ` Marcel Apfelbaum
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2019-05-23 15:24 UTC (permalink / raw)
To: Yuval Shaia; +Cc: qemu-trivial, qemu-devel
Looks stuck. Let's try qemu-trivial.
Yuval Shaia <yuval.shaia@oracle.com> writes:
> This is a trivial cleanup patch.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> hw/rdma/rdma_backend.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> index d1660b6474..05f6b03221 100644
> --- a/hw/rdma/rdma_backend.c
> +++ b/hw/rdma/rdma_backend.c
> @@ -14,16 +14,9 @@
> */
>
> #include "qemu/osdep.h"
> -#include "sysemu/sysemu.h"
> -#include "qapi/error.h"
> -#include "qapi/qmp/qlist.h"
> -#include "qapi/qmp/qnum.h"
> #include "qapi/qapi-events-rdma.h"
>
> #include <infiniband/verbs.h>
> -#include <infiniband/umad_types.h>
> -#include <infiniband/umad.h>
> -#include <rdma/rdma_user_cm.h>
>
> #include "contrib/rdmacm-mux/rdmacm-mux.h"
> #include "trace.h"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion
2019-05-23 15:24 ` Markus Armbruster
@ 2019-05-24 5:29 ` Marcel Apfelbaum
2019-05-28 7:00 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 1 reply; 5+ messages in thread
From: Marcel Apfelbaum @ 2019-05-24 5:29 UTC (permalink / raw)
To: Markus Armbruster, Yuval Shaia; +Cc: qemu-trivial, qemu-devel
Hi Markus,
On 5/23/19 6:24 PM, Markus Armbruster wrote:
> Looks stuck. Let's try qemu-trivial.
Thanks, that is a great idea.
I didn't want to send a single-patch pull request,
especially while another is waiting for reviews.
Anyway, trivial queue can be used indeed.
Thanks,
Marcel
>
> Yuval Shaia <yuval.shaia@oracle.com> writes:
>
>> This is a trivial cleanup patch.
>>
>> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
>> ---
>> hw/rdma/rdma_backend.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
>> index d1660b6474..05f6b03221 100644
>> --- a/hw/rdma/rdma_backend.c
>> +++ b/hw/rdma/rdma_backend.c
>> @@ -14,16 +14,9 @@
>> */
>>
>> #include "qemu/osdep.h"
>> -#include "sysemu/sysemu.h"
>> -#include "qapi/error.h"
>> -#include "qapi/qmp/qlist.h"
>> -#include "qapi/qmp/qnum.h"
>> #include "qapi/qapi-events-rdma.h"
>>
>> #include <infiniband/verbs.h>
>> -#include <infiniband/umad_types.h>
>> -#include <infiniband/umad.h>
>> -#include <rdma/rdma_user_cm.h>
>>
>> #include "contrib/rdmacm-mux/rdmacm-mux.h"
>> #include "trace.h"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/rdma: Delete unused headers inclusion
2019-05-24 5:29 ` Marcel Apfelbaum
@ 2019-05-28 7:00 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2019-05-28 7:00 UTC (permalink / raw)
To: Marcel Apfelbaum, Markus Armbruster, Yuval Shaia; +Cc: qemu-trivial, qemu-devel
On 24/05/2019 07:29, Marcel Apfelbaum wrote:
> Hi Markus,
>
> On 5/23/19 6:24 PM, Markus Armbruster wrote:
>> Looks stuck. Let's try qemu-trivial.
>
> Thanks, that is a great idea.
>
> I didn't want to send a single-patch pull request,
> especially while another is waiting for reviews.
> Anyway, trivial queue can be used indeed.
Applied to my trivial-patches branch.
Thanks,
Laurent
> Thanks,
> Marcel
>
>>
>> Yuval Shaia <yuval.shaia@oracle.com> writes:
>>
>>> This is a trivial cleanup patch.
>>>
>>> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
>>> ---
>>> hw/rdma/rdma_backend.c | 7 -------
>>> 1 file changed, 7 deletions(-)
>>>
>>> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
>>> index d1660b6474..05f6b03221 100644
>>> --- a/hw/rdma/rdma_backend.c
>>> +++ b/hw/rdma/rdma_backend.c
>>> @@ -14,16 +14,9 @@
>>> */
>>> #include "qemu/osdep.h"
>>> -#include "sysemu/sysemu.h"
>>> -#include "qapi/error.h"
>>> -#include "qapi/qmp/qlist.h"
>>> -#include "qapi/qmp/qnum.h"
>>> #include "qapi/qapi-events-rdma.h"
>>> #include <infiniband/verbs.h>
>>> -#include <infiniband/umad_types.h>
>>> -#include <infiniband/umad.h>
>>> -#include <rdma/rdma_user_cm.h>
>>> #include "contrib/rdmacm-mux/rdmacm-mux.h"
>>> #include "trace.h"
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-28 7:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 10:51 [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion Yuval Shaia
2019-05-06 13:31 ` Kamal Heib
2019-05-23 15:24 ` Markus Armbruster
2019-05-24 5:29 ` Marcel Apfelbaum
2019-05-28 7:00 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.