REQ: revert e129cb4cd2270f308c1564e75859672643dd902b (plugin: Remove completely)

REQ: revert e129cb4cd2270f308c1564e75859672643dd902b (plugin: Remove completely)

[Shawn Nock]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=e129cb4cd2270f308c1564e75859672643dd902b

I cannot find any discussion of the removal on the mailing list archive and as far as I can tell the patch wasn't sent to the list before commit. The commit says that there are no users. We use the plugin functionality. 

I can, of course, maintain this functionality separately. Plugin functionality is a fairly common pattern and while the current implementation isn't particularly nice, I did enjoy not having to re-implement it.

S

-- 
Shawn Nock <shawn@monadnock.ca>
Monadnock Systems Ltd.

Re: REQ: revert e129cb4cd2270f308c1564e75859672643dd902b (plugin: Remove completely)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]

Hi Shawn,

On 1/8/21 11:49 AM, Shawn Nock wrote:
> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=e129cb4cd2270f308c1564e75859672643dd902b
> 
> I cannot find any discussion of the removal on the mailing list archive and as far as I can tell the patch wasn't sent to the list before commit. The commit says that there are no users. We use the plugin functionality.

Indeed, there was no mailing list announcement.  In retrospect, we should have 
done so.

Note that we have not made any API/ABI stability promises as yet, so ell is 
still a moving target.  We have had no real reason to do so as we were not aware 
of any ell users outside of the core projects that we support (iwd, bluez, 
mptcpd, etc).

We have been wanting to make this particular change for a while.  The catalyst 
for the decision were reports of build issues on certain linkers with iwd/ell. 
Since we were about to make a release, instead of adding hot-fixes, which were 
objected to by some developers, we decided to take the whole thing out.  This 
was done after consulting with all known users of ell on IRC.

> 
> I can, of course, maintain this functionality separately. Plugin functionality is a fairly common pattern and while the current implementation isn't particularly nice, I did enjoy not having to re-implement it.

As you point out, the current implementation wasn't that hot, and there were no 
users among the core projects that we support.

If you want to add this back in, then it probably should be made into its own 
mini-library.  Something like 'ell-plugin'; any users would have to explicitly 
opt-in to use it rather than it being a part of the core ell library.

Regards,
-Denis

Re: REQ: revert e129cb4cd2270f308c1564e75859672643dd902b (plugin: Remove completely)

[Shawn Nock]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Fri, 8 Jan 2021, at 15:42, Denis Kenzior wrote:
> We have been wanting to make this particular change for a while.  The catalyst 
> for the decision were reports of build issues on certain linkers with iwd/ell. 
> Since we were about to make a release, instead of adding hot-fixes, which were 
> objected to by some developers, we decided to take the whole thing out.  This 
> was done after consulting with all known users of ell on IRC.

I was hoping for a revert on the grounds that it may have been a minor housekeeping sort of change, but this sounds like sufficient cause.

I've been getting my news here, but I'll make a note to lurk in #ell.

Thanks,
S

-- 
Shawn Nock <shawn@monadnock.ca>
Monadnock Systems Ltd.