* [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero
@ 2020-08-26 3:53 ` YueHaibing
0 siblings, 0 replies; 7+ messages in thread
From: YueHaibing @ 2020-08-26 3:53 UTC (permalink / raw)
To: nm, t-kristo, ssantosh, tglx, jason, maz, lokeshvutla
Cc: YueHaibing, linux-kernel, linux-arm-kernel
ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.
Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/irqchip/irq-ti-sci-intr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
index cbc1758228d9..85a72b56177c 100644
--- a/drivers/irqchip/irq-ti-sci-intr.c
+++ b/drivers/irqchip/irq-ti-sci-intr.c
@@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
struct ti_sci_intr_irq_domain *intr = domain->host_data;
struct device_node *parent_node;
struct irq_fwspec fwspec;
- u16 out_irq, p_hwirq;
- int err = 0;
+ int p_hwirq, err = 0;
+ u16 out_irq;
out_irq = ti_sci_get_free_resource(intr->out_irqs);
if (out_irq == TI_SCI_RESOURCE_NULL)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero
2020-08-26 3:53 ` YueHaibing
@ 2020-08-26 3:57 ` Lokesh Vutla
-1 siblings, 0 replies; 7+ messages in thread
From: Lokesh Vutla @ 2020-08-26 3:57 UTC (permalink / raw)
To: YueHaibing, nm, t-kristo, ssantosh, tglx, jason, maz
Cc: linux-arm-kernel, linux-kernel
On 26/08/20 9:23 am, YueHaibing wrote:
> ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
>
> Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the patch.
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> drivers/irqchip/irq-ti-sci-intr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
> index cbc1758228d9..85a72b56177c 100644
> --- a/drivers/irqchip/irq-ti-sci-intr.c
> +++ b/drivers/irqchip/irq-ti-sci-intr.c
> @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
> struct ti_sci_intr_irq_domain *intr = domain->host_data;
> struct device_node *parent_node;
> struct irq_fwspec fwspec;
> - u16 out_irq, p_hwirq;
> - int err = 0;
> + int p_hwirq, err = 0;
> + u16 out_irq;
>
> out_irq = ti_sci_get_free_resource(intr->out_irqs);
> if (out_irq == TI_SCI_RESOURCE_NULL)
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero
@ 2020-08-26 3:57 ` Lokesh Vutla
0 siblings, 0 replies; 7+ messages in thread
From: Lokesh Vutla @ 2020-08-26 3:57 UTC (permalink / raw)
To: YueHaibing, nm, t-kristo, ssantosh, tglx, jason, maz
Cc: linux-kernel, linux-arm-kernel
On 26/08/20 9:23 am, YueHaibing wrote:
> ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
>
> Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the patch.
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> drivers/irqchip/irq-ti-sci-intr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
> index cbc1758228d9..85a72b56177c 100644
> --- a/drivers/irqchip/irq-ti-sci-intr.c
> +++ b/drivers/irqchip/irq-ti-sci-intr.c
> @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
> struct ti_sci_intr_irq_domain *intr = domain->host_data;
> struct device_node *parent_node;
> struct irq_fwspec fwspec;
> - u16 out_irq, p_hwirq;
> - int err = 0;
> + int p_hwirq, err = 0;
> + u16 out_irq;
>
> out_irq = ti_sci_get_free_resource(intr->out_irqs);
> if (out_irq == TI_SCI_RESOURCE_NULL)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero
2020-08-26 3:53 ` YueHaibing
@ 2020-09-13 15:20 ` Marc Zyngier
-1 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2020-09-13 15:20 UTC (permalink / raw)
To: Thomas Bogendoerfer, Jason Cooper, Huacai Chen, Thomas Gleixner,
t-kristo, lokeshvutla, nm, ssantosh, YueHaibing
Cc: Huacai Chen, Fuxin Zhang, Jiaxun Yang, linux-mips, linux-kernel,
linux-arm-kernel
On Wed, 26 Aug 2020 11:53:21 +0800, YueHaibing wrote:
> ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
Applied to irq/irqchip-fixes-5.9, thanks!
[1/1] irqchip/ti-sci-intr: Fix unsigned comparison to zero
commit: 8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero
@ 2020-09-13 15:20 ` Marc Zyngier
0 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2020-09-13 15:20 UTC (permalink / raw)
To: Thomas Bogendoerfer, Jason Cooper, Huacai Chen, Thomas Gleixner,
t-kristo, lokeshvutla, nm, ssantosh, YueHaibing
Cc: Huacai Chen, linux-kernel, Jiaxun Yang, linux-mips, Fuxin Zhang,
linux-arm-kernel
On Wed, 26 Aug 2020 11:53:21 +0800, YueHaibing wrote:
> ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
Applied to irq/irqchip-fixes-5.9, thanks!
[1/1] irqchip/ti-sci-intr: Fix unsigned comparison to zero
commit: 8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip: irq/core] irqchip/ti-sci-intr: Fix unsigned comparison to zero
2020-08-26 3:53 ` YueHaibing
` (2 preceding siblings ...)
(?)
@ 2020-10-11 17:57 ` tip-bot2 for YueHaibing
-1 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for YueHaibing @ 2020-10-11 17:57 UTC (permalink / raw)
To: linux-tip-commits; +Cc: YueHaibing, Marc Zyngier, Lokesh Vutla, x86, LKML
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8
Gitweb: https://git.kernel.org/tip/8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8
Author: YueHaibing <yuehaibing@huawei.com>
AuthorDate: Wed, 26 Aug 2020 11:53:21 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 13 Sep 2020 15:30:00 +01:00
irqchip/ti-sci-intr: Fix unsigned comparison to zero
ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.
Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Link: https://lore.kernel.org/r/20200826035321.18620-1-yuehaibing@huawei.com
---
drivers/irqchip/irq-ti-sci-intr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
index cbc1758..85a72b5 100644
--- a/drivers/irqchip/irq-ti-sci-intr.c
+++ b/drivers/irqchip/irq-ti-sci-intr.c
@@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
struct ti_sci_intr_irq_domain *intr = domain->host_data;
struct device_node *parent_node;
struct irq_fwspec fwspec;
- u16 out_irq, p_hwirq;
- int err = 0;
+ int p_hwirq, err = 0;
+ u16 out_irq;
out_irq = ti_sci_get_free_resource(intr->out_irqs);
if (out_irq == TI_SCI_RESOURCE_NULL)
^ permalink raw reply related [flat|nested] 7+ messages in thread