* [PATCH] bond: update the NTT flag when partner's state changes from slow to fast
@ 2017-05-22 7:52 zhangsha.zhang
2017-06-27 10:12 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: zhangsha.zhang @ 2017-05-22 7:52 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, pawelx.wodkowski, jerry.lilijun, caihe, Sha Zhang
From: Sha Zhang <zhangsha.zhang@huawei.com>
According to the standard, state machine of lacp should transmit lacpdu
when partner's state changes from slow to fast, rather than from fast
to slow.
Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 7b863d6..742fd44 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -435,7 +435,7 @@
* In other case (was fast and now it is slow) just switch
* timeout to slow without forcing send of LACP (because standard
* say so)*/
- if (!is_partner_fast)
+ if (is_partner_fast)
SM_FLAG_SET(port, NTT);
} else
return; /* Nothing changed */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] bond: update the NTT flag when partner's state changes from slow to fast
2017-05-22 7:52 [PATCH] bond: update the NTT flag when partner's state changes from slow to fast zhangsha.zhang
@ 2017-06-27 10:12 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2017-06-27 10:12 UTC (permalink / raw)
To: zhangsha.zhang, dev
Cc: declan.doherty, pawelx.wodkowski, jerry.lilijun, caihe
On 5/22/2017 8:52 AM, zhangsha.zhang@huawei.com wrote:
> From: Sha Zhang <zhangsha.zhang@huawei.com>
>
> According to the standard, state machine of lacp should transmit lacpdu
> when partner's state changes from slow to fast, rather than from fast
> to slow.
>
> Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bond: update the NTT flag when partner's state changes from slow to fast
2017-05-22 6:40 zhangsha (A)
@ 2017-06-26 15:17 ` Declan Doherty
0 siblings, 0 replies; 5+ messages in thread
From: Declan Doherty @ 2017-06-26 15:17 UTC (permalink / raw)
To: zhangsha (A), dev; +Cc: pawelx.wodkowski, Lilijun (Jerry), caihe
On 22/05/2017 7:40 AM, zhangsha (A) wrote:
> From eddd395916002cca1c2f83a01d368b95295f2adf Mon Sep 17 00:00:00 2001
> From: Sha Zhang <zhangsha.zhang@huawei.com>
> Date: Mon, 22 May 2017 14:33:37 +0800
> Subject: [PATCH] bond: update the NTT flag when partner's state changes from
> slow to fast
>
> According to the standard, state machine of lacp should transmit lacpdu
> when partner's state changes from slow to fast, rather than from fast to slow.
>
> Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
> ---
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] bond: update the NTT flag when partner's state changes from slow to fast
@ 2017-05-22 7:44 zhangsha.zhang
0 siblings, 0 replies; 5+ messages in thread
From: zhangsha.zhang @ 2017-05-22 7:44 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, pawelx.wodkowski, jerry.lilijun, caihe, Sha Zhang
From: Sha Zhang <zhangsha.zhang@huawei.com>
According to the standard, state machine of lacp should transmit lacpdu
when partner's state changes from slow to fast, rather than from fast to slow.
Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 7b863d6..742fd44 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -435,7 +435,7 @@
* In other case (was fast and now it is slow) just switch
* timeout to slow without forcing send of LACP (because standard
* say so)*/
- if (!is_partner_fast)
+ if (is_partner_fast)
SM_FLAG_SET(port, NTT);
} else
return; /* Nothing changed */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] bond: update the NTT flag when partner's state changes from slow to fast
@ 2017-05-22 6:40 zhangsha (A)
2017-06-26 15:17 ` Declan Doherty
0 siblings, 1 reply; 5+ messages in thread
From: zhangsha (A) @ 2017-05-22 6:40 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, pawelx.wodkowski, Lilijun (Jerry), caihe
>From eddd395916002cca1c2f83a01d368b95295f2adf Mon Sep 17 00:00:00 2001
From: Sha Zhang <zhangsha.zhang@huawei.com>
Date: Mon, 22 May 2017 14:33:37 +0800
Subject: [PATCH] bond: update the NTT flag when partner's state changes from
slow to fast
According to the standard, state machine of lacp should transmit lacpdu
when partner's state changes from slow to fast, rather than from fast to slow.
Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 7b863d6..742fd44 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -435,7 +435,7 @@
* In other case (was fast and now it is slow) just switch
* timeout to slow without forcing send of LACP (because standard
* say so)*/
- if (!is_partner_fast)
+ if (is_partner_fast)
SM_FLAG_SET(port, NTT);
} else
return; /* Nothing changed */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-27 10:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 7:52 [PATCH] bond: update the NTT flag when partner's state changes from slow to fast zhangsha.zhang
2017-06-27 10:12 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-05-22 7:44 zhangsha.zhang
2017-05-22 6:40 zhangsha (A)
2017-06-26 15:17 ` Declan Doherty
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.