From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "roy-cw.yeh" <roy-cw.yeh@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Moudy Ho <moudy.ho@mediatek.com>,
"river . cheng" <river.cheng@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/9] media: platform: mtk-mdp3: add chip independence architecture
Date: Wed, 20 Oct 2021 11:29:27 +0200 [thread overview]
Message-ID: <89b3f65d-3ad1-5f81-7e16-0c00db74678b@collabora.com> (raw)
In-Reply-To: <20211020071448.14187-4-roy-cw.yeh@mediatek.com>
Il 20/10/21 09:14, roy-cw.yeh ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Add chip independence architecture
> - Add hal architecture for mt8183
> - Add driver data to adapt other soc
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 154 ++++---
> .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 181 ++++-----
> .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 193 ++++++++-
> .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 383 +++++++++++++++++-
> .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 19 +
> .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 10 +-
> .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 259 +-----------
> .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 268 ++++++------
> 8 files changed, 925 insertions(+), 542 deletions(-)
>
snip...
> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> index a6caefb097be..50fd5430a565 100644
> --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
snip..
> @@ -732,7 +514,7 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
> param->num_captures = 1;
> frame = ¶m->captures[0];
> frame->format.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> - frame->mdp_fmt = mdp_try_fmt_mplane(&frame->format, param, 0);
> + frame->mdp_fmt = mdp_try_fmt_mplane(mdp, &frame->format, param, 0);
> frame->ycbcr_prof =
> mdp_map_ycbcr_prof_mplane(&frame->format,
> frame->mdp_fmt->mdp_color);
> @@ -744,3 +526,4 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
>
> return 0;
> }
> +
Please remove this empty new line.
Apart from that,
Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "roy-cw.yeh" <roy-cw.yeh@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Moudy Ho <moudy.ho@mediatek.com>,
"river . cheng" <river.cheng@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/9] media: platform: mtk-mdp3: add chip independence architecture
Date: Wed, 20 Oct 2021 11:29:27 +0200 [thread overview]
Message-ID: <89b3f65d-3ad1-5f81-7e16-0c00db74678b@collabora.com> (raw)
In-Reply-To: <20211020071448.14187-4-roy-cw.yeh@mediatek.com>
Il 20/10/21 09:14, roy-cw.yeh ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Add chip independence architecture
> - Add hal architecture for mt8183
> - Add driver data to adapt other soc
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 154 ++++---
> .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 181 ++++-----
> .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 193 ++++++++-
> .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 383 +++++++++++++++++-
> .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 19 +
> .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 10 +-
> .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 259 +-----------
> .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 268 ++++++------
> 8 files changed, 925 insertions(+), 542 deletions(-)
>
snip...
> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> index a6caefb097be..50fd5430a565 100644
> --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
snip..
> @@ -732,7 +514,7 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
> param->num_captures = 1;
> frame = ¶m->captures[0];
> frame->format.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> - frame->mdp_fmt = mdp_try_fmt_mplane(&frame->format, param, 0);
> + frame->mdp_fmt = mdp_try_fmt_mplane(mdp, &frame->format, param, 0);
> frame->ycbcr_prof =
> mdp_map_ycbcr_prof_mplane(&frame->format,
> frame->mdp_fmt->mdp_color);
> @@ -744,3 +526,4 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
>
> return 0;
> }
> +
Please remove this empty new line.
Apart from that,
Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "roy-cw.yeh" <roy-cw.yeh@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Moudy Ho <moudy.ho@mediatek.com>,
"river . cheng" <river.cheng@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/9] media: platform: mtk-mdp3: add chip independence architecture
Date: Wed, 20 Oct 2021 11:29:27 +0200 [thread overview]
Message-ID: <89b3f65d-3ad1-5f81-7e16-0c00db74678b@collabora.com> (raw)
In-Reply-To: <20211020071448.14187-4-roy-cw.yeh@mediatek.com>
Il 20/10/21 09:14, roy-cw.yeh ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Add chip independence architecture
> - Add hal architecture for mt8183
> - Add driver data to adapt other soc
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 154 ++++---
> .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 181 ++++-----
> .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 193 ++++++++-
> .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 383 +++++++++++++++++-
> .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 19 +
> .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 10 +-
> .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 259 +-----------
> .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 268 ++++++------
> 8 files changed, 925 insertions(+), 542 deletions(-)
>
snip...
> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> index a6caefb097be..50fd5430a565 100644
> --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
snip..
> @@ -732,7 +514,7 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
> param->num_captures = 1;
> frame = ¶m->captures[0];
> frame->format.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> - frame->mdp_fmt = mdp_try_fmt_mplane(&frame->format, param, 0);
> + frame->mdp_fmt = mdp_try_fmt_mplane(mdp, &frame->format, param, 0);
> frame->ycbcr_prof =
> mdp_map_ycbcr_prof_mplane(&frame->format,
> frame->mdp_fmt->mdp_color);
> @@ -744,3 +526,4 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
>
> return 0;
> }
> +
Please remove this empty new line.
Apart from that,
Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-20 9:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 7:14 [PATCH v2 0/9] Add mdp support for mt8195 roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 7:14 ` [PATCH v2 1/9] soc: mediatek: mmsys: expand MDP enum for chip independence architecture roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 9:30 ` AngeloGioacchino Del Regno
2021-10-20 9:30 ` AngeloGioacchino Del Regno
2021-10-20 7:14 ` [PATCH v2 2/9] soc: mediatek: mutex: expand parameter for mdp mutex function roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 9:29 ` AngeloGioacchino Del Regno
2021-10-20 9:29 ` AngeloGioacchino Del Regno
2021-10-20 9:29 ` AngeloGioacchino Del Regno
2021-10-20 7:14 ` [PATCH v2 3/9] media: platform: mtk-mdp3: add chip independence architecture roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 9:29 ` AngeloGioacchino Del Regno [this message]
2021-10-20 9:29 ` AngeloGioacchino Del Regno
2021-10-20 9:29 ` AngeloGioacchino Del Regno
2021-10-20 7:14 ` [PATCH v2 4/9] dt-bindings: media: mediatek: mdp3: add additional function block yaml roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 7:14 ` [PATCH v2 5/9] arm64: dts: mt8195: add mdp3 node roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 7:14 ` [PATCH v2 6/9] soc: mediatek: mmsys: support mt8195 vppsys0/1 roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 7:14 ` [PATCH v2 7/9] soc: mediatek: mutex: " roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 7:14 ` [PATCH v2 8/9] media: platform: mtk-mdp3: support mt8195 roy-cw.yeh
2021-10-20 9:29 ` AngeloGioacchino Del Regno
2021-10-20 7:14 ` [PATCH v2 9/9] media: platform: mtk-mdp3: Add dual pipe feature support roy-cw.yeh
2021-10-20 7:14 ` roy-cw.yeh
2021-10-20 9:28 ` AngeloGioacchino Del Regno
2021-10-20 9:28 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89b3f65d-3ad1-5f81-7e16-0c00db74678b@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=ping-hsun.wu@mediatek.com \
--cc=river.cheng@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=roy-cw.yeh@mediatek.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.