* [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry
@ 2021-07-09 11:22 Geliang Tang
2021-07-09 17:38 ` Mat Martineau
2021-07-16 9:17 ` Matthieu Baerts
0 siblings, 2 replies; 3+ messages in thread
From: Geliang Tang @ 2021-07-09 11:22 UTC (permalink / raw)
To: mptcp; +Cc: Geliang Tang
kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
struct mptcp_pm_addr_entry became useless. Let's drop it.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
net/mptcp/pm_netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index d2591ebf01d9..56263c2c4014 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -27,7 +27,6 @@ struct mptcp_pm_addr_entry {
struct mptcp_addr_info addr;
u8 flags;
int ifindex;
- struct rcu_head rcu;
struct socket *lsk;
};
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry
2021-07-09 11:22 [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry Geliang Tang
@ 2021-07-09 17:38 ` Mat Martineau
2021-07-16 9:17 ` Matthieu Baerts
1 sibling, 0 replies; 3+ messages in thread
From: Mat Martineau @ 2021-07-09 17:38 UTC (permalink / raw)
To: Geliang Tang; +Cc: mptcp
On Fri, 9 Jul 2021, Geliang Tang wrote:
> kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
> struct mptcp_pm_addr_entry became useless. Let's drop it.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Thanks for spotting this!
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> ---
> net/mptcp/pm_netlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
> index d2591ebf01d9..56263c2c4014 100644
> --- a/net/mptcp/pm_netlink.c
> +++ b/net/mptcp/pm_netlink.c
> @@ -27,7 +27,6 @@ struct mptcp_pm_addr_entry {
> struct mptcp_addr_info addr;
> u8 flags;
> int ifindex;
> - struct rcu_head rcu;
> struct socket *lsk;
> };
>
> --
> 2.31.1
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry
2021-07-09 11:22 [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry Geliang Tang
2021-07-09 17:38 ` Mat Martineau
@ 2021-07-16 9:17 ` Matthieu Baerts
1 sibling, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2021-07-16 9:17 UTC (permalink / raw)
To: Geliang Tang, mptcp
Hi Geliang, Mat,
On 09/07/2021 13:22, Geliang Tang wrote:
> kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
> struct mptcp_pm_addr_entry became useless. Let's drop it.
Thank you for the patch and the review!
I just applied it in our tree with a Fixes tag and Mat's RvB one. I
think this one can be sent to the -net tree:
- 1d500114ddb0: mptcp: drop unuse rcu in mptcp_pm_addr_entry
- Results: 471dab437a02..1187a6e1e0e7
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210716T091701
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210716T091701
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-16 9:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 11:22 [MPTCP][PATCH mptcp-next] mptcp: drop unuse rcu in mptcp_pm_addr_entry Geliang Tang
2021-07-09 17:38 ` Mat Martineau
2021-07-16 9:17 ` Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.