* [gatesgarth][PATCH] license_image.bbclass: Don't attempt to symlink to the same file @ 2021-02-05 14:24 Mike Looijmans 2021-02-05 14:44 ` [OE-core] " Anuj Mittal 0 siblings, 1 reply; 4+ messages in thread From: Mike Looijmans @ 2021-02-05 14:24 UTC (permalink / raw) To: openembedded-core; +Cc: Mike Looijmans Sometimes (that is, in all my builds) the lic_manifest_dir and lic_manifest_symlink_dir end up pointing to the same file, resulting in an error like this: Exception: FileExistsError: [Errno 17] File exists: '/.../tmp-glibc/deploy/licenses/my-image-tdkz15' -> '/.../tmp-glibc/deploy/licenses/my-image-tdkz15' First check to see if this is the case before attempting to create the link. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- meta/classes/license_image.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/classes/license_image.bbclass b/meta/classes/license_image.bbclass index 119c8dfc86..6f478ce22c 100644 --- a/meta/classes/license_image.bbclass +++ b/meta/classes/license_image.bbclass @@ -210,7 +210,8 @@ def license_deployed_manifest(d): os.unlink(lic_manifest_symlink_dir) # create the image dir symlink - os.symlink(lic_manifest_dir, lic_manifest_symlink_dir) + if lic_manifest_dir != lic_manifest_symlink_dir: + os.symlink(lic_manifest_dir, lic_manifest_symlink_dir) def get_deployed_dependencies(d): """ -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [gatesgarth][PATCH] license_image.bbclass: Don't attempt to symlink to the same file 2021-02-05 14:24 [gatesgarth][PATCH] license_image.bbclass: Don't attempt to symlink to the same file Mike Looijmans @ 2021-02-05 14:44 ` Anuj Mittal [not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2911e63c-9e5c-4e4f-ace5-3d0373a59996@emailsignatures365.codetwo.com> 0 siblings, 1 reply; 4+ messages in thread From: Anuj Mittal @ 2021-02-05 14:44 UTC (permalink / raw) To: mike.looijmans, openembedded-core On Fri, 2021-02-05 at 15:24 +0100, Mike Looijmans wrote: > Sometimes (that is, in all my builds) the lic_manifest_dir and > lic_manifest_symlink_dir end up pointing to the same file, resulting > in an error like this: > Exception: FileExistsError: [Errno 17] File exists: '/.../tmp- > glibc/deploy/licenses/my-image-tdkz15' -> '/.../tmp- > glibc/deploy/licenses/my-image-tdkz15' > > First check to see if this is the case before attempting to create > the link. Is this not required in master branch? I can't see this change there. Thanks, Anuj ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2911e63c-9e5c-4e4f-ace5-3d0373a59996@emailsignatures365.codetwo.com>]
[parent not found: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.0c810297-d118-4896-b755-845b359e15b7@emailsignatures365.codetwo.com>]
* Re: [OE-core] [gatesgarth][PATCH] license_image.bbclass: Don't attempt to symlink to the same file [not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.0c810297-d118-4896-b755-845b359e15b7@emailsignatures365.codetwo.com> @ 2021-02-05 14:51 ` Mike Looijmans [not found] ` <1660E19B8E4F9B35.26096@lists.openembedded.org> 1 sibling, 0 replies; 4+ messages in thread From: Mike Looijmans @ 2021-02-05 14:51 UTC (permalink / raw) To: Mittal, Anuj, openembedded-core Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijmans@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On 05-02-2021 15:44, Mittal, Anuj wrote: > On Fri, 2021-02-05 at 15:24 +0100, Mike Looijmans wrote: >> Sometimes (that is, in all my builds) the lic_manifest_dir and >> lic_manifest_symlink_dir end up pointing to the same file, resulting >> in an error like this: >> Exception: FileExistsError: [Errno 17] File exists: '/.../tmp- >> glibc/deploy/licenses/my-image-tdkz15' -> '/.../tmp- >> glibc/deploy/licenses/my-image-tdkz15' >> >> First check to see if this is the case before attempting to create >> the link. > Is this not required in master branch? I can't see this change there. Probably yes, too. And half the commit message got lost somewhere. I'll try a resend... -- Mike Looijmans ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1660E19B8E4F9B35.26096@lists.openembedded.org>]
* Re: [OE-core] [gatesgarth][PATCH] license_image.bbclass: Don't attempt to symlink to the same file [not found] ` <1660E19B8E4F9B35.26096@lists.openembedded.org> @ 2021-02-05 14:58 ` Mike Looijmans 0 siblings, 0 replies; 4+ messages in thread From: Mike Looijmans @ 2021-02-05 14:58 UTC (permalink / raw) To: openembedded-core Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijmans@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On 05-02-2021 15:51, Mike Looijmans via lists.openembedded.org wrote: > On 05-02-2021 15:44, Mittal, Anuj wrote: >> On Fri, 2021-02-05 at 15:24 +0100, Mike Looijmans wrote: >>> Sometimes (that is, in all my builds) the lic_manifest_dir and >>> lic_manifest_symlink_dir end up pointing to the same file, resulting >>> in an error like this: >>> Exception: FileExistsError: [Errno 17] File exists: '/.../tmp- >>> glibc/deploy/licenses/my-image-tdkz15' -> '/.../tmp- >>> glibc/deploy/licenses/my-image-tdkz15' >>> >>> First check to see if this is the case before attempting to create >>> the link. >> Is this not required in master branch? I can't see this change there. > > Probably yes, too. > > And half the commit message got lost somewhere. I'll try a resend... Oh weird... Apparently the company mailserver that did that. The version on the list is okay, the one in my mailbox lacks the first half of the commit text. Same with the v2 mail. -- Mike Looijmans ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-05 14:58 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-05 14:24 [gatesgarth][PATCH] license_image.bbclass: Don't attempt to symlink to the same file Mike Looijmans 2021-02-05 14:44 ` [OE-core] " Anuj Mittal [not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.2911e63c-9e5c-4e4f-ace5-3d0373a59996@emailsignatures365.codetwo.com> [not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.0c810297-d118-4896-b755-845b359e15b7@emailsignatures365.codetwo.com> 2021-02-05 14:51 ` Mike Looijmans [not found] ` <1660E19B8E4F9B35.26096@lists.openembedded.org> 2021-02-05 14:58 ` Mike Looijmans
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.