Re: [PATCH 1/3] console_codes.4: \e[21m is now underline

Re: [PATCH 1/3] console_codes.4: \e[21m is now underline

[Michael Kerrisk (man-pages)]

Hello Adam,

On 3/8/19 8:40 PM, Adam Borowski wrote:
> Since 65d9982d7 (4.17), it follows xterm rather than common sense and
> consistency, being the only command 1..9 where N+20 doesn't undo what
> N did.  As libvte 0.51.90 got changed the same way, this behaviour will
> probably stay.
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>

Thanks. Patch applied.

Cheers,

Michael

> ---
>  man4/console_codes.4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man4/console_codes.4 b/man4/console_codes.4
> index 35f52fc64..d605b058d 100644
> --- a/man4/console_codes.4
> +++ b/man4/console_codes.4
> @@ -258,7 +258,7 @@ The toggle meta flag
>  causes the high bit of a byte to be toggled
>  before the mapping table translation is done.
>  T}
> -21	set normal intensity (ECMA-48 says "doubly underlined")
> +21	set underline (<4.17 and many other terminals set normal intensity)
>  22	set normal intensity
>  24	underline off
>  25	blink off
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH 3/3] console_codes.4: \e[90m to 97, 100 to 107

[Michael Kerrisk (man-pages)]

Hello Adam,

On 3/8/19 8:40 PM, Adam Borowski wrote:
> Supported since fadb4244 (4.9), 100..107 are supposed to be bright but
> this does not yet work (unmerged patches to do so exist).

Thanks. Patch applied.

I will send some further comments to this patch series in another
mail shortly, since I think we should document should still
document the historical behavior.

Cheers,

Michael

> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>  man4/console_codes.4 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/man4/console_codes.4 b/man4/console_codes.4
> index 4283efe45..b77441ac3 100644
> --- a/man4/console_codes.4
> +++ b/man4/console_codes.4
> @@ -283,6 +283,8 @@ T}
>  47	set white background
>  48	256/24-bit background color follows, shoehorned into 8 basic colors
>  49	set default background color
> +90..97	set foreground to bright versions of 30..37
> +100.107	set background, same as 40..47 (bright not supported)
>  .TE
>  .PP
>  Commands 38 and 48 require further arguments:
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH 2/3] console_codes.4: \e[38m and \e[48m

[Michael Kerrisk (man-pages)]

Hello Adam,

On 3/8/19 8:40 PM, Adam Borowski wrote:
> Supported since cec5b2a9 (3.16).
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>

Thanks. Patch applied.

Cheers,

Michael

> ---
>  man4/console_codes.4 | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/man4/console_codes.4 b/man4/console_codes.4
> index d605b058d..4283efe45 100644
> --- a/man4/console_codes.4
> +++ b/man4/console_codes.4
> @@ -271,8 +271,8 @@ T}
>  35	set magenta foreground
>  36	set cyan foreground
>  37	set white foreground
> -38	set underscore on, set default foreground color
> -39	set underscore off, set default foreground color
> +38	256/24-bit foreground color follows, shoehorned into 16 basic colors
> +39	set default foreground color
>  40	set black background
>  41	set red background
>  42	set green background
> @@ -281,9 +281,20 @@ T}
>  45	set magenta background
>  46	set cyan background
>  47	set white background
> +48	256/24-bit background color follows, shoehorned into 8 basic colors
>  49	set default background color
>  .TE
>  .PP
> +Commands 38 and 48 require further arguments:
> +.TS
> +l l.
> +;5;x	T{
> +256 color: values 0..15 are IBGR (black, red, green, ... white),
> +16..231 a 6x6x6 color cube, 232..255 a grayscale ramp
> +T}
> +;2;r;g;b	24-bit color, components go 0..255
> +.TE
> +.PP
>  .B ECMA-48 Mode Switches
>  .TP
>  ESC [ 3 h
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH 2/3] console_codes.4: \e[38m and \e[48m

[Michael Kerrisk (man-pages)]

Hello Adam,

On 3/8/19 8:40 PM, Adam Borowski wrote:
> Supported since cec5b2a9 (3.16).
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>  man4/console_codes.4 | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/man4/console_codes.4 b/man4/console_codes.4
> index d605b058d..4283efe45 100644
> --- a/man4/console_codes.4
> +++ b/man4/console_codes.4
> @@ -271,8 +271,8 @@ T}
>  35	set magenta foreground
>  36	set cyan foreground
>  37	set white foreground
> -38	set underscore on, set default foreground color
> -39	set underscore off, set default foreground color
> +38	256/24-bit foreground color follows, shoehorned into 16 basic colors
> +39	set default foreground color

So here, I think it's important to retain the historical info, so
I made this text:

       38        256/24-bit foreground color follows, shoehorned  into  16
                 basic  colors  (before Linux 3.16: set underscore on, set
                 default foreground color)
       39        set default foreground  color  (before  Linux  3.16:  set
                 underscore off, set default foreground color)

Okay?

Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH 2/3] console_codes.4: \e[38m and \e[48m

[Adam Borowski]

On Fri, Feb 07, 2020 at 05:26:09PM +0100, Michael Kerrisk (man-pages) wrote:
> Hello Adam,
> 
> On 3/8/19 8:40 PM, Adam Borowski wrote:
> > Supported since cec5b2a9 (3.16).
> > 
> > Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> > ---
> >  man4/console_codes.4 | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> > 
> > diff --git a/man4/console_codes.4 b/man4/console_codes.4
> > index d605b058d..4283efe45 100644
> > --- a/man4/console_codes.4
> > +++ b/man4/console_codes.4
> > @@ -271,8 +271,8 @@ T}
> >  35	set magenta foreground
> >  36	set cyan foreground
> >  37	set white foreground
> > -38	set underscore on, set default foreground color
> > -39	set underscore off, set default foreground color
> > +38	256/24-bit foreground color follows, shoehorned into 16 basic colors
> > +39	set default foreground color
> 
> So here, I think it's important to retain the historical info, so
> I made this text:
> 
>        38        256/24-bit foreground color follows, shoehorned  into  16
>                  basic  colors  (before Linux 3.16: set underscore on, set
>                  default foreground color)
>        39        set default foreground  color  (before  Linux  3.16:  set
>                  underscore off, set default foreground color)
> 
> Okay?

Sounds good.


Meow!

-- 
⢀⣴⠾⠻⢶⣦⠀ The ill-thought conversion to time64_t will make us suffer from
⣾⠁⢠⠒⠀⣿⡁ the Y292B problem.  So let's move the Epoch by 435451400064000000
⢿⡄⠘⠷⠚⠋⠀ (plus a safety margin in case of bad physicists) and make it
⠈⠳⣄⠀⠀⠀⠀ unsigned -- that'll almost double the range.