* Re: [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX
@ 2023-02-11 22:39 Sam James
0 siblings, 0 replies; 4+ messages in thread
From: Sam James @ 2023-02-11 22:39 UTC (permalink / raw)
To: linux-cifs; +Cc: Sam James
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
Ping
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX
@ 2022-08-16 0:43 Sam James
2024-03-26 1:26 ` Pavel Shilovsky
0 siblings, 1 reply; 4+ messages in thread
From: Sam James @ 2022-08-16 0:43 UTC (permalink / raw)
To: Pavel Shilovsky, linux-cifs; +Cc: Pavel Shilovsky, Sam James
Needed to build on musl. It only works on glibc because of transitive includes
(which could break in future).
Example failure:
```
getcifsacl.c: In function 'getcifsacl':
getcifsacl.c:429:24: error: 'XATTR_SIZE_MAX' undeclared (first use in this function)
429 | if (bufsize >= XATTR_SIZE_MAX) {
| ^~~~~~~~~~~~~~
```
Bug: https://bugs.gentoo.org/842195
Signed-off-by: Sam James <sam@gentoo.org>
---
getcifsacl.c | 1 +
setcifsacl.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/getcifsacl.c b/getcifsacl.c
index 1c01062..d69d40a 100644
--- a/getcifsacl.c
+++ b/getcifsacl.c
@@ -34,6 +34,7 @@
#include <errno.h>
#include <limits.h>
#include <ctype.h>
+#include <linux/limits.h>
#include <sys/xattr.h>
#include "cifsacl.h"
#include "idmap_plugin.h"
diff --git a/setcifsacl.c b/setcifsacl.c
index d832cec..b7079ab 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -48,6 +48,7 @@
#include <errno.h>
#include <limits.h>
#include <ctype.h>
+#include <linux/limits.h>
#include <sys/xattr.h>
#include "cifsacl.h"
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX
2022-08-16 0:43 Sam James
@ 2024-03-26 1:26 ` Pavel Shilovsky
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Shilovsky @ 2024-03-26 1:26 UTC (permalink / raw)
To: Sam James; +Cc: linux-cifs, Steve French
Merged #1 and #2 into next. Thanks. Sorry, I missed these patches previously.
Best regards,
Pavel Shilovsky
пн, 15 авг. 2022 г. в 17:43, Sam James <sam@gentoo.org>:
>
> Needed to build on musl. It only works on glibc because of transitive includes
> (which could break in future).
>
> Example failure:
> ```
> getcifsacl.c: In function 'getcifsacl':
> getcifsacl.c:429:24: error: 'XATTR_SIZE_MAX' undeclared (first use in this function)
> 429 | if (bufsize >= XATTR_SIZE_MAX) {
> | ^~~~~~~~~~~~~~
> ```
>
> Bug: https://bugs.gentoo.org/842195
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
> getcifsacl.c | 1 +
> setcifsacl.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/getcifsacl.c b/getcifsacl.c
> index 1c01062..d69d40a 100644
> --- a/getcifsacl.c
> +++ b/getcifsacl.c
> @@ -34,6 +34,7 @@
> #include <errno.h>
> #include <limits.h>
> #include <ctype.h>
> +#include <linux/limits.h>
> #include <sys/xattr.h>
> #include "cifsacl.h"
> #include "idmap_plugin.h"
> diff --git a/setcifsacl.c b/setcifsacl.c
> index d832cec..b7079ab 100644
> --- a/setcifsacl.c
> +++ b/setcifsacl.c
> @@ -48,6 +48,7 @@
> #include <errno.h>
> #include <limits.h>
> #include <ctype.h>
> +#include <linux/limits.h>
> #include <sys/xattr.h>
>
> #include "cifsacl.h"
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX
@ 2022-06-24 4:54 Sam James
0 siblings, 0 replies; 4+ messages in thread
From: Sam James @ 2022-06-24 4:54 UTC (permalink / raw)
To: linux-cifs; +Cc: Sam James
Needed to build on musl. It only works on glibc because of transitive includes
(which could break in future).
Example failure:
```
getcifsacl.c: In function 'getcifsacl':
getcifsacl.c:429:24: error: 'XATTR_SIZE_MAX' undeclared (first use in this function)
429 | if (bufsize >= XATTR_SIZE_MAX) {
| ^~~~~~~~~~~~~~
```
Bug: https://bugs.gentoo.org/842195
Signed-off-by: Sam James <sam@gentoo.org>
---
getcifsacl.c | 1 +
setcifsacl.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/getcifsacl.c b/getcifsacl.c
index 1c01062..d69d40a 100644
--- a/getcifsacl.c
+++ b/getcifsacl.c
@@ -34,6 +34,7 @@
#include <errno.h>
#include <limits.h>
#include <ctype.h>
+#include <linux/limits.h>
#include <sys/xattr.h>
#include "cifsacl.h"
#include "idmap_plugin.h"
diff --git a/setcifsacl.c b/setcifsacl.c
index 9840b14..e925d59 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -48,6 +48,7 @@
#include <errno.h>
#include <limits.h>
#include <ctype.h>
+#include <linux/limits.h>
#include <sys/xattr.h>
#include "cifsacl.h"
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-26 1:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-11 22:39 [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX Sam James
-- strict thread matches above, loose matches on Subject: below --
2022-08-16 0:43 Sam James
2024-03-26 1:26 ` Pavel Shilovsky
2022-06-24 4:54 Sam James
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.