phosphor-pid-control

phosphor-pid-control

[George Liu (刘锡伟)]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi, All:
Excuse me, I have a problem, 727 lines of dbus/dbusconfiguration.cpp in the phosphor-pid-control code,
which I think is info.stepwiseInfo.NegativeHysteresis, as follows:

If (findPosHyst != base.end())
{
info.stepwiseInfo.positiveHysteresis = std::visit(
VariantToDoubleVisitor(), findPosHyst->second);
}
If (findNegHyst != base.end())
{
info.stepwiseInfo.positiveHysteresis = std::visit(
VariantToDoubleVisitor(), findNegHyst->second);
}

What do you think?
Thanks!

[-- Attachment #2: Type: text/html, Size: 3546 bytes --]

Re: phosphor-pid-control

[James Feist]

On 4/2/19 5:43 AM, George Liu (刘锡伟) wrote:
> Hi, All:
> 
> Excuse me, I have a problem, 727 lines of dbus/dbusconfiguration.cpp in 
> the phosphor-pid-control code,
> 
> which I think is info.stepwiseInfo.NegativeHysteresis, as follows:
> 
> If (findPosHyst != base.end())
> 
> {
> 
> info.stepwiseInfo.positiveHysteresis = std::visit(
> 
> VariantToDoubleVisitor(), findPosHyst->second);
> 
> }
> 
> If (findNegHyst != base.end())
> 
> {
> 
> info.stepwiseInfo.positiveHysteresis = std::visit(
> 
> VariantToDoubleVisitor(), findNegHyst->second);
> 
> }
> 
> What do you think?

Good catch, fix is here: 
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/20031

-James

> 
> Thanks!
>