From: Brian Gernhardt <benji@silverinsanity.com>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Quick description of possible gitattributes system
Date: Fri, 2 Mar 2007 15:35:16 -0500 [thread overview]
Message-ID: <8CAB85E5-A98E-4A25-9CC2-3E59106E655C@silverinsanity.com> (raw)
In-Reply-To: <200703021935.58992.andyparkins@gmail.com>
On Mar 2, 2007, at 2:35 PM, Andy Parkins wrote:
>> .git/config:
>> [attribute "image"]
>> show = ...
>> merge = ...
>>
>> With the ability to have additional "path =" entries for *local*
>> overrides/additions. Storing the handler information in
>
> That's almost exactly it; but it makes the assumption that each
> attribute will have one unique handler. Separating them means that
> multiple attributes can use one handler (or set of handlers).
That's why I suggested keeping the handler section, but not tying
handlers to attributes in the attribute section. I think it follows
the principle of least surprise to be able to do as I demonstrated
above, but allow reuse as I described originally (handler option in
the attribute section). My major concern is how do you tell what
order handlers are run in for a given file if the handlers specify
the attributes rather than the other way around? And why make the
user do things like:
[handler "text"]
attribute=text
...
Instead of:
[attribute "text"]
...
(The handler section could be called "mangle", "blah", or "why-do-I-
have-to-name-this", and the point would be the same.) If you want to
run the same handlers/filters/whatever for multiple types, create a
handler section and reference it from all of those types or give all
the files a new attribute that explains why you'd want to handle them
identically and put the options on that attribute instead.
The attribute is the important thing here, not the handlers, so they
should be primary, not secondary. And that's my major point that I'm
trying to get around to I guess. I don't care about naming handler
sections, searching through the file to find their order, or anything
other than *what git is doing to my files*. The files (content,
actually) are king.
~~ Brian
next prev parent reply other threads:[~2007-03-02 20:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 12:06 [PATCH] Quick description of possible gitattributes system Andy Parkins
2007-03-01 16:06 ` Brian Gernhardt
2007-03-02 12:00 ` Andy Parkins
2007-03-02 18:05 ` Brian Gernhardt
2007-03-02 19:35 ` Andy Parkins
2007-03-02 20:35 ` Brian Gernhardt [this message]
2007-03-01 18:01 ` Robin Rosenberg
2007-03-02 0:09 ` Junio C Hamano
2007-03-02 4:46 ` Junio C Hamano
2007-03-02 8:58 ` Andy Parkins
2007-03-02 8:56 ` Andy Parkins
2007-03-02 13:56 ` Jakub Narebski
2007-03-02 16:58 ` Linus Torvalds
2007-03-02 19:37 ` Andy Parkins
2007-03-02 21:02 ` Linus Torvalds
2007-03-02 21:45 ` Johannes Schindelin
2007-03-02 22:21 ` Andy Parkins
2007-03-02 22:24 ` Andy Parkins
2007-03-03 13:11 ` Junio C Hamano
2007-03-03 20:27 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CAB85E5-A98E-4A25-9CC2-3E59106E655C@silverinsanity.com \
--to=benji@silverinsanity.com \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.