From: Brian Gernhardt <benji@silverinsanity.com>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Quick description of possible gitattributes system
Date: Fri, 2 Mar 2007 13:05:06 -0500 [thread overview]
Message-ID: <E246B7BC-9C82-4F4E-93F0-60B3F1CA54F1@silverinsanity.com> (raw)
In-Reply-To: <200703021200.35069.andyparkins@gmail.com>
On Mar 2, 2007, at 7:00 AM, Andy Parkins wrote:
> On Thursday 2007, March 01, Brian Gernhardt wrote:
>
>> [attribute "image/png"]
>> path = *.png
>> show = "open %path%"
>> [attribute "text/plain"]
>> path = *.c
>> checkout = eol_to_local
>
> The problem is that this flips the relationship. What you want to
> do is
> assign attributes to paths. This is assigning paths to attributes.
> What about this:
>
> doc/*.txt = text/plain AND documentation
>
> In your system that would make
I'm sorry, I was assuming that information on what to do with each
attribute would be in the config file while a majority of the
attribute information was in an in-tree file. I was actually assuming:
.gitattributes:
*.png: image/png
logo.png: logo
*.c: text/plain source
.git/config:
[attribute "image"]
show = ...
merge = ...
With the ability to have additional "path =" entries for *local*
overrides/additions. Storing the handler information in
the .gitattributes is one of the worst things you could do, IMHO. It
assumes that people will have a homogenous environment to develop in,
and that every developer want to use the same tools. In some cases,
this may be true (eol_lf on checking for everybody), but not in
others. On my Mac, I'd like to use "open" for random file types, and
might want to use VERY different graphical merge than Linux users.
And OS X is a fairly Unix-like environment. Let's not even ponder
those poor fools using MinGW. ;-)
>> Actually, shouldn't the files also be run through the infilter to
>> check for changes caused by that, too?
>
> I don't think so. The effect of the infilter will never be seen in
> the
> working tree, because it's applied on git-add. The previous
> content with the
> old attributes are already in the repository. However, it could be
> that we
> would have to force those files to be marked dirty in the index
> (this is
> already sounding bad), to force the application of the infilter on
> next
> checkin. Perhaps that's what you meant, and I'm being slow.
That's something like what I meant. And it sounds bad. Content
changes caused by attribute changes should likely be handled by the
user and made easy to detect instead of trying to handle it
automatically. So ignore my original statement on the matter.
~~ Brian
next prev parent reply other threads:[~2007-03-02 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 12:06 [PATCH] Quick description of possible gitattributes system Andy Parkins
2007-03-01 16:06 ` Brian Gernhardt
2007-03-02 12:00 ` Andy Parkins
2007-03-02 18:05 ` Brian Gernhardt [this message]
2007-03-02 19:35 ` Andy Parkins
2007-03-02 20:35 ` Brian Gernhardt
2007-03-01 18:01 ` Robin Rosenberg
2007-03-02 0:09 ` Junio C Hamano
2007-03-02 4:46 ` Junio C Hamano
2007-03-02 8:58 ` Andy Parkins
2007-03-02 8:56 ` Andy Parkins
2007-03-02 13:56 ` Jakub Narebski
2007-03-02 16:58 ` Linus Torvalds
2007-03-02 19:37 ` Andy Parkins
2007-03-02 21:02 ` Linus Torvalds
2007-03-02 21:45 ` Johannes Schindelin
2007-03-02 22:21 ` Andy Parkins
2007-03-02 22:24 ` Andy Parkins
2007-03-03 13:11 ` Junio C Hamano
2007-03-03 20:27 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E246B7BC-9C82-4F4E-93F0-60B3F1CA54F1@silverinsanity.com \
--to=benji@silverinsanity.com \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.