* [PATCHv2] x86/vmd: Initialize list item in irq disable
@ 2016-05-17 17:22 Keith Busch
2016-05-17 18:51 ` Jon Derrick
0 siblings, 1 reply; 4+ messages in thread
From: Keith Busch @ 2016-05-17 17:22 UTC (permalink / raw)
To: linux-pci, Bjorn Helgaas; +Cc: Jon Derrick, Keith Busch
Multiple calls to disable an IRQ would have caused the driver to
dereference a poisoned list item. This re-initializes the list to
allow multiple requests to disable the irq.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
v1 -> v2:
Used the patch with the correct macro
arch/x86/pci/vmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c
index b1662bf..3519a15 100644
--- a/arch/x86/pci/vmd.c
+++ b/arch/x86/pci/vmd.c
@@ -135,6 +135,7 @@ static void vmd_irq_disable(struct irq_data *data)
raw_spin_lock(&list_lock);
list_del_rcu(&vmdirq->node);
+ INIT_LIST_HEAD_RCU(&vmdirq->node);
raw_spin_unlock(&list_lock);
}
--
2.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv2] x86/vmd: Initialize list item in irq disable
2016-05-17 17:22 [PATCHv2] x86/vmd: Initialize list item in irq disable Keith Busch
@ 2016-05-17 18:51 ` Jon Derrick
2016-06-01 21:10 ` Derrick, Jonathan
0 siblings, 1 reply; 4+ messages in thread
From: Jon Derrick @ 2016-05-17 18:51 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-pci, Bjorn Helgaas
Acked-by Jon Derrick: <jonathan.derrick@intel.com>
On Tue, May 17, 2016 at 11:22:18AM -0600, Keith Busch wrote:
> Multiple calls to disable an IRQ would have caused the driver to
> dereference a poisoned list item. This re-initializes the list to
> allow multiple requests to disable the irq.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
> v1 -> v2:
> Used the patch with the correct macro
>
> arch/x86/pci/vmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c
> index b1662bf..3519a15 100644
> --- a/arch/x86/pci/vmd.c
> +++ b/arch/x86/pci/vmd.c
> @@ -135,6 +135,7 @@ static void vmd_irq_disable(struct irq_data *data)
>
> raw_spin_lock(&list_lock);
> list_del_rcu(&vmdirq->node);
> + INIT_LIST_HEAD_RCU(&vmdirq->node);
> raw_spin_unlock(&list_lock);
> }
>
> --
> 2.7.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCHv2] x86/vmd: Initialize list item in irq disable
2016-05-17 18:51 ` Jon Derrick
@ 2016-06-01 21:10 ` Derrick, Jonathan
2016-06-08 20:56 ` Jon Derrick
0 siblings, 1 reply; 4+ messages in thread
From: Derrick, Jonathan @ 2016-06-01 21:10 UTC (permalink / raw)
To: Derrick, Jonathan, Busch, Keith; +Cc: linux-pci, Bjorn Helgaas
Hi Bjorn,
Any plans to get this set in?
Thanks,
J
-----Original Message-----
From: linux-pci-owner@vger.kernel.org [mailto:linux-pci-owner@vger.kernel.org] On Behalf Of Jon Derrick
Sent: Tuesday, May 17, 2016 12:51 PM
To: Busch, Keith <keith.busch@intel.com>
Cc: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCHv2] x86/vmd: Initialize list item in irq disable
Acked-by Jon Derrick: <jonathan.derrick@intel.com>
On Tue, May 17, 2016 at 11:22:18AM -0600, Keith Busch wrote:
> Multiple calls to disable an IRQ would have caused the driver to
> dereference a poisoned list item. This re-initializes the list to
> allow multiple requests to disable the irq.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
> v1 -> v2:
> Used the patch with the correct macro
>
> arch/x86/pci/vmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c index
> b1662bf..3519a15 100644
> --- a/arch/x86/pci/vmd.c
> +++ b/arch/x86/pci/vmd.c
> @@ -135,6 +135,7 @@ static void vmd_irq_disable(struct irq_data *data)
>
> raw_spin_lock(&list_lock);
> list_del_rcu(&vmdirq->node);
> + INIT_LIST_HEAD_RCU(&vmdirq->node);
> raw_spin_unlock(&list_lock);
> }
>
> --
> 2.7.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] x86/vmd: Initialize list item in irq disable
2016-06-01 21:10 ` Derrick, Jonathan
@ 2016-06-08 20:56 ` Jon Derrick
0 siblings, 0 replies; 4+ messages in thread
From: Jon Derrick @ 2016-06-08 20:56 UTC (permalink / raw)
To: Busch, Keith; +Cc: linux-pci, Bjorn Helgaas
Hi Bjorn,
Let me know if there's anything else needing to be done to get this set in.
Thanks,
Jon
On Wed, Jun 01, 2016 at 03:10:30PM -0600, Derrick, Jonathan wrote:
> Hi Bjorn,
>
> Any plans to get this set in?
>
> Thanks,
> J
>
> -----Original Message-----
> From: linux-pci-owner@vger.kernel.org [mailto:linux-pci-owner@vger.kernel.org] On Behalf Of Jon Derrick
> Sent: Tuesday, May 17, 2016 12:51 PM
> To: Busch, Keith <keith.busch@intel.com>
> Cc: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>
> Subject: Re: [PATCHv2] x86/vmd: Initialize list item in irq disable
>
> Acked-by Jon Derrick: <jonathan.derrick@intel.com>
>
> On Tue, May 17, 2016 at 11:22:18AM -0600, Keith Busch wrote:
> > Multiple calls to disable an IRQ would have caused the driver to
> > dereference a poisoned list item. This re-initializes the list to
> > allow multiple requests to disable the irq.
> >
> > Signed-off-by: Keith Busch <keith.busch@intel.com>
> > ---
> > v1 -> v2:
> > Used the patch with the correct macro
> >
> > arch/x86/pci/vmd.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c index
> > b1662bf..3519a15 100644
> > --- a/arch/x86/pci/vmd.c
> > +++ b/arch/x86/pci/vmd.c
> > @@ -135,6 +135,7 @@ static void vmd_irq_disable(struct irq_data *data)
> >
> > raw_spin_lock(&list_lock);
> > list_del_rcu(&vmdirq->node);
> > + INIT_LIST_HEAD_RCU(&vmdirq->node);
> > raw_spin_unlock(&list_lock);
> > }
> >
> > --
> > 2.7.2
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-08 20:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17 17:22 [PATCHv2] x86/vmd: Initialize list item in irq disable Keith Busch
2016-05-17 18:51 ` Jon Derrick
2016-06-01 21:10 ` Derrick, Jonathan
2016-06-08 20:56 ` Jon Derrick
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.