* [for dylan][PATCH 1/3] linux-dtb.inc: Replace /boot/ with /${KERNEL_IMAGEDEST}/
@ 2013-08-20 16:51 Franklin S. Cooper Jr
2013-08-20 16:51 ` [for dylan][PATCH 2/3] linux-dtb: Use kernel build system to generate the dtb files Franklin S. Cooper Jr
2013-08-20 16:51 ` [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8 Franklin S. Cooper Jr
0 siblings, 2 replies; 6+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-20 16:51 UTC (permalink / raw)
To: openembedded-core
From: Mike Looijmans <mike.looijmans@topic.nl>
Devicetree files were installed hard-coded in /boot. When KERNEL_IMAGEDEST
is anything else but "boot", the postinstall script and the file locations
no longer match and the postinstall will fail.
Replace "boot" with "${KERNEL_IMAGEDEST}" to fix this problem, and to allow
the devicetree files to be installed in another location.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
meta/recipes-kernel/linux/linux-dtb.inc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
index 58b93a1..401d1e0 100644
--- a/meta/recipes-kernel/linux/linux-dtb.inc
+++ b/meta/recipes-kernel/linux/linux-dtb.inc
@@ -1,5 +1,5 @@
# Support for device tree generation
-FILES_kernel-devicetree = "/boot/devicetree*"
+FILES_kernel-devicetree = "/${KERNEL_IMAGEDEST}/devicetree*"
KERNEL_DEVICETREE_FLAGS ?= "-R 8 -p 0x3000"
python __anonymous () {
@@ -22,7 +22,7 @@ do_install_append() {
DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o ${DTS_BASE_NAME} ${DTS_FILE}
- install -m 0644 ${DTS_BASE_NAME} ${D}/boot/devicetree-${DTB_SYMLINK_NAME}.dtb
+ install -m 0644 ${DTS_BASE_NAME} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
done
fi
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [for dylan][PATCH 2/3] linux-dtb: Use kernel build system to generate the dtb files
2013-08-20 16:51 [for dylan][PATCH 1/3] linux-dtb.inc: Replace /boot/ with /${KERNEL_IMAGEDEST}/ Franklin S. Cooper Jr
@ 2013-08-20 16:51 ` Franklin S. Cooper Jr
2013-08-20 16:51 ` [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8 Franklin S. Cooper Jr
1 sibling, 0 replies; 6+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-20 16:51 UTC (permalink / raw)
To: openembedded-core; +Cc: Otavio Salvador
From: Otavio Salvador <otavio@ossystems.com.br>
As the Linux kernel, unconditionally, builds the dtc application and
it is the compatible version with the DeviceTree files shipped within
the kernel it is better to use it and the kernel build system to
generate the dtb files.
Some DeviceTree files rely on CPP and kernel headers to be able to
generate the dtb binary contents and it is harder to replicate it
outside of Linux kernel build system so we /use/ it.
To comply with these assumptions we need to use the dtb file when
calling 'make' instead of pointing to the DeviceTree source file; the
code has been made backward compatible but it is advised to move to
the new definition to avoid warnings as:
,----[ Original definition ]
| KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx6q-sabresd.dts"
`----
Becomes:
,----[ New definition ]
| KERNEL_DEVICETREE = "imx6q-sabresd.dtb"
`----
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
meta/recipes-kernel/linux/linux-dtb.inc | 57 ++++++++++++++-----------------
1 files changed, 26 insertions(+), 31 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
index 401d1e0..7c8058f 100644
--- a/meta/recipes-kernel/linux/linux-dtb.inc
+++ b/meta/recipes-kernel/linux/linux-dtb.inc
@@ -3,42 +3,37 @@ FILES_kernel-devicetree = "/${KERNEL_IMAGEDEST}/devicetree*"
KERNEL_DEVICETREE_FLAGS ?= "-R 8 -p 0x3000"
python __anonymous () {
- devicetree = d.getVar("KERNEL_DEVICETREE", True) or ''
- if devicetree:
- depends = d.getVar("DEPENDS", True)
- d.setVar("DEPENDS", "%s dtc-native" % depends)
- packages = d.getVar("PACKAGES", True)
- d.setVar("PACKAGES", "%s kernel-devicetree" % packages)
+ d.appendVar("PACKAGES", " kernel-devicetree")
}
do_install_append() {
if test -n "${KERNEL_DEVICETREE}"; then
- for DTS_FILE in ${KERNEL_DEVICETREE}; do
- if [ ! -f ${DTS_FILE} ]; then
- echo "Warning: ${DTS_FILE} is not available!"
- continue
+ for DTB in ${KERNEL_DEVICETREE}; do
+ if echo ${DTB} | grep -q '/dts/'; then
+ bbwarn "${DTB} contains the full path to the the dts file, but only the dtb name should be used."
+ DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'`
fi
- DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
- DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
- DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
- dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o ${DTS_BASE_NAME} ${DTS_FILE}
- install -m 0644 ${DTS_BASE_NAME} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
+ DTB_BASE_NAME=`basename ${DTB} .dtb`
+ DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ oe_runmake ${DTB}
+ install -m 0644 ${B}/arch/${ARCH}/boot/${DTB} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
done
fi
}
do_deploy_append() {
if test -n "${KERNEL_DEVICETREE}"; then
- for DTS_FILE in ${KERNEL_DEVICETREE}; do
- if [ ! -f ${DTS_FILE} ]; then
- echo "Warning: ${DTS_FILE} is not available!"
- continue
+ for DTB in ${KERNEL_DEVICETREE}; do
+ if echo ${DTB} | grep -q '/dts/'; then
+ bbwarn "${DTB} contains the full path to the the dts file, but only the dtb name should be used."
+ DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'`
fi
- DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
- DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
- DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
+ DTB_BASE_NAME=`basename ${DTB} .dtb`
+ DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
install -d ${DEPLOYDIR}
- install -m 0644 ${B}/${DTS_BASE_NAME} ${DEPLOYDIR}/${DTB_NAME}.dtb
+ install -m 0644 ${B}/arch/${ARCH}/boot/${DTB} ${DEPLOYDIR}/${DTB_NAME}.dtb
cd ${DEPLOYDIR}
ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
cd -
@@ -48,20 +43,20 @@ do_deploy_append() {
pkg_postinst_kernel-devicetree () {
cd /${KERNEL_IMAGEDEST}
- for DTS_FILE in ${KERNEL_DEVICETREE}
+ for DTB_FILE in ${KERNEL_DEVICETREE}
do
- DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
- DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
- update-alternatives --install /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
+ DTB_BASE_NAME=`basename ${DTB_FILE} | awk -F "." '{print $1}'`
+ DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ update-alternatives --install /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.dtb ${DTB_BASE_NAME}.dtb devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
done
}
pkg_postrm_kernel-devicetree () {
cd /${KERNEL_IMAGEDEST}
- for DTS_FILE in ${KERNEL_DEVICETREE}
+ for DTB_FILE in ${KERNEL_DEVICETREE}
do
- DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
- DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
- update-alternatives --remove ${DTS_BASE_NAME}.dtb devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
+ DTB_BASE_NAME=`basename ${DTB_FILE} | awk -F "." '{print $1}'`
+ DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ update-alternatives --remove ${DTB_BASE_NAME}.dtb devicetree-${DTB_SYMLINK_NAME}.dtb ${KERNEL_PRIORITY} || true
done
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8
2013-08-20 16:51 [for dylan][PATCH 1/3] linux-dtb.inc: Replace /boot/ with /${KERNEL_IMAGEDEST}/ Franklin S. Cooper Jr
2013-08-20 16:51 ` [for dylan][PATCH 2/3] linux-dtb: Use kernel build system to generate the dtb files Franklin S. Cooper Jr
@ 2013-08-20 16:51 ` Franklin S. Cooper Jr
2013-08-20 18:17 ` Otavio Salvador
1 sibling, 1 reply; 6+ messages in thread
From: Franklin S. Cooper Jr @ 2013-08-20 16:51 UTC (permalink / raw)
To: openembedded-core; +Cc: Otavio Salvador
From: Otavio Salvador <otavio@ossystems.com.br>
The 3.8 kernel has change the default directory where the dtb file is
stored. The change has been done at:
,----[ Quote of 3.8 kernel change ]
| commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
| Author: Grant Likely <grant.likely@secretlab.ca>
| Date: Tue Nov 27 16:29:11 2012 -0700
|
| ARM: dt: change .dtb build rules to build in dts directory
|
| The current rules have the .dtb files build in a different directory
| from the .dts files. The only reason for this is that it was what
| PowerPC has done historically. This patch changes ARM to use the generic
| dtb rule which builds .dtb files in the same directory as the source .dts.
|
| Cc: Russell King <linux@arm.linux.org.uk>
| Cc: Arnd Bergmann <arnd@arndb.de>
| Acked-by: Olof Johansson <olof@lixom.net>
| Cc: linux-arm-kernel@lists.infradead.org
| Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| [swarren: added rm command for old stale .dtb files]
| Signed-off-by: Stephen Warren <swarren@nvidia.com>
| Signed-off-by: Rob Herring <rob.herring@calxeda.com>
`----
This change adds support for both places to backward and forward
compatibility.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
meta/recipes-kernel/linux/linux-dtb.inc | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
index 7c8058f..258a5fc 100644
--- a/meta/recipes-kernel/linux/linux-dtb.inc
+++ b/meta/recipes-kernel/linux/linux-dtb.inc
@@ -16,8 +16,12 @@ do_install_append() {
DTB_BASE_NAME=`basename ${DTB} .dtb`
DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ DTB_PATH="${B}/arch/${ARCH}/boot/dts/${DTB}"
oe_runmake ${DTB}
- install -m 0644 ${B}/arch/${ARCH}/boot/${DTB} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
+ if [ ! -e "${DTB_PATH}" ]; then
+ DTB_PATH="${B}/arch/${ARCH}/boot/${DTB}"
+ fi
+ install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/devicetree-${DTB_SYMLINK_NAME}.dtb
done
fi
}
@@ -32,8 +36,12 @@ do_deploy_append() {
DTB_BASE_NAME=`basename ${DTB} .dtb`
DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTB_BASE_NAME}/g"`
+ DTB_PATH="${B}/arch/${ARCH}/boot/dts/${DTB}"
+ if [ ! -e "${DTB_PATH}" ]; then
+ DTB_PATH="${B}/arch/${ARCH}/boot/${DTB}"
+ fi
install -d ${DEPLOYDIR}
- install -m 0644 ${B}/arch/${ARCH}/boot/${DTB} ${DEPLOYDIR}/${DTB_NAME}.dtb
+ install -m 0644 ${DTB_PATH} ${DEPLOYDIR}/${DTB_NAME}.dtb
cd ${DEPLOYDIR}
ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
cd -
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8
2013-08-20 16:51 ` [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8 Franklin S. Cooper Jr
@ 2013-08-20 18:17 ` Otavio Salvador
2013-08-20 18:24 ` Paul Eggleton
0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2013-08-20 18:17 UTC (permalink / raw)
To: Franklin S. Cooper Jr, Eggleton, Paul
Cc: Patches and discussions about the oe-core layer
On Tue, Aug 20, 2013 at 1:51 PM, Franklin S. Cooper Jr <fcooper@ti.com> wrote:
> From: Otavio Salvador <otavio@ossystems.com.br>
>
> The 3.8 kernel has change the default directory where the dtb file is
> stored. The change has been done at:
>
> ,----[ Quote of 3.8 kernel change ]
> | commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
> | Author: Grant Likely <grant.likely@secretlab.ca>
> | Date: Tue Nov 27 16:29:11 2012 -0700
> |
> | ARM: dt: change .dtb build rules to build in dts directory
> |
> | The current rules have the .dtb files build in a different directory
> | from the .dts files. The only reason for this is that it was what
> | PowerPC has done historically. This patch changes ARM to use the generic
> | dtb rule which builds .dtb files in the same directory as the source .dts.
> |
> | Cc: Russell King <linux@arm.linux.org.uk>
> | Cc: Arnd Bergmann <arnd@arndb.de>
> | Acked-by: Olof Johansson <olof@lixom.net>
> | Cc: linux-arm-kernel@lists.infradead.org
> | Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> | [swarren: added rm command for old stale .dtb files]
> | Signed-off-by: Stephen Warren <swarren@nvidia.com>
> | Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> `----
>
> This change adds support for both places to backward and forward
> compatibility.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Franklin, I agree this is the way to go but I think it is a bit risky
to change it in dylan.
I think it could be included in meta-ti or other layers (in case it is
need for dylan) but it has breakage risk as noticed today in some
behaviour change as found in meta-xilinx.
Paul, please be conservative about this and my previous linux-dtb
patch. In case it is going to be applied in dylan we need to let it
sleep some more time in master to find any other side effect due the
behaviour change.
Regards,
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8
2013-08-20 18:17 ` Otavio Salvador
@ 2013-08-20 18:24 ` Paul Eggleton
2013-08-20 18:35 ` Cooper Jr., Franklin
0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2013-08-20 18:24 UTC (permalink / raw)
To: Otavio Salvador
Cc: Franklin S. Cooper Jr, Patches and discussions about the oe-core layer
Hi Otavio,
On Tuesday 20 August 2013 15:17:16 Otavio Salvador wrote:
> On Tue, Aug 20, 2013 at 1:51 PM, Franklin S. Cooper Jr <fcooper@ti.com>
wrote:
> > From: Otavio Salvador <otavio@ossystems.com.br>
> >
> > The 3.8 kernel has change the default directory where the dtb file is
> > stored. The change has been done at:
> >
> > ,----[ Quote of 3.8 kernel change ]
> >
> > | commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
> > | Author: Grant Likely <grant.likely@secretlab.ca>
> > | Date: Tue Nov 27 16:29:11 2012 -0700
> > |
> > | ARM: dt: change .dtb build rules to build in dts directory
> > |
> > | The current rules have the .dtb files build in a different directory
> > | from the .dts files. The only reason for this is that it was what
> > | PowerPC has done historically. This patch changes ARM to use the
> > | generic
> > | dtb rule which builds .dtb files in the same directory as the source
> > | .dts.
> > |
> > | Cc: Russell King <linux@arm.linux.org.uk>
> > | Cc: Arnd Bergmann <arnd@arndb.de>
> > | Acked-by: Olof Johansson <olof@lixom.net>
> > | Cc: linux-arm-kernel@lists.infradead.org
> > | Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > | [swarren: added rm command for old stale .dtb files]
> > | Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > | Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> >
> > `----
> >
> > This change adds support for both places to backward and forward
> > compatibility.
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Franklin, I agree this is the way to go but I think it is a bit risky
> to change it in dylan.
>
> I think it could be included in meta-ti or other layers (in case it is
> need for dylan) but it has breakage risk as noticed today in some
> behaviour change as found in meta-xilinx.
>
> Paul, please be conservative about this and my previous linux-dtb
> patch. In case it is going to be applied in dylan we need to let it
> sleep some more time in master to find any other side effect due the
> behaviour change.
Agreed, I'd very much prefer to hold on this until it has had time to soak in
master.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8
2013-08-20 18:24 ` Paul Eggleton
@ 2013-08-20 18:35 ` Cooper Jr., Franklin
0 siblings, 0 replies; 6+ messages in thread
From: Cooper Jr., Franklin @ 2013-08-20 18:35 UTC (permalink / raw)
To: Paul Eggleton, Otavio Salvador
Cc: Patches and discussions about the oe-core layer
> -----Original Message-----
> From: Paul Eggleton [mailto:paul.eggleton@linux.intel.com]
> Sent: Tuesday, August 20, 2013 1:24 PM
> To: Otavio Salvador
> Cc: Cooper Jr., Franklin; Patches and discussions about the oe-core layer
> Subject: Re: [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels
> newer than 3.8
>
> Hi Otavio,
>
> On Tuesday 20 August 2013 15:17:16 Otavio Salvador wrote:
> > On Tue, Aug 20, 2013 at 1:51 PM, Franklin S. Cooper Jr
> > <fcooper@ti.com>
> wrote:
> > > From: Otavio Salvador <otavio@ossystems.com.br>
> > >
> > > The 3.8 kernel has change the default directory where the dtb file
> > > is stored. The change has been done at:
> > >
> > > ,----[ Quote of 3.8 kernel change ]
> > >
> > > | commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
> > > | Author: Grant Likely <grant.likely@secretlab.ca>
> > > | Date: Tue Nov 27 16:29:11 2012 -0700
> > > |
> > > | ARM: dt: change .dtb build rules to build in dts directory
> > > |
> > > | The current rules have the .dtb files build in a different directory
> > > | from the .dts files. The only reason for this is that it was what
> > > | PowerPC has done historically. This patch changes ARM to use the
> > > | generic
> > > | dtb rule which builds .dtb files in the same directory as the source
> > > | .dts.
> > > |
> > > | Cc: Russell King <linux@arm.linux.org.uk>
> > > | Cc: Arnd Bergmann <arnd@arndb.de>
> > > | Acked-by: Olof Johansson <olof@lixom.net>
> > > | Cc: linux-arm-kernel@lists.infradead.org
> > > | Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > > | [swarren: added rm command for old stale .dtb files]
> > > | Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > > | Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> > >
> > > `----
> > >
> > > This change adds support for both places to backward and forward
> > > compatibility.
> > >
> > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> >
> > Franklin, I agree this is the way to go but I think it is a bit risky
> > to change it in dylan.
> >
> > I think it could be included in meta-ti or other layers (in case it is
> > need for dylan) but it has breakage risk as noticed today in some
> > behaviour change as found in meta-xilinx.
> >
> > Paul, please be conservative about this and my previous linux-dtb
> > patch. In case it is going to be applied in dylan we need to let it
> > sleep some more time in master to find any other side effect due the
> > behaviour change.
>
> Agreed, I'd very much prefer to hold on this until it has had time to soak in
> master.
[Franklin]
No problem. I will put this on the back burner for some time.
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-20 18:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-20 16:51 [for dylan][PATCH 1/3] linux-dtb.inc: Replace /boot/ with /${KERNEL_IMAGEDEST}/ Franklin S. Cooper Jr
2013-08-20 16:51 ` [for dylan][PATCH 2/3] linux-dtb: Use kernel build system to generate the dtb files Franklin S. Cooper Jr
2013-08-20 16:51 ` [for dylan][PATCH 3/3] linux-dtb.inc: Fix dtb generation for kernels newer than 3.8 Franklin S. Cooper Jr
2013-08-20 18:17 ` Otavio Salvador
2013-08-20 18:24 ` Paul Eggleton
2013-08-20 18:35 ` Cooper Jr., Franklin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.