All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
@ 2013-08-23 21:03 Denys Dmytriyenko
  2013-08-23 21:03 ` [PATCHv2 4/4] u-boot-ti-staging: " Denys Dmytriyenko
  2013-08-23 21:08 ` [PATCHv2 3/4] linux-ti-staging: " Cooper Jr., Franklin
  0 siblings, 2 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2013-08-23 21:03 UTC (permalink / raw)
  To: meta-arago

From: Denys Dmytriyenko <denys@ti.com>

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
v2 - removed the comment about upstreaming LOCALVERSION, may not happen

 .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend

diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
new file mode 100644
index 0000000..f99482c
--- /dev/null
+++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
@@ -0,0 +1,17 @@
+MACHINE_KERNEL_PR_append = "-arago0"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
+
+require copy-defconfig.inc
+
+SRCREV = "${AUTOREV}"
+
+KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV', True).partition('+')[2][0:7]}"
+
+kernel_do_configure_prepend() {
+    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
+    then
+        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
+        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
+    fi
+}
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCHv2 4/4] u-boot-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-23 21:03 [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV Denys Dmytriyenko
@ 2013-08-23 21:03 ` Denys Dmytriyenko
  2013-08-23 21:08 ` [PATCHv2 3/4] linux-ti-staging: " Cooper Jr., Franklin
  1 sibling, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2013-08-23 21:03 UTC (permalink / raw)
  To: meta-arago

From: Denys Dmytriyenko <denys@ti.com>

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
v2 - removed the comment about upstreaming LOCALVERSION, may not happen

 .../recipes-bsp/u-boot/u-boot-ti-staging_git.bbappend       | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 meta-arago-distro/recipes-bsp/u-boot/u-boot-ti-staging_git.bbappend

diff --git a/meta-arago-distro/recipes-bsp/u-boot/u-boot-ti-staging_git.bbappend b/meta-arago-distro/recipes-bsp/u-boot/u-boot-ti-staging_git.bbappend
new file mode 100644
index 0000000..8174bc7
--- /dev/null
+++ b/meta-arago-distro/recipes-bsp/u-boot/u-boot-ti-staging_git.bbappend
@@ -0,0 +1,13 @@
+PR_append = "-arago0"
+
+SRCREV = "${AUTOREV}"
+
+UBOOT_LOCALVERSION = "-g${@d.getVar('SRCPV', True).partition('+')[2][0:7]}"
+
+do_compile_prepend() {
+    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
+    then
+        echo ${UBOOT_LOCALVERSION} > ${B}/.scmversion
+        echo ${UBOOT_LOCALVERSION} > ${S}/.scmversion
+    fi
+}
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-23 21:03 [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV Denys Dmytriyenko
  2013-08-23 21:03 ` [PATCHv2 4/4] u-boot-ti-staging: " Denys Dmytriyenko
@ 2013-08-23 21:08 ` Cooper Jr., Franklin
  2013-08-23 21:15   ` Denys Dmytriyenko
  1 sibling, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2013-08-23 21:08 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago



> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> Sent: Friday, August 23, 2013 4:04 PM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> and AUTOREV
> 
> From: Denys Dmytriyenko <denys@ti.com>
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2 - removed the comment about upstreaming LOCALVERSION, may not
> happen
> 
>  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17
> +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-
> staging_git.bbappend
> 
> diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
> b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
> new file mode 100644
> index 0000000..f99482c
> --- /dev/null
> +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
> @@ -0,0 +1,17 @@
> +MACHINE_KERNEL_PR_append = "-arago0"
> +
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> +
> +require copy-defconfig.inc
[Franklin] Are we really planning on have different defconfigs for each  machine? I thought with DT all machines will share the same defconfig.
> +
> +SRCREV = "${AUTOREV}"
> +
> +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> True).partition('+')[2][0:7]}"
> +
> +kernel_do_configure_prepend() {
> +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> +    then
> +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> +    fi
> +}
> --
> 1.8.3.2
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-23 21:08 ` [PATCHv2 3/4] linux-ti-staging: " Cooper Jr., Franklin
@ 2013-08-23 21:15   ` Denys Dmytriyenko
  2013-08-23 21:54     ` Cooper Jr., Franklin
  0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2013-08-23 21:15 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > Sent: Friday, August 23, 2013 4:04 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> > and AUTOREV
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> > v2 - removed the comment about upstreaming LOCALVERSION, may not
> > happen
> > 
> >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17
> > +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >  create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-
> > staging_git.bbappend
> > 
> > diff --git a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
> > b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
> > new file mode 100644
> > index 0000000..f99482c
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappend
> > @@ -0,0 +1,17 @@
> > +MACHINE_KERNEL_PR_append = "-arago0"
> > +
> > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> > +
> > +require copy-defconfig.inc

> [Franklin] Are we really planning on have different defconfigs for each 
> machine? I thought with DT all machines will share the same defconfig.

Yes, linux-ti-staging uses a blank defconfig that points to 
omap2plus_defconfig.

But copy-defconfig just saves the current config for SDK use - they will be 
the same for machines using this recipe. But still, there are currently only 2 
OMAP machines supported by this kernel and will be 2 Sitara machines with this 
patchset. If/when we switch remaining SDK machines to use the latest kernel, 
we can revisit this matter, I guess.


> > +SRCREV = "${AUTOREV}"
> > +
> > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > True).partition('+')[2][0:7]}"
> > +
> > +kernel_do_configure_prepend() {
> > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> > +    then
> > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> > +    fi
> > +}
> > --
> > 1.8.3.2
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-23 21:15   ` Denys Dmytriyenko
@ 2013-08-23 21:54     ` Cooper Jr., Franklin
  2013-08-26 13:11       ` Maupin, Chase
  2013-08-26 14:48       ` Denys Dmytriyenko
  0 siblings, 2 replies; 10+ messages in thread
From: Cooper Jr., Franklin @ 2013-08-23 21:54 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago



> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Friday, August 23, 2013 4:15 PM
> To: Cooper Jr., Franklin
> Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> and AUTOREV
> 
> On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin wrote:
> >
> >
> > > -----Original Message-----
> > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > Sent: Friday, August 23, 2013 4:04 PM
> > > To: meta-arago@arago-project.org
> > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> > > LOCALVERSION and AUTOREV
> > >
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > ---
> > > v2 - removed the comment about upstreaming LOCALVERSION, may not
> > > happen
> > >
> > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17
> > > +++++++++++++++++
> > >  1 file changed, 17 insertions(+)
> > >  create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-
> > > staging_git.bbappend
> > >
> > > diff --git
> > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappe
> > > nd
> > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappe
> > > nd
> > > new file mode 100644
> > > index 0000000..f99482c
> > > --- /dev/null
> > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bb
> > > +++ append
> > > @@ -0,0 +1,17 @@
> > > +MACHINE_KERNEL_PR_append = "-arago0"
> > > +
> > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> > > +
> > > +require copy-defconfig.inc
> 
> > [Franklin] Are we really planning on have different defconfigs for
> > each machine? I thought with DT all machines will share the same defconfig.
> 
> Yes, linux-ti-staging uses a blank defconfig that points to omap2plus_defconfig.
> 
> But copy-defconfig just saves the current config for SDK use - they will be the
> same for machines using this recipe. But still, there are currently only 2 OMAP
> machines supported by this kernel and will be 2 Sitara machines with this
> patchset. If/when we switch remaining SDK machines to use the latest kernel,
> we can revisit this matter, I guess.
[Franklin] 
I guess my point was that copy-defconfig.inc renames the .config to tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME  to "omap2plus_defconfig" since we should stick with that defconfig name for all machines?
> 
> 
> > > +SRCREV = "${AUTOREV}"
> > > +
> > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > > True).partition('+')[2][0:7]}"
> > > +
> > > +kernel_do_configure_prepend() {
> > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> > > +    then
> > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> > > +    fi
> > > +}
> > > --
> > > 1.8.3.2
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-23 21:54     ` Cooper Jr., Franklin
@ 2013-08-26 13:11       ` Maupin, Chase
  2013-08-26 17:58         ` Cooper Jr., Franklin
  2013-08-26 14:48       ` Denys Dmytriyenko
  1 sibling, 1 reply; 10+ messages in thread
From: Maupin, Chase @ 2013-08-26 13:11 UTC (permalink / raw)
  To: Cooper Jr., Franklin, Dmytriyenko, Denys; +Cc: meta-arago

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Friday, August 23, 2013 4:55 PM
>To: Dmytriyenko, Denys
>Cc: meta-arago@arago-project.org
>Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
>LOCALVERSION and AUTOREV
>
>
>
>> -----Original Message-----
>> From: Dmytriyenko, Denys
>> Sent: Friday, August 23, 2013 4:15 PM
>> To: Cooper Jr., Franklin
>> Cc: Denys Dmytriyenko; meta-arago@arago-project.org
>> Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
>LOCALVERSION
>> and AUTOREV
>>
>> On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin
>wrote:
>> >
>> >
>> > > -----Original Message-----
>> > > From: meta-arago-bounces@arago-project.org [mailto:meta-
>arago-
>> > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
>> > > Sent: Friday, August 23, 2013 4:04 PM
>> > > To: meta-arago@arago-project.org
>> > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
>> > > LOCALVERSION and AUTOREV
>> > >
>> > > From: Denys Dmytriyenko <denys@ti.com>
>> > >
>> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> > > ---
>> > > v2 - removed the comment about upstreaming LOCALVERSION, may
>not
>> > > happen
>> > >
>> > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  |
>17
>> > > +++++++++++++++++
>> > >  1 file changed, 17 insertions(+)
>> > >  create mode 100644 meta-arago-distro/recipes-
>kernel/linux/linux-ti-
>> > > staging_git.bbappend
>> > >
>> > > diff --git
>> > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-
>staging_git.bbappe
>> > > nd
>> > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-
>staging_git.bbappe
>> > > nd
>> > > new file mode 100644
>> > > index 0000000..f99482c
>> > > --- /dev/null
>> > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-
>staging_git.bb
>> > > +++ append
>> > > @@ -0,0 +1,17 @@
>> > > +MACHINE_KERNEL_PR_append = "-arago0"
>> > > +
>> > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
>> > > +
>> > > +require copy-defconfig.inc
>>
>> > [Franklin] Are we really planning on have different defconfigs
>for
>> > each machine? I thought with DT all machines will share the
>same defconfig.
>>
>> Yes, linux-ti-staging uses a blank defconfig that points to
>omap2plus_defconfig.
>>
>> But copy-defconfig just saves the current config for SDK use -
>they will be the
>> same for machines using this recipe. But still, there are
>currently only 2 OMAP
>> machines supported by this kernel and will be 2 Sitara machines
>with this
>> patchset. If/when we switch remaining SDK machines to use the
>latest kernel,
>> we can revisit this matter, I guess.
>[Franklin]
>I guess my point was that copy-defconfig.inc renames the .config
>to tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME  to
>"omap2plus_defconfig" since we should stick with that defconfig
>name for all machines?

Franklin this would have some of the following impacts:

1. You would need to update all your documentation
2. If you ever do decide you need a tweak for individual machines in the defconfig such as having something turned on for other machines that you do not want turned on for a particular machine due to size or boot time impacts, you will end up needing this functionality back.
3. You will probably get some questions about why AMxxx is using an "omap2plus" configuration.
4. I'm not sure how much of the kernel config magic is still used in oe-core, where they would modify the config with certain options (and this is probably bypassed right now) but again, those kinds of changes would be lost.

Currently you can just say find the config matching a simple pattern and people know exactly what you built with.

>>
>>
>> > > +SRCREV = "${AUTOREV}"
>> > > +
>> > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
>> > > True).partition('+')[2][0:7]}"
>> > > +
>> > > +kernel_do_configure_prepend() {
>> > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
>> > > +    then
>> > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
>> > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
>> > > +    fi
>> > > +}
>> > > --
>> > > 1.8.3.2
>> > >
>> > > _______________________________________________
>> > > meta-arago mailing list
>> > > meta-arago@arago-project.org
>> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> > _______________________________________________
>> > meta-arago mailing list
>> > meta-arago@arago-project.org
>> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-23 21:54     ` Cooper Jr., Franklin
  2013-08-26 13:11       ` Maupin, Chase
@ 2013-08-26 14:48       ` Denys Dmytriyenko
  2013-08-26 18:04         ` Cooper Jr., Franklin
  1 sibling, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2013-08-26 14:48 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On Fri, Aug 23, 2013 at 09:54:44PM +0000, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Friday, August 23, 2013 4:15 PM
> > To: Cooper Jr., Franklin
> > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> > and AUTOREV
> > 
> > On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > > Sent: Friday, August 23, 2013 4:04 PM
> > > > To: meta-arago@arago-project.org
> > > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> > > > LOCALVERSION and AUTOREV
> > > >
> > > > From: Denys Dmytriyenko <denys@ti.com>
> > > >
> > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > ---
> > > > v2 - removed the comment about upstreaming LOCALVERSION, may not
> > > > happen
> > > >
> > > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17
> > > > +++++++++++++++++
> > > >  1 file changed, 17 insertions(+)
> > > >  create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-
> > > > staging_git.bbappend
> > > >
> > > > diff --git
> > > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappe
> > > > nd
> > > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappe
> > > > nd
> > > > new file mode 100644
> > > > index 0000000..f99482c
> > > > --- /dev/null
> > > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bb
> > > > +++ append
> > > > @@ -0,0 +1,17 @@
> > > > +MACHINE_KERNEL_PR_append = "-arago0"
> > > > +
> > > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> > > > +
> > > > +require copy-defconfig.inc
> > 
> > > [Franklin] Are we really planning on have different defconfigs for
> > > each machine? I thought with DT all machines will share the same defconfig.
> > 
> > Yes, linux-ti-staging uses a blank defconfig that points to omap2plus_defconfig.
> > 
> > But copy-defconfig just saves the current config for SDK use - they will be the
> > same for machines using this recipe. But still, there are currently only 2 OMAP
> > machines supported by this kernel and will be 2 Sitara machines with this
> > patchset. If/when we switch remaining SDK machines to use the latest kernel,
> > we can revisit this matter, I guess.
> [Franklin] 
> I guess my point was that copy-defconfig.inc renames the .config to 
> tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME to "omap2plus_defconfig" 
> since we should stick with that defconfig name for all machines?

And what I was trying to say before, is that "all machines" is currently only 2 
out of several and even then, omap2plus_defconfig in the kernel may not match 
exactly the one produced by the SDK - there may be some mangling involved to 
adjust some config options to sane defaults (although we no longer include 
linux.inc with that code), plus we run "make oldconfig" on it, which checks 
dependecies between config options and may change some os them. In other 
words: omap2plus_defconfig != .config which we package in the SDK. It is like 
the difference between pristine sources and sources that were patched and 
configured...

-- 
Denys


> > > > +SRCREV = "${AUTOREV}"
> > > > +
> > > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > > > True).partition('+')[2][0:7]}"
> > > > +
> > > > +kernel_do_configure_prepend() {
> > > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> > > > +    then
> > > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> > > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> > > > +    fi
> > > > +}
> > > > --
> > > > 1.8.3.2
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-26 13:11       ` Maupin, Chase
@ 2013-08-26 17:58         ` Cooper Jr., Franklin
  0 siblings, 0 replies; 10+ messages in thread
From: Cooper Jr., Franklin @ 2013-08-26 17:58 UTC (permalink / raw)
  To: Maupin, Chase, Dmytriyenko, Denys; +Cc: meta-arago



> -----Original Message-----
> From: Maupin, Chase
> Sent: Monday, August 26, 2013 8:11 AM
> To: Cooper Jr., Franklin; Dmytriyenko, Denys
> Cc: meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> and AUTOREV
> 
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> >Sent: Friday, August 23, 2013 4:55 PM
> >To: Dmytriyenko, Denys
> >Cc: meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> >LOCALVERSION and AUTOREV
> >
> >
> >
> >> -----Original Message-----
> >> From: Dmytriyenko, Denys
> >> Sent: Friday, August 23, 2013 4:15 PM
> >> To: Cooper Jr., Franklin
> >> Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> >> Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> >LOCALVERSION
> >> and AUTOREV
> >>
> >> On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin
> >wrote:
> >> >
> >> >
> >> > > -----Original Message-----
> >> > > From: meta-arago-bounces@arago-project.org [mailto:meta-
> >arago-
> >> > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> >> > > Sent: Friday, August 23, 2013 4:04 PM
> >> > > To: meta-arago@arago-project.org
> >> > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> >> > > LOCALVERSION and AUTOREV
> >> > >
> >> > > From: Denys Dmytriyenko <denys@ti.com>
> >> > >
> >> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >> > > ---
> >> > > v2 - removed the comment about upstreaming LOCALVERSION, may
> >not
> >> > > happen
> >> > >
> >> > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  |
> >17
> >> > > +++++++++++++++++
> >> > >  1 file changed, 17 insertions(+)  create mode 100644
> >> > > meta-arago-distro/recipes-
> >kernel/linux/linux-ti-
> >> > > staging_git.bbappend
> >> > >
> >> > > diff --git
> >> > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-
> >staging_git.bbappe
> >> > > nd
> >> > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-
> >staging_git.bbappe
> >> > > nd
> >> > > new file mode 100644
> >> > > index 0000000..f99482c
> >> > > --- /dev/null
> >> > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-
> >staging_git.bb
> >> > > +++ append
> >> > > @@ -0,0 +1,17 @@
> >> > > +MACHINE_KERNEL_PR_append = "-arago0"
> >> > > +
> >> > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> >> > > +
> >> > > +require copy-defconfig.inc
> >>
> >> > [Franklin] Are we really planning on have different defconfigs
> >for
> >> > each machine? I thought with DT all machines will share the
> >same defconfig.
> >>
> >> Yes, linux-ti-staging uses a blank defconfig that points to
> >omap2plus_defconfig.
> >>
> >> But copy-defconfig just saves the current config for SDK use -
> >they will be the
> >> same for machines using this recipe. But still, there are
> >currently only 2 OMAP
> >> machines supported by this kernel and will be 2 Sitara machines
> >with this
> >> patchset. If/when we switch remaining SDK machines to use the
> >latest kernel,
> >> we can revisit this matter, I guess.
> >[Franklin]
> >I guess my point was that copy-defconfig.inc renames the .config to
> >tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME  to
> >"omap2plus_defconfig" since we should stick with that defconfig name
> >for all machines?
> 
> Franklin this would have some of the following impacts:
> 
> 1. You would need to update all your documentation 2. If you ever do decide
> you need a tweak for individual machines in the defconfig such as having
> something turned on for other machines that you do not want turned on for a
> particular machine due to size or boot time impacts, you will end up needing this
> functionality back.
> 3. You will probably get some questions about why AMxxx is using an
> "omap2plus" configuration.
> 4. I'm not sure how much of the kernel config magic is still used in oe-core,
> where they would modify the config with certain options (and this is probably
> bypassed right now) but again, those kinds of changes would be lost.
> 
> Currently you can just say find the config matching a simple pattern and people
> know exactly what you built with.
[Franklin] 
Ok. I wasn't sure if we were going to put in the effort to unify defconfigs and deal with the tradeoffs. But if that's not the case then I have no issue.
> 
> >>
> >>
> >> > > +SRCREV = "${AUTOREV}"
> >> > > +
> >> > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> >> > > True).partition('+')[2][0:7]}"
> >> > > +
> >> > > +kernel_do_configure_prepend() {
> >> > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> >> > > +    then
> >> > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> >> > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> >> > > +    fi
> >> > > +}
> >> > > --
> >> > > 1.8.3.2
> >> > >
> >> > > _______________________________________________
> >> > > meta-arago mailing list
> >> > > meta-arago@arago-project.org
> >> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >> > _______________________________________________
> >> > meta-arago mailing list
> >> > meta-arago@arago-project.org
> >> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-26 14:48       ` Denys Dmytriyenko
@ 2013-08-26 18:04         ` Cooper Jr., Franklin
  2013-08-26 18:56           ` Maupin, Chase
  0 siblings, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2013-08-26 18:04 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago



> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, August 26, 2013 9:48 AM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> and AUTOREV
> 
> On Fri, Aug 23, 2013 at 09:54:44PM +0000, Cooper Jr., Franklin wrote:
> >
> >
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Friday, August 23, 2013 4:15 PM
> > > To: Cooper Jr., Franklin
> > > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> > > Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> > > LOCALVERSION and AUTOREV
> > >
> > > On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > > > Sent: Friday, August 23, 2013 4:04 PM
> > > > > To: meta-arago@arago-project.org
> > > > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> > > > > LOCALVERSION and AUTOREV
> > > > >
> > > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > >
> > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > > ---
> > > > > v2 - removed the comment about upstreaming LOCALVERSION, may not
> > > > > happen
> > > > >
> > > > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17
> > > > > +++++++++++++++++
> > > > >  1 file changed, 17 insertions(+)  create mode 100644
> > > > > meta-arago-distro/recipes-kernel/linux/linux-ti-
> > > > > staging_git.bbappend
> > > > >
> > > > > diff --git
> > > > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bb
> > > > > appe
> > > > > nd
> > > > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bb
> > > > > appe
> > > > > nd
> > > > > new file mode 100644
> > > > > index 0000000..f99482c
> > > > > --- /dev/null
> > > > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_gi
> > > > > +++ t.bb
> > > > > +++ append
> > > > > @@ -0,0 +1,17 @@
> > > > > +MACHINE_KERNEL_PR_append = "-arago0"
> > > > > +
> > > > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> > > > > +
> > > > > +require copy-defconfig.inc
> > >
> > > > [Franklin] Are we really planning on have different defconfigs for
> > > > each machine? I thought with DT all machines will share the same
> defconfig.
> > >
> > > Yes, linux-ti-staging uses a blank defconfig that points to
> omap2plus_defconfig.
> > >
> > > But copy-defconfig just saves the current config for SDK use - they
> > > will be the same for machines using this recipe. But still, there
> > > are currently only 2 OMAP machines supported by this kernel and will
> > > be 2 Sitara machines with this patchset. If/when we switch remaining
> > > SDK machines to use the latest kernel, we can revisit this matter, I guess.
> > [Franklin]
> > I guess my point was that copy-defconfig.inc renames the .config to
> > tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME to
> "omap2plus_defconfig"
> > since we should stick with that defconfig name for all machines?
> 
> And what I was trying to say before, is that "all machines" is currently only 2 out
> of several and even then, omap2plus_defconfig in the kernel may not match
> exactly the one produced by the SDK - there may be some mangling involved to
> adjust some config options to sane defaults (although we no longer include
> linux.inc with that code), plus we run "make oldconfig" on it, which checks
> dependecies between config options and may change some os them. In other
> words: omap2plus_defconfig != .config which we package in the SDK. It is like
> the difference between pristine sources and sources that were patched and
> configured...
[Franklin]  I was hoping we would get rid of all the tweaks to the defconfig so that omap2plus_defconfig == .config . This would mean we push all modifications we needed to mainline. Similar to my response to Chase if that isn't the plan then I have no issue with the approach.
> 
> --
> Denys
> 
> 
> > > > > +SRCREV = "${AUTOREV}"
> > > > > +
> > > > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > > > > True).partition('+')[2][0:7]}"
> > > > > +
> > > > > +kernel_do_configure_prepend() {
> > > > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> > > > > +    then
> > > > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> > > > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> > > > > +    fi
> > > > > +}
> > > > > --
> > > > > 1.8.3.2
> > > > >
> > > > > _______________________________________________
> > > > > meta-arago mailing list
> > > > > meta-arago@arago-project.org
> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV
  2013-08-26 18:04         ` Cooper Jr., Franklin
@ 2013-08-26 18:56           ` Maupin, Chase
  0 siblings, 0 replies; 10+ messages in thread
From: Maupin, Chase @ 2013-08-26 18:56 UTC (permalink / raw)
  To: Cooper Jr., Franklin, Dmytriyenko, Denys; +Cc: meta-arago

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Monday, August 26, 2013 1:04 PM
>To: Dmytriyenko, Denys
>Cc: meta-arago@arago-project.org
>Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
>LOCALVERSION and AUTOREV
>
>
>
>> -----Original Message-----
>> From: Dmytriyenko, Denys
>> Sent: Monday, August 26, 2013 9:48 AM
>> To: Cooper Jr., Franklin
>> Cc: meta-arago@arago-project.org
>> Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
>LOCALVERSION
>> and AUTOREV
>>
>> On Fri, Aug 23, 2013 at 09:54:44PM +0000, Cooper Jr., Franklin
>wrote:
>> >
>> >
>> > > -----Original Message-----
>> > > From: Dmytriyenko, Denys
>> > > Sent: Friday, August 23, 2013 4:15 PM
>> > > To: Cooper Jr., Franklin
>> > > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
>> > > Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging:
>enable
>> > > LOCALVERSION and AUTOREV
>> > >
>> > > On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr.,
>Franklin wrote:
>> > > >
>> > > >
>> > > > > -----Original Message-----
>> > > > > From: meta-arago-bounces@arago-project.org [mailto:meta-
>arago-
>> > > > > bounces@arago-project.org] On Behalf Of Denys
>Dmytriyenko
>> > > > > Sent: Friday, August 23, 2013 4:04 PM
>> > > > > To: meta-arago@arago-project.org
>> > > > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging:
>enable
>> > > > > LOCALVERSION and AUTOREV
>> > > > >
>> > > > > From: Denys Dmytriyenko <denys@ti.com>
>> > > > >
>> > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> > > > > ---
>> > > > > v2 - removed the comment about upstreaming LOCALVERSION,
>may not
>> > > > > happen
>> > > > >
>> > > > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend
>| 17
>> > > > > +++++++++++++++++
>> > > > >  1 file changed, 17 insertions(+)  create mode 100644
>> > > > > meta-arago-distro/recipes-kernel/linux/linux-ti-
>> > > > > staging_git.bbappend
>> > > > >
>> > > > > diff --git
>> > > > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-
>staging_git.bb
>> > > > > appe
>> > > > > nd
>> > > > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-
>staging_git.bb
>> > > > > appe
>> > > > > nd
>> > > > > new file mode 100644
>> > > > > index 0000000..f99482c
>> > > > > --- /dev/null
>> > > > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-
>staging_gi
>> > > > > +++ t.bb
>> > > > > +++ append
>> > > > > @@ -0,0 +1,17 @@
>> > > > > +MACHINE_KERNEL_PR_append = "-arago0"
>> > > > > +
>> > > > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
>> > > > > +
>> > > > > +require copy-defconfig.inc
>> > >
>> > > > [Franklin] Are we really planning on have different
>defconfigs for
>> > > > each machine? I thought with DT all machines will share
>the same
>> defconfig.
>> > >
>> > > Yes, linux-ti-staging uses a blank defconfig that points to
>> omap2plus_defconfig.
>> > >
>> > > But copy-defconfig just saves the current config for SDK use
>- they
>> > > will be the same for machines using this recipe. But still,
>there
>> > > are currently only 2 OMAP machines supported by this kernel
>and will
>> > > be 2 Sitara machines with this patchset. If/when we switch
>remaining
>> > > SDK machines to use the latest kernel, we can revisit this
>matter, I guess.
>> > [Franklin]
>> > I guess my point was that copy-defconfig.inc renames the
>.config to
>> > tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME to
>> "omap2plus_defconfig"
>> > since we should stick with that defconfig name for all
>machines?
>>
>> And what I was trying to say before, is that "all machines" is
>currently only 2 out
>> of several and even then, omap2plus_defconfig in the kernel may
>not match
>> exactly the one produced by the SDK - there may be some mangling
>involved to
>> adjust some config options to sane defaults (although we no
>longer include
>> linux.inc with that code), plus we run "make oldconfig" on it,
>which checks
>> dependecies between config options and may change some os them.
>In other
>> words: omap2plus_defconfig != .config which we package in the
>SDK. It is like
>> the difference between pristine sources and sources that were
>patched and
>> configured...
>[Franklin]  I was hoping we would get rid of all the tweaks to the
>defconfig so that omap2plus_defconfig == .config . This would mean
>we push all modifications we needed to mainline. Similar to my
>response to Chase if that isn't the plan then I have no issue with
>the approach.

It's not about just pushing everything to mainline. You may decide to enable/disable features for your SDK and want to have different configs for a device.  Currently we only use one ut I don't see the harm in having a copy that is consistent so that everyone knows what we built with in case you do need any tweaks.

>>
>> --
>> Denys
>>
>>
>> > > > > +SRCREV = "${AUTOREV}"
>> > > > > +
>> > > > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
>> > > > > True).partition('+')[2][0:7]}"
>> > > > > +
>> > > > > +kernel_do_configure_prepend() {
>> > > > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion
>]
>> > > > > +    then
>> > > > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
>> > > > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
>> > > > > +    fi
>> > > > > +}
>> > > > > --
>> > > > > 1.8.3.2
>> > > > >
>> > > > > _______________________________________________
>> > > > > meta-arago mailing list
>> > > > > meta-arago@arago-project.org
>> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-
>arago
>> > > > _______________________________________________
>> > > > meta-arago mailing list
>> > > > meta-arago@arago-project.org
>> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-
>arago
>> >
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-08-26 18:56 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 21:03 [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV Denys Dmytriyenko
2013-08-23 21:03 ` [PATCHv2 4/4] u-boot-ti-staging: " Denys Dmytriyenko
2013-08-23 21:08 ` [PATCHv2 3/4] linux-ti-staging: " Cooper Jr., Franklin
2013-08-23 21:15   ` Denys Dmytriyenko
2013-08-23 21:54     ` Cooper Jr., Franklin
2013-08-26 13:11       ` Maupin, Chase
2013-08-26 17:58         ` Cooper Jr., Franklin
2013-08-26 14:48       ` Denys Dmytriyenko
2013-08-26 18:04         ` Cooper Jr., Franklin
2013-08-26 18:56           ` Maupin, Chase

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.