[PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[Jacob Stiffler]

* If tisdk-readme is packaged, then the uEnv.txt should also be
  packaged.
* Package both if not amsdk.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
index 61886ff..c6994ee 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
@@ -23,8 +23,8 @@ TOOLS_append_am3517-evm = " flash-utility"
 
 EXTRA_FILES = ""
 EXTRA_FILES_omap-a15 = "tisdk-readme tisdk-uenv"
-EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
-EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
+EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
+EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
 
 RDEPENDS_${PN} = "\
     ${TOOLS} \
-- 
1.7.9.5

Re: [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[Cooper Jr., Franklin]

Why do you need uEnv.txt especially since it's blank from what I remember?


> On Apr 8, 2015, at 5:50 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> * If tisdk-readme is packaged, then the uEnv.txt should also be
>  packaged.
> * Package both if not amsdk.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
> index 61886ff..c6994ee 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
> @@ -23,8 +23,8 @@ TOOLS_append_am3517-evm = " flash-utility"
> 
> EXTRA_FILES = ""
> EXTRA_FILES_omap-a15 = "tisdk-readme tisdk-uenv"
> -EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
> -EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
> +EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
> +EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
> 
> RDEPENDS_${PN} = "\
>     ${TOOLS} \
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[Stiffler, Jacob]

Nothing is being set in it, but there is a nice description of what it can be used for, so it seems like it could be helpful for users.

Maybe this uEnv.txt could be updated to have some sample configurations (e.g. setting some bootargs) which would be commented out?

- Jake

-----Original Message-----
From: Cooper Jr., Franklin 
Sent: Wednesday, April 08, 2015 8:03 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

Why do you need uEnv.txt especially since it's blank from what I remember?


> On Apr 8, 2015, at 5:50 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> * If tisdk-readme is packaged, then the uEnv.txt should also be  
> packaged.
> * Package both if not amsdk.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git 
> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> k-amsdk-sdk-host.bb 
> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> k-amsdk-sdk-host.bb
> index 61886ff..c6994ee 100644
> --- 
> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> k-amsdk-sdk-host.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> +++ tisdk-amsdk-sdk-host.bb
> @@ -23,8 +23,8 @@ TOOLS_append_am3517-evm = " flash-utility"
> 
> EXTRA_FILES = ""
> EXTRA_FILES_omap-a15 = "tisdk-readme tisdk-uenv"
> -EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
> -EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
> +EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
> +EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
> 
> RDEPENDS_${PN} = "\
>     ${TOOLS} \
> --
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[Cooper Jr., Franklin]

No uEnv.txt is something we should never be using. There is literally no need for it since saveenv works for every single evm.

 In the past that wasn't the case but even then packaging a blank uEnv.txt is pointless and it something that should be documented.


> On Apr 8, 2015, at 7:06 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> Nothing is being set in it, but there is a nice description of what it can be used for, so it seems like it could be helpful for users.
> 
> Maybe this uEnv.txt could be updated to have some sample configurations (e.g. setting some bootargs) which would be commented out?
> 
> - Jake
> 
> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Wednesday, April 08, 2015 8:03 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.
> 
> Why do you need uEnv.txt especially since it's blank from what I remember?
> 
> 
>> On Apr 8, 2015, at 5:50 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> * If tisdk-readme is packaged, then the uEnv.txt should also be  
>> packaged.
>> * Package both if not amsdk.
>> 
>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>> ---
>> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git 
>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
>> k-amsdk-sdk-host.bb 
>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
>> k-amsdk-sdk-host.bb
>> index 61886ff..c6994ee 100644
>> --- 
>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
>> k-amsdk-sdk-host.bb
>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
>> +++ tisdk-amsdk-sdk-host.bb
>> @@ -23,8 +23,8 @@ TOOLS_append_am3517-evm = " flash-utility"
>> 
>> EXTRA_FILES = ""
>> EXTRA_FILES_omap-a15 = "tisdk-readme tisdk-uenv"
>> -EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
>> -EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
>> +EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
>> +EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
>> 
>> RDEPENDS_${PN} = "\
>>    ${TOOLS} \
>> --
>> 1.7.9.5
>> 
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[Stiffler, Jacob]

I've used it before to set bootargs when I did not have the serial connection.

-----Original Message-----
From: Cooper Jr., Franklin 
Sent: Wednesday, April 08, 2015 8:09 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

No uEnv.txt is something we should never be using. There is literally no need for it since saveenv works for every single evm.

 In the past that wasn't the case but even then packaging a blank uEnv.txt is pointless and it something that should be documented.


> On Apr 8, 2015, at 7:06 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> Nothing is being set in it, but there is a nice description of what it can be used for, so it seems like it could be helpful for users.
> 
> Maybe this uEnv.txt could be updated to have some sample configurations (e.g. setting some bootargs) which would be commented out?
> 
> - Jake
> 
> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Wednesday, April 08, 2015 8:03 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.
> 
> Why do you need uEnv.txt especially since it's blank from what I remember?
> 
> 
>> On Apr 8, 2015, at 5:50 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> * If tisdk-readme is packaged, then the uEnv.txt should also be 
>> packaged.
>> * Package both if not amsdk.
>> 
>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>> ---
>> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git
>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tis
>> d
>> k-amsdk-sdk-host.bb
>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tis
>> d
>> k-amsdk-sdk-host.bb
>> index 61886ff..c6994ee 100644
>> ---
>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tis
>> d
>> k-amsdk-sdk-host.bb
>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago
>> +++ -
>> +++ tisdk-amsdk-sdk-host.bb
>> @@ -23,8 +23,8 @@ TOOLS_append_am3517-evm = " flash-utility"
>> 
>> EXTRA_FILES = ""
>> EXTRA_FILES_omap-a15 = "tisdk-readme tisdk-uenv"
>> -EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
>> -EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
>> +EXTRA_FILES_ti33x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
>> +EXTRA_FILES_ti43x = "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-uenv',d)}"
>> 
>> RDEPENDS_${PN} = "\
>>    ${TOOLS} \
>> --
>> 1.7.9.5
>> 
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-tisdk-amsdk-sdk-host: Include tisdk-uenv.

[Cooper Jr., Franklin]

Well that is fine and there is documentation for that rare instances that people need it they can use. uEnv.txt isn't something most people will need to use now and its confusing for users since it isn't something that is reflected when viewing U-Boot environment variables. The amount of time we get customers complaining about their board failing to boot or some reason U-boot never "respects" their environment variable changes which generally is due to uEnv.txt

Its not used by default, it should be documented if needed, vast majority of users do not needed and it just causes headaches. So it shouldn't be included.

> -----Original Message-----
> From: Stiffler, Jacob
> Sent: Wednesday, April 08, 2015 1:45 PM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-
> host: Include tisdk-uenv.
> 
> I've used it before to set bootargs when I did not have the serial connection.
> 
> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Wednesday, April 08, 2015 8:09 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-
> host: Include tisdk-uenv.
> 
> No uEnv.txt is something we should never be using. There is literally no need
> for it since saveenv works for every single evm.
> 
>  In the past that wasn't the case but even then packaging a blank uEnv.txt is
> pointless and it something that should be documented.
> 
> 
> > On Apr 8, 2015, at 7:06 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> >
> > Nothing is being set in it, but there is a nice description of what it can be
> used for, so it seems like it could be helpful for users.
> >
> > Maybe this uEnv.txt could be updated to have some sample configurations
> (e.g. setting some bootargs) which would be commented out?
> >
> > - Jake
> >
> > -----Original Message-----
> > From: Cooper Jr., Franklin
> > Sent: Wednesday, April 08, 2015 8:03 AM
> > To: Stiffler, Jacob
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-amsdk-sdk-
> host: Include tisdk-uenv.
> >
> > Why do you need uEnv.txt especially since it's blank from what I
> remember?
> >
> >
> >> On Apr 8, 2015, at 5:50 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> >>
> >> * If tisdk-readme is packaged, then the uEnv.txt should also be
> >> packaged.
> >> * Package both if not amsdk.
> >>
> >> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> >> ---
> >> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git
> >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> tis
> >> d
> >> k-amsdk-sdk-host.bb
> >> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> tis
> >> d
> >> k-amsdk-sdk-host.bb
> >> index 61886ff..c6994ee 100644
> >> ---
> >> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> tis
> >> d
> >> k-amsdk-sdk-host.bb
> >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago
> >> +++ -
> >> +++ tisdk-amsdk-sdk-host.bb
> >> @@ -23,8 +23,8 @@ TOOLS_append_am3517-evm = " flash-utility"
> >>
> >> EXTRA_FILES = ""
> >> EXTRA_FILES_omap-a15 = "tisdk-readme tisdk-uenv"
> >> -EXTRA_FILES_ti33x =
> "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
> >> -EXTRA_FILES_ti43x =
> "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme',d)}"
> >> +EXTRA_FILES_ti33x =
> "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-
> uenv',d)}"
> >> +EXTRA_FILES_ti43x =
> "${@base_conditional('ARAGO_BRAND','amsdk','','tisdk-readme tisdk-
> uenv',d)}"
> >>
> >> RDEPENDS_${PN} = "\
> >>    ${TOOLS} \
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago