RE: [PATCH 2/6] omap iommu: omap2 architecture specific functions

From: "Kanigeri, Hari" <h-kanigeri2@ti.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: "linux-arm-kernel@lists.arm.linux.org.uk"
	<linux-arm-kernel@lists.arm.linux.org.uk>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Ramirez Luna, Omar" <omar.ramirez@ti.com>,
	"sakari.ailus@maxwell.research.nokia.com"
	<sakari.ailus@maxwell.research.nokia.com>,
	"tony@atomide.com" <tony@atomide.com>,
	"Pasam, Vijay" <vpasam@ti.com>
Subject: RE: [PATCH 2/6] omap iommu: omap2 architecture specific functions
Date: Thu, 7 May 2009 09:40:35 -0500	[thread overview]
Message-ID: <8F7AF80515AF0D4D93307E594F3CB40E2AE47A12@dlee03.ent.ti.com> (raw)
In-Reply-To: <20090507.081259.233680638.Hiroshi.DOYU@nokia.com>

Hi,

> +static irqreturn_t iommu_fault_handler(int irq, void *data)
> +{
> +       u32 stat, da;
> +       u32 *iopgd, *iopte;
> +       int err = -EIO;
> +       struct iommu *obj = data;
> +
> +       if (!obj->refcount)
> +               return IRQ_NONE;
> +
> +       /* Dynamic loading TLB or PTE */
> +       if (obj->isr)
> +               err = obj->isr(obj);
> 		      ^^^^^^^^^^^^^^
> 
> If the above "isr" function sets a new "tlb" or "pte" entry, then
> further iommu fault won't happen anymore.
>

-- I think adding the new tlb entry or any other error recovery mechanism should be deferred to the registered callback function. 

Thank you,
Best regards,
Hari