Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

[Thomas Huth]

On 2018-09-28 15:49, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  hw/net/lance.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/net/lance.c b/hw/net/lance.c
> index a08d5ac6a848..f987b2fd180f 100644
> --- a/hw/net/lance.c
> +++ b/hw/net/lance.c
> @@ -97,9 +97,9 @@ static const VMStateDescription vmstate_lance = {
>      }
>  };
>  
> -static int lance_init(SysBusDevice *sbd)
> +static void lance_realize(DeviceState *dev, Error **errp)
>  {
> -    DeviceState *dev = DEVICE(sbd);
> +    SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
>      SysBusPCNetState *d = SYSBUS_PCNET(dev);
>      PCNetState *s = &d->state;
>  
> @@ -115,7 +115,6 @@ static int lance_init(SysBusDevice *sbd)
>      s->phys_mem_read = ledma_memory_read;
>      s->phys_mem_write = ledma_memory_write;
>      pcnet_common_init(dev, s, &net_lance_info);
> -    return 0;
>  }
>  
>  static void lance_reset(DeviceState *dev)
> @@ -144,9 +143,8 @@ static Property lance_properties[] = {
>  static void lance_class_init(ObjectClass *klass, void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
> -    SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
>  
> -    k->init = lance_init;
> +    dc->realize = lance_realize;
>      set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>      dc->fw_name = "ethernet";
>      dc->reset = lance_reset;
> 

Tested-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH 00/11] net: convert SysBus init method to a realize method

[Cédric Le Goater]

Hello,

On 9/28/18 3:49 PM, Cédric Le Goater wrote:
> Hello,
> 
> Here is my take to the SysBus init to realize method conversion. I
> picked the /net directory and did them all. Also added a couple of
> reset methods in separate patches.
> 
> make check tested

Do we have enough review for this series ? if so, may be it could
go through Jason's tree ?

Thanks,

C.
 
> Cédric Le Goater (11):
>   net: etraxfs_eth: convert SysBus init method to a realize method
>   net: etraxfs_eth: add a reset method
>   net: lan9118: convert SysBus init method to a realize method
>   net: lance: convert SysBus init method to a realize method
>   net: milkymist_minimac2: convert SysBus init method to a realize
>     method
>   net: mipsnet: convert SysBus init method to a realize method
>   net: opencores_eth: convert SysBus init method to a realize method
>   net: smc91c111: convert SysBus init method to a realize method
>   net: stellaris_enet: convert SysBus init method to a realize method
>   net: stellaris_enet: add a reset method
>   net: xgmac: convert SysBus init method to a realize method
> 
>  hw/net/etraxfs_eth.c        | 23 ++++++++++++++---------
>  hw/net/lan9118.c            | 24 ++++++++++--------------
>  hw/net/lance.c              |  8 +++-----
>  hw/net/milkymist-minimac2.c |  9 +++------
>  hw/net/mipsnet.c            |  9 +++------
>  hw/net/opencores_eth.c      |  8 +++-----
>  hw/net/smc91c111.c          | 22 +++++++++-------------
>  hw/net/stellaris_enet.c     | 15 +++++++--------
>  hw/net/xgmac.c              |  9 +++------
>  9 files changed, 55 insertions(+), 72 deletions(-)
> 

Re: [Qemu-devel] [PATCH 00/11] net: convert SysBus init method to a realize method

[Cédric Le Goater]

On 10/10/18 1:57 PM, Cédric Le Goater wrote:
> Hello,
> 
> On 9/28/18 3:49 PM, Cédric Le Goater wrote:
>> Hello,
>>
>> Here is my take to the SysBus init to realize method conversion. I
>> picked the /net directory and did them all. Also added a couple of
>> reset methods in separate patches.
>>
>> make check tested
> 
> Do we have enough review for this series ? if so, may be it could
> go through Jason's tree ?

I meant v2.

	https://patchwork.ozlabs.org/project/qemu-devel/list/?series=68378

Thanks,

C.