[PATCH] OPP: Allow same OPP table to be used for multiple genpd

[PATCH] OPP: Allow same OPP table to be used for multiple genpd

[Viresh Kumar]

The OPP binding says:

	Property: operating-points-v2

	...

	This can contain more than one phandle for power domain
	providers that provide multiple power domains. That is, one
	phandle for each power domain. If only one phandle is available,
	then the same OPP table will be used for all power domains
	provided by the power domain provider.

But the OPP core isn't allowing the same OPP table to be used for
multiple domains. Update dev_pm_opp_of_add_table_indexed() to allow
that.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 drivers/opp/of.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 6d15f05bfc28..7af0ddec936b 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -554,11 +554,24 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_of_add_table);
 int dev_pm_opp_of_add_table_indexed(struct device *dev, int index)
 {
 	struct device_node *opp_np;
-	int ret;
+	int ret, count;
 
+again:
 	opp_np = _opp_of_get_opp_desc_node(dev->of_node, index);
-	if (!opp_np)
+	if (!opp_np) {
+		/*
+		 * If only one phandle is present, then the same OPP table
+		 * applies for all index requests.
+		 */
+		count = of_count_phandle_with_args(dev->of_node,
+						   "operating-points-v2", NULL);
+		if (count == 1 && index) {
+			index = 0;
+			goto again;
+		}
+
 		return -ENODEV;
+	}
 
 	ret = _of_add_opp_table_v2(dev, opp_np);
 	of_node_put(opp_np);
-- 
2.15.0.194.g9af6a3dea062

Re: [PATCH] OPP: Allow same OPP table to be used for multiple genpd

[Stephen Boyd]

Quoting Viresh Kumar (2018-05-30 03:09:02)
> The OPP binding says:
> 
>         Property: operating-points-v2
> 
>         ...
> 
>         This can contain more than one phandle for power domain
>         providers that provide multiple power domains. That is, one
>         phandle for each power domain. If only one phandle is available,
>         then the same OPP table will be used for all power domains
>         provided by the power domain provider.
> 
> But the OPP core isn't allowing the same OPP table to be used for
> multiple domains. Update dev_pm_opp_of_add_table_indexed() to allow
> that.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Tested-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

Re: [PATCH] OPP: Allow same OPP table to be used for multiple genpd

[Stephen Boyd]

Quoting Viresh Kumar (2018-05-30 03:09:02)
> The OPP binding says:
> 
>         Property: operating-points-v2
> 
>         ...
> 
>         This can contain more than one phandle for power domain
>         providers that provide multiple power domains. That is, one
>         phandle for each power domain. If only one phandle is available,
>         then the same OPP table will be used for all power domains
>         provided by the power domain provider.
> 
> But the OPP core isn't allowing the same OPP table to be used for
> multiple domains. Update dev_pm_opp_of_add_table_indexed() to allow
> that.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Tested-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>