All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Imre Deak <imre.deak@intel.com>, dri-devel@lists.freedesktop.org
Cc: Alan Liu <HaoPing.Liu@amd.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c
Date: Tue, 2 Aug 2022 12:57:24 -0400	[thread overview]
Message-ID: <8a3f1d72-5995-5db3-e550-8c532024c304@amd.com> (raw)
In-Reply-To: <20220801135259.3039679-2-imre.deak@intel.com>



On 2022-08-01 09:52, Imre Deak wrote:
> Fix compiler warnings like the following triggered by
> '-Wmissing-prototypes':
> 
>    CC [M]  drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.o
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous prototype for ‘amd_get_format_info’ [-Wmissing-prototypes]

I see "‘" around "amd_get_format_info"; I'm not sure if my email 
client adds that or if there is something wrong in the commit message.

With the commit message change:

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

>   const struct drm_format_info *amd_get_format_info(const struct drm_mode_fb_cmd2 *cmd)
> 
> Fixes: 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes")
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Alan Liu <HaoPing.Liu@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> index 5eb5d31e591de..da3b086b0d6ef 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> @@ -33,6 +33,7 @@
>   #include "amdgpu.h"
>   #include "dal_asic_id.h"
>   #include "amdgpu_display.h"
> +#include "amdgpu_dm_plane.h"
>   #include "amdgpu_dm_trace.h"
>   #include "gc/gc_11_0_0_offset.h"
>   #include "gc/gc_11_0_0_sh_mask.h"


WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Imre Deak <imre.deak@intel.com>, dri-devel@lists.freedesktop.org
Cc: Alan Liu <HaoPing.Liu@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Harry Wentland <Harry.Wentland@amd.com>
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c
Date: Tue, 2 Aug 2022 12:57:24 -0400	[thread overview]
Message-ID: <8a3f1d72-5995-5db3-e550-8c532024c304@amd.com> (raw)
In-Reply-To: <20220801135259.3039679-2-imre.deak@intel.com>



On 2022-08-01 09:52, Imre Deak wrote:
> Fix compiler warnings like the following triggered by
> '-Wmissing-prototypes':
> 
>    CC [M]  drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.o
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous prototype for ‘amd_get_format_info’ [-Wmissing-prototypes]

I see "‘" around "amd_get_format_info"; I'm not sure if my email 
client adds that or if there is something wrong in the commit message.

With the commit message change:

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

>   const struct drm_format_info *amd_get_format_info(const struct drm_mode_fb_cmd2 *cmd)
> 
> Fixes: 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes")
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Alan Liu <HaoPing.Liu@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> index 5eb5d31e591de..da3b086b0d6ef 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> @@ -33,6 +33,7 @@
>   #include "amdgpu.h"
>   #include "dal_asic_id.h"
>   #include "amdgpu_display.h"
> +#include "amdgpu_dm_plane.h"
>   #include "amdgpu_dm_trace.h"
>   #include "gc/gc_11_0_0_offset.h"
>   #include "gc/gc_11_0_0_sh_mask.h"


  reply	other threads:[~2022-08-02 16:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 13:52 [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c Imre Deak
2022-08-01 13:52 ` [Intel-gfx] " Imre Deak
2022-08-01 13:52 ` [PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns " Imre Deak
2022-08-01 13:52   ` [Intel-gfx] " Imre Deak
2022-08-02 16:57   ` Rodrigo Siqueira Jordao [this message]
2022-08-02 16:57     ` Rodrigo Siqueira Jordao
2022-08-03 12:41     ` Imre Deak
2022-08-03 12:41       ` [Intel-gfx] " Imre Deak
2022-08-03 14:24       ` Rodrigo Siqueira Jordao
2022-08-03 14:24         ` [Intel-gfx] " Rodrigo Siqueira Jordao
2022-08-01 13:52 ` [Intel-gfx] [PATCH 3/3] drm/amd/display: Fix static declaration follows non-static declaration compiler warn Imre Deak
2022-08-01 13:52   ` Imre Deak
2022-08-02 16:58   ` Rodrigo Siqueira Jordao
2022-08-02 16:58     ` [Intel-gfx] " Rodrigo Siqueira Jordao
2022-08-01 13:57 ` [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c Simon Ser
2022-08-01 13:57   ` [Intel-gfx] " Simon Ser
2022-08-10 16:45   ` Alex Deucher
2022-08-10 16:45     ` [Intel-gfx] " Alex Deucher
2022-08-10 16:45     ` Alex Deucher
2022-08-01 20:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
2022-08-01 20:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-01 20:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-02  6:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a3f1d72-5995-5db3-e550-8c532024c304@amd.com \
    --to=rodrigo.siqueira@amd.com \
    --cc=HaoPing.Liu@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.