All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling
@ 2020-01-20 22:03 Imre Deak
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Imre Deak @ 2020-01-20 22:03 UTC (permalink / raw)
  To: igt-dev

From: Vanshidhar Konda <vanshidhar.r.konda@intel.com>

Add a method to query if the device supports setting and getting legacy
tiling formats for buffer objects.

Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/ioctl_wrappers.c | 17 +++++++++++++++++
 lib/ioctl_wrappers.h |  1 +
 2 files changed, 18 insertions(+)

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 627717d2..c1abb575 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -133,6 +133,23 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg)
 	return err;
 }
 
+/**
+ * gem_has_legacy_hw_tiling:
+ * @fd: open i915 drm file descriptor
+ *
+ * Feature check to query if the device supports setting/getting
+ * legacy tiling formats for buffer objects
+ *
+ * Returns: True if tiling is supported
+ */
+bool
+gem_has_legacy_hw_tiling(int fd)
+{
+	struct drm_i915_gem_get_tiling arg = {};
+
+	return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP);
+}
+
 /**
  * gem_get_tiling:
  * @fd: open i915 drm file descriptor
diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
index 7614e688..0ea77738 100644
--- a/lib/ioctl_wrappers.h
+++ b/lib/ioctl_wrappers.h
@@ -146,6 +146,7 @@ void gem_require_caching(int fd);
 void gem_require_ring(int fd, unsigned ring);
 bool gem_has_mocs_registers(int fd);
 void gem_require_mocs_registers(int fd);
+bool gem_has_legacy_hw_tiling(int fd);
 
 #define gem_has_ring(f, r) gem_context_has_engine(f, 0, r)
 
-- 
2.23.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
  2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
@ 2020-01-20 22:03 ` Imre Deak
  2020-01-21 16:19   ` Juha-Pekka Heikkila
  2020-01-22  6:02   ` Dixit, Ashutosh
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs " Imre Deak
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 11+ messages in thread
From: Imre Deak @ 2020-01-20 22:03 UTC (permalink / raw)
  To: igt-dev

On platforms without HW detiling use render copy or blitting to convert
between a tiled and a linear framebuffer.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/igt_fb.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index c81b9de8..b5b1750e 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
 	return true;
 }
 
+static bool hw_can_detile(const struct igt_fb *fb)
+{
+	if (fb->modifier == DRM_FORMAT_MOD_NONE)
+		return true;
+
+	if (!gem_has_legacy_hw_tiling(fb->fd))
+		return false;
+
+	return fb->modifier != I915_FORMAT_MOD_Yf_TILED;
+}
+
 static bool use_enginecopy(const struct igt_fb *fb)
 {
 	return is_ccs_modifier(fb->modifier) ||
-		(fb->modifier == I915_FORMAT_MOD_Yf_TILED &&
-		 !blitter_ok(fb));
+		(!hw_can_detile(fb) && !blitter_ok(fb));
 }
 
 static bool use_blitter(const struct igt_fb *fb)
 {
 	return (fb->modifier == I915_FORMAT_MOD_Y_TILED ||
-		fb->modifier == I915_FORMAT_MOD_Yf_TILED) &&
+		!hw_can_detile(fb)) &&
 		blitter_ok(fb);
 }
 
-- 
2.23.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling
  2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
@ 2020-01-20 22:03 ` Imre Deak
  2020-01-21 16:21   ` Juha-Pekka Heikkila
  2020-01-21  4:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Patchwork
  2020-01-21 19:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 1 reply; 11+ messages in thread
From: Imre Deak @ 2020-01-20 22:03 UTC (permalink / raw)
  To: igt-dev

On platforms w/o HW detiling don't fail creating the FB due to the
expected error from the set_tiling IOCTL.

Most of the tests use a cairo surface to draw, which don't depend on HW
detiling. Other tests (using lib/igt_draw.c or drawing to the FB
directly, like kms_draw_crc, kms_frontbuffer) are failing atm and will
need to be fixed separately.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/igt_fb.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index b5b1750e..ccb76455 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -944,9 +944,10 @@ static int create_bo_for_fb(struct igt_fb *fb)
 
 		if (is_i915_device(fd)) {
 			fb->gem_handle = gem_create(fd, fb->size);
-			gem_set_tiling(fd, fb->gem_handle,
-				       igt_fb_mod_to_tiling(fb->modifier),
-				       fb->strides[0]);
+			if (gem_has_legacy_hw_tiling(fd))
+				gem_set_tiling(fd, fb->gem_handle,
+					       igt_fb_mod_to_tiling(fb->modifier),
+					       fb->strides[0]);
 		} else if (is_vc4_device(fd)) {
 			fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
 
-- 
2.23.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling
  2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs " Imre Deak
@ 2020-01-21  4:27 ` Patchwork
  2020-01-21 19:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-01-21  4:27 UTC (permalink / raw)
  To: Imre Deak; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling
URL   : https://patchwork.freedesktop.org/series/72308/
State : success

== Summary ==

CI Bug Log - changes from IGT_5375 -> IGTPW_3956
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/index.html

Known issues
------------

  Here are the changes found in IGTPW_3956 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-kbl-x1275:       [PASS][1] -> [DMESG-FAIL][2] ([i915#943])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/fi-kbl-x1275/igt@i915_selftest@live_gem_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/fi-kbl-x1275/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@live_mman:
    - fi-bxt-dsi:         [PASS][3] -> [DMESG-WARN][4] ([i915#889]) +23 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/fi-bxt-dsi/igt@i915_selftest@live_mman.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/fi-bxt-dsi/igt@i915_selftest@live_mman.html

  * igt@i915_selftest@live_reset:
    - fi-bxt-dsi:         [PASS][5] -> [DMESG-FAIL][6] ([i915#889]) +7 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/fi-bxt-dsi/igt@i915_selftest@live_reset.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/fi-bxt-dsi/igt@i915_selftest@live_reset.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@fds:
    - fi-byt-j1900:       [INCOMPLETE][7] ([i915#45]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/fi-byt-j1900/igt@gem_exec_parallel@fds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/fi-byt-j1900/igt@gem_exec_parallel@fds.html

  
#### Warnings ####

  * igt@gem_exec_parallel@contexts:
    - fi-byt-n2820:       [FAIL][9] -> [INCOMPLETE][10] ([i915#45])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/fi-byt-n2820/igt@gem_exec_parallel@contexts.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
  [i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
  [i915#943]: https://gitlab.freedesktop.org/drm/intel/issues/943


Participating hosts (46 -> 43)
------------------------------

  Additional (2): fi-cfl-8109u fi-bwr-2160 
  Missing    (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-nick 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5375 -> IGTPW_3956

  CI-20190529: 20190529
  CI_DRM_7781: 3f2b341ae1fde67f823aeb715c6f489affdef8b1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3956: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/index.html
  IGT_5375: 6a6f7a50c5b2a62f5294b37a810ec7458aaeb774 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
@ 2020-01-21 16:19   ` Juha-Pekka Heikkila
  2020-01-21 16:35     ` Imre Deak
  2020-01-22  6:02   ` Dixit, Ashutosh
  1 sibling, 1 reply; 11+ messages in thread
From: Juha-Pekka Heikkila @ 2020-01-21 16:19 UTC (permalink / raw)
  To: Imre Deak, igt-dev

On 21.1.2020 0.03, Imre Deak wrote:
> On platforms without HW detiling use render copy or blitting to convert
> between a tiled and a linear framebuffer.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>   lib/igt_fb.c | 16 +++++++++++++---
>   1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index c81b9de8..b5b1750e 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
>   	return true;
>   }
>   
> +static bool hw_can_detile(const struct igt_fb *fb)
> +{
> +	if (fb->modifier == DRM_FORMAT_MOD_NONE)
> +		return true;
> +
> +	if (!gem_has_legacy_hw_tiling(fb->fd))
> +		return false;
> +
> +	return fb->modifier != I915_FORMAT_MOD_Yf_TILED;

Should above line depend on gen? Like
return (gen < 12 || fb->modifier != I915_FORMAT_MOD_Yf_TILED); ?

> +}
> +
>   static bool use_enginecopy(const struct igt_fb *fb)
>   {
>   	return is_ccs_modifier(fb->modifier) ||
> -		(fb->modifier == I915_FORMAT_MOD_Yf_TILED &&
> -		 !blitter_ok(fb));
> +		(!hw_can_detile(fb) && !blitter_ok(fb));
>   }
>   
>   static bool use_blitter(const struct igt_fb *fb)
>   {
>   	return (fb->modifier == I915_FORMAT_MOD_Y_TILED ||
> -		fb->modifier == I915_FORMAT_MOD_Yf_TILED) &&
> +		!hw_can_detile(fb)) &&
>   		blitter_ok(fb);
>   }
>   
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs " Imre Deak
@ 2020-01-21 16:21   ` Juha-Pekka Heikkila
  0 siblings, 0 replies; 11+ messages in thread
From: Juha-Pekka Heikkila @ 2020-01-21 16:21 UTC (permalink / raw)
  To: igt-dev

On 21.1.2020 0.03, Imre Deak wrote:
> On platforms w/o HW detiling don't fail creating the FB due to the
> expected error from the set_tiling IOCTL.
> 
> Most of the tests use a cairo surface to draw, which don't depend on HW
> detiling. Other tests (using lib/igt_draw.c or drawing to the FB
> directly, like kms_draw_crc, kms_frontbuffer) are failing atm and will
> need to be fixed separately.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>   lib/igt_fb.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index b5b1750e..ccb76455 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -944,9 +944,10 @@ static int create_bo_for_fb(struct igt_fb *fb)
>   
>   		if (is_i915_device(fd)) {
>   			fb->gem_handle = gem_create(fd, fb->size);
> -			gem_set_tiling(fd, fb->gem_handle,
> -				       igt_fb_mod_to_tiling(fb->modifier),
> -				       fb->strides[0]);
> +			if (gem_has_legacy_hw_tiling(fd))
> +				gem_set_tiling(fd, fb->gem_handle,
> +					       igt_fb_mod_to_tiling(fb->modifier),
> +					       fb->strides[0]);

I don't have good ideas to offer but silently ignoring gem_set_tiling at 
this place sound bit so-so to me. Maybe put igt_debug(..) message if 
this happen? Now fb->modifier will have misleading value.

>   		} else if (is_vc4_device(fd)) {
>   			fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
>   
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
  2020-01-21 16:19   ` Juha-Pekka Heikkila
@ 2020-01-21 16:35     ` Imre Deak
  2020-01-21 17:59       ` Juha-Pekka Heikkila
  0 siblings, 1 reply; 11+ messages in thread
From: Imre Deak @ 2020-01-21 16:35 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

On Tue, Jan 21, 2020 at 06:19:30PM +0200, Juha-Pekka Heikkila wrote:
> On 21.1.2020 0.03, Imre Deak wrote:
> > On platforms without HW detiling use render copy or blitting to convert
> > between a tiled and a linear framebuffer.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >   lib/igt_fb.c | 16 +++++++++++++---
> >   1 file changed, 13 insertions(+), 3 deletions(-)
> > 
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index c81b9de8..b5b1750e 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
> >   	return true;
> >   }
> > +static bool hw_can_detile(const struct igt_fb *fb)
> > +{
> > +	if (fb->modifier == DRM_FORMAT_MOD_NONE)
> > +		return true;
> > +
> > +	if (!gem_has_legacy_hw_tiling(fb->fd))
> > +		return false;
> > +
> > +	return fb->modifier != I915_FORMAT_MOD_Yf_TILED;
> 
> Should above line depend on gen? Like
> return (gen < 12 || fb->modifier != I915_FORMAT_MOD_Yf_TILED); ?

AFAIK no platform can detile the Yf format (only X or Y), but this
shouldn't change the logic in any case, except for
!gem_has_legacy_hw_tiling().

> 
> > +}
> > +
> >   static bool use_enginecopy(const struct igt_fb *fb)
> >   {
> >   	return is_ccs_modifier(fb->modifier) ||
> > -		(fb->modifier == I915_FORMAT_MOD_Yf_TILED &&
> > -		 !blitter_ok(fb));
> > +		(!hw_can_detile(fb) && !blitter_ok(fb));
> >   }
> >   static bool use_blitter(const struct igt_fb *fb)
> >   {
> >   	return (fb->modifier == I915_FORMAT_MOD_Y_TILED ||
> > -		fb->modifier == I915_FORMAT_MOD_Yf_TILED) &&
> > +		!hw_can_detile(fb)) &&
> >   		blitter_ok(fb);
> >   }
> > 
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
  2020-01-21 16:35     ` Imre Deak
@ 2020-01-21 17:59       ` Juha-Pekka Heikkila
  0 siblings, 0 replies; 11+ messages in thread
From: Juha-Pekka Heikkila @ 2020-01-21 17:59 UTC (permalink / raw)
  To: imre.deak; +Cc: igt-dev

On 21.1.2020 18.35, Imre Deak wrote:
> On Tue, Jan 21, 2020 at 06:19:30PM +0200, Juha-Pekka Heikkila wrote:
>> On 21.1.2020 0.03, Imre Deak wrote:
>>> On platforms without HW detiling use render copy or blitting to convert
>>> between a tiled and a linear framebuffer.
>>>
>>> Signed-off-by: Imre Deak <imre.deak@intel.com>
>>> ---
>>>    lib/igt_fb.c | 16 +++++++++++++---
>>>    1 file changed, 13 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>>> index c81b9de8..b5b1750e 100644
>>> --- a/lib/igt_fb.c
>>> +++ b/lib/igt_fb.c
>>> @@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
>>>    	return true;
>>>    }
>>> +static bool hw_can_detile(const struct igt_fb *fb)
>>> +{
>>> +	if (fb->modifier == DRM_FORMAT_MOD_NONE)
>>> +		return true;
>>> +
>>> +	if (!gem_has_legacy_hw_tiling(fb->fd))
>>> +		return false;
>>> +
>>> +	return fb->modifier != I915_FORMAT_MOD_Yf_TILED;
>>
>> Should above line depend on gen? Like
>> return (gen < 12 || fb->modifier != I915_FORMAT_MOD_Yf_TILED); ?
> 
> AFAIK no platform can detile the Yf format (only X or Y), but this
> shouldn't change the logic in any case, except for
> !gem_has_legacy_hw_tiling().
> 

You are right.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

>>
>>> +}
>>> +
>>>    static bool use_enginecopy(const struct igt_fb *fb)
>>>    {
>>>    	return is_ccs_modifier(fb->modifier) ||
>>> -		(fb->modifier == I915_FORMAT_MOD_Yf_TILED &&
>>> -		 !blitter_ok(fb));
>>> +		(!hw_can_detile(fb) && !blitter_ok(fb));
>>>    }
>>>    static bool use_blitter(const struct igt_fb *fb)
>>>    {
>>>    	return (fb->modifier == I915_FORMAT_MOD_Y_TILED ||
>>> -		fb->modifier == I915_FORMAT_MOD_Yf_TILED) &&
>>> +		!hw_can_detile(fb)) &&
>>>    		blitter_ok(fb);
>>>    }
>>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling
  2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
                   ` (2 preceding siblings ...)
  2020-01-21  4:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Patchwork
@ 2020-01-21 19:26 ` Patchwork
  3 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-01-21 19:26 UTC (permalink / raw)
  To: Imre Deak; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling
URL   : https://patchwork.freedesktop.org/series/72308/
State : success

== Summary ==

CI Bug Log - changes from IGT_5375_full -> IGTPW_3956_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/index.html

Known issues
------------

  Here are the changes found in IGTPW_3956_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#112080]) +7 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb4/igt@gem_busy@busy-vcs1.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb3/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-iclb:         [PASS][3] -> [DMESG-WARN][4] ([fdo#111764])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb1/igt@gem_ctx_isolation@rcs0-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb1/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-queued:
    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html

  * igt@gem_exec_schedule@deep-bsd:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#112146]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb7/igt@gem_exec_schedule@deep-bsd.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@gem_exec_schedule@deep-bsd.html

  * igt@gem_exec_schedule@fifo-bsd1:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#109276]) +14 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb6/igt@gem_exec_schedule@fifo-bsd1.html

  * igt@gem_exec_schedule@pi-userfault-bsd:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([i915#677])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb3/igt@gem_exec_schedule@pi-userfault-bsd.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb1/igt@gem_exec_schedule@pi-userfault-bsd.html

  * igt@gem_exec_suspend@basic-s3:
    - shard-iclb:         [PASS][13] -> [INCOMPLETE][14] ([i915#140])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb1/igt@gem_exec_suspend@basic-s3.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb8/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_largeobject:
    - shard-iclb:         [PASS][15] -> [DMESG-WARN][16] ([i915#109])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb8/igt@gem_largeobject.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@gem_largeobject.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-apl:          [PASS][17] -> [INCOMPLETE][18] ([CI#80] / [fdo#103927] / [i915#530])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-apl:          [PASS][19] -> [TIMEOUT][20] ([fdo#112271] / [i915#530])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-hsw:          [PASS][21] -> [INCOMPLETE][22] ([i915#530] / [i915#61])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw1/igt@gem_persistent_relocs@forked-thrashing.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw1/igt@gem_persistent_relocs@forked-thrashing.html
    - shard-iclb:         [PASS][23] -> [TIMEOUT][24] ([fdo#112271] / [i915#530])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb6/igt@gem_persistent_relocs@forked-thrashing.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb4/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy:
    - shard-snb:          [PASS][25] -> [DMESG-WARN][26] ([fdo#111870] / [i915#478])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-iclb:         [PASS][27] -> [FAIL][28] ([i915#454])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_rps@waitboost:
    - shard-tglb:         [PASS][29] -> [FAIL][30] ([i915#413])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb6/igt@i915_pm_rps@waitboost.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb7/igt@i915_pm_rps@waitboost.html

  * igt@i915_selftest@mock_requests:
    - shard-hsw:          [PASS][31] -> [INCOMPLETE][32] ([i915#61])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw4/igt@i915_selftest@mock_requests.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw5/igt@i915_selftest@mock_requests.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl7/igt@i915_suspend@sysfs-reader.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl1/igt@i915_suspend@sysfs-reader.html

  * igt@kms_color@pipe-a-ctm-max:
    - shard-kbl:          [PASS][35] -> [FAIL][36] ([i915#168])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-kbl6/igt@kms_color@pipe-a-ctm-max.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-kbl2/igt@kms_color@pipe-a-ctm-max.html
    - shard-apl:          [PASS][37] -> [FAIL][38] ([i915#168])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl7/igt@kms_color@pipe-a-ctm-max.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl8/igt@kms_color@pipe-a-ctm-max.html
    - shard-glk:          [PASS][39] -> [FAIL][40] ([i915#168])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk4/igt@kms_color@pipe-a-ctm-max.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk7/igt@kms_color@pipe-a-ctm-max.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
    - shard-apl:          [PASS][41] -> [FAIL][42] ([i915#54]) +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
    - shard-glk:          [PASS][43] -> [FAIL][44] ([i915#54])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk9/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk5/igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-random:
    - shard-kbl:          [PASS][45] -> [FAIL][46] ([i915#54]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          [PASS][47] -> [FAIL][48] ([i915#79])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
    - shard-glk:          [PASS][49] -> [FAIL][50] ([i915#49])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [PASS][51] -> [DMESG-WARN][52] ([i915#180]) +4 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-tglb:         [PASS][53] -> [FAIL][54] ([i915#49]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-kbl:          [PASS][55] -> [INCOMPLETE][56] ([fdo#103665])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][57] -> [SKIP][58] ([fdo#109441]) +3 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@perf_pmu@enable-race-vcs1:
    - shard-tglb:         [PASS][59] -> [INCOMPLETE][60] ([i915#472])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb8/igt@perf_pmu@enable-race-vcs1.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb1/igt@perf_pmu@enable-race-vcs1.html

  
#### Possible fixes ####

  * igt@gem_busy@close-race:
    - shard-hsw:          [TIMEOUT][61] ([fdo#112271]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw2/igt@gem_busy@close-race.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw1/igt@gem_busy@close-race.html

  * igt@gem_ctx_persistence@vcs1-hostile-preempt:
    - shard-iclb:         [SKIP][63] ([fdo#109276] / [fdo#112080]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb6/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb1/igt@gem_ctx_persistence@vcs1-hostile-preempt.html

  * igt@gem_ctx_persistence@vecs0-mixed-process:
    - shard-glk:          [FAIL][65] ([i915#679]) -> [PASS][66] +1 similar issue
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk9/igt@gem_ctx_persistence@vecs0-mixed-process.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk3/igt@gem_ctx_persistence@vecs0-mixed-process.html

  * igt@gem_ctx_shared@q-smoketest-all:
    - shard-tglb:         [INCOMPLETE][67] ([fdo#111735] / [i915#472]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb7/igt@gem_ctx_shared@q-smoketest-all.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html

  * igt@gem_exec_create@forked:
    - shard-glk:          [TIMEOUT][69] ([fdo#112271] / [i915#940]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk7/igt@gem_exec_create@forked.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk2/igt@gem_exec_create@forked.html

  * igt@gem_exec_schedule@pi-common-bsd:
    - shard-iclb:         [SKIP][71] ([i915#677]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb6/igt@gem_exec_schedule@pi-common-bsd.html

  * igt@gem_exec_schedule@pi-shared-iova-bsd:
    - shard-glk:          [FAIL][73] ([i915#859]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk1/igt@gem_exec_schedule@pi-shared-iova-bsd.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk4/igt@gem_exec_schedule@pi-shared-iova-bsd.html

  * igt@gem_exec_schedule@preempt-contexts-bsd2:
    - shard-iclb:         [SKIP][75] ([fdo#109276]) -> [PASS][76] +16 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb7/igt@gem_exec_schedule@preempt-contexts-bsd2.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@gem_exec_schedule@preempt-contexts-bsd2.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][77] ([fdo#112146]) -> [PASS][78] +2 similar issues
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_store@cachelines-vcs1:
    - shard-iclb:         [SKIP][79] ([fdo#112080]) -> [PASS][80] +8 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb8/igt@gem_exec_store@cachelines-vcs1.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@gem_exec_store@cachelines-vcs1.html

  * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
    - shard-hsw:          [INCOMPLETE][81] ([i915#530] / [i915#61]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-hsw:          [TIMEOUT][83] ([fdo#112271] / [i915#530]) -> [PASS][84] +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-kbl:          [INCOMPLETE][85] ([fdo#103665] / [i915#530]) -> [PASS][86] +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-kbl4/igt@gem_persistent_relocs@forked-thrashing.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-kbl3/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-tglb:         [FAIL][87] ([i915#644]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb4/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb8/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@i915_pm_rps@reset:
    - shard-iclb:         [FAIL][89] ([i915#413]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb1/igt@i915_pm_rps@reset.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@i915_pm_rps@reset.html

  * igt@i915_selftest@mock_requests:
    - shard-tglb:         [INCOMPLETE][91] ([i915#472]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb6/igt@i915_selftest@mock_requests.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb6/igt@i915_selftest@mock_requests.html

  * igt@kms_flip@2x-flip-vs-modeset-vs-hang:
    - shard-hsw:          [INCOMPLETE][93] ([CI#80] / [i915#61]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw5/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw7/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-apl:          [DMESG-WARN][95] ([i915#180]) -> [PASS][96] +2 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
    - shard-tglb:         [FAIL][97] ([i915#49]) -> [PASS][98] +1 similar issue
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite:
    - shard-glk:          [FAIL][99] ([i915#49]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-kbl:          [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +3 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_psr@primary_page_flip:
    - shard-tglb:         [SKIP][103] ([i915#668]) -> [PASS][104] +3 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb5/igt@kms_psr@primary_page_flip.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb4/igt@kms_psr@primary_page_flip.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [SKIP][105] ([fdo#109441]) -> [PASS][106] +1 similar issue
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-glk:          [DMESG-FAIL][107] ([i915#118] / [i915#95]) -> [PASS][108]
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-glk6/igt@kms_rotation_crc@multiplane-rotation.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-glk8/igt@kms_rotation_crc@multiplane-rotation.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][109] ([i915#31]) -> [PASS][110]
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-apl3/igt@kms_setmode@basic.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-apl4/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-hsw:          [INCOMPLETE][111] ([i915#61]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@prime_mmap_coherency@ioctl-errors:
    - shard-hsw:          [FAIL][113] ([i915#831]) -> [PASS][114]
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-hsw6/igt@prime_mmap_coherency@ioctl-errors.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-hsw5/igt@prime_mmap_coherency@ioctl-errors.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [SKIP][115] ([fdo#109276] / [fdo#112080]) -> [FAIL][116] ([IGT#28]) +1 similar issue
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-tglb:         [FAIL][117] ([i915#454]) -> [SKIP][118] ([i915#468])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb5/igt@i915_pm_dc@dc6-dpms.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb1/igt@i915_pm_dc@dc6-dpms.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
    - shard-tglb:         [INCOMPLETE][119] ([i915#472] / [i915#823]) -> [SKIP][120] ([fdo#109279])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5375/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html

  
  [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
  [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#168]: https://gitlab.freedesktop.org/drm/intel/issues/168
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
  [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
  [i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
  [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
  [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
  [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
  [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#823]: https://gitlab.freedesktop.org/drm/intel/issues/823
  [i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
  [i915#859]: https://gitlab.freedesktop.org/drm/intel/issues/859
  [i915#940]: https://gitlab.freedesktop.org/drm/intel/issues/940
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (8 -> 8)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5375 -> IGTPW_3956

  CI-20190529: 20190529
  CI_DRM_7781: 3f2b341ae1fde67f823aeb715c6f489affdef8b1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3956: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/index.html
  IGT_5375: 6a6f7a50c5b2a62f5294b37a810ec7458aaeb774 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3956/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
  2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
  2020-01-21 16:19   ` Juha-Pekka Heikkila
@ 2020-01-22  6:02   ` Dixit, Ashutosh
  2020-01-22  9:34     ` Imre Deak
  1 sibling, 1 reply; 11+ messages in thread
From: Dixit, Ashutosh @ 2020-01-22  6:02 UTC (permalink / raw)
  To: Imre Deak; +Cc: igt-dev

On Mon, 20 Jan 2020 14:03:19 -0800, Imre Deak wrote:
>
> On platforms without HW detiling use render copy or blitting to convert
> between a tiled and a linear framebuffer.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  lib/igt_fb.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index c81b9de8..b5b1750e 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
>	return true;
>  }
>
> +static bool hw_can_detile(const struct igt_fb *fb)
> +{
> +	if (fb->modifier == DRM_FORMAT_MOD_NONE)
> +		return true;

The problem with doing this afais is that the code will next try to
mmap_gtt() (i.e. do a linear copy via the aperture) which will also fail
(see igt_get_cairo_surface()). So we may need to use the blitter even for
linear copies (DRM_FORMAT_MOD_NONE).

May want to look at this:

https://patchwork.freedesktop.org/patch/345926/?series=71083&rev=2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling
  2020-01-22  6:02   ` Dixit, Ashutosh
@ 2020-01-22  9:34     ` Imre Deak
  0 siblings, 0 replies; 11+ messages in thread
From: Imre Deak @ 2020-01-22  9:34 UTC (permalink / raw)
  To: Dixit, Ashutosh; +Cc: igt-dev

On Tue, Jan 21, 2020 at 10:02:06PM -0800, Dixit, Ashutosh wrote:
> On Mon, 20 Jan 2020 14:03:19 -0800, Imre Deak wrote:
> >
> > On platforms without HW detiling use render copy or blitting to convert
> > between a tiled and a linear framebuffer.
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  lib/igt_fb.c | 16 +++++++++++++---
> >  1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index c81b9de8..b5b1750e 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -1975,17 +1975,27 @@ static bool blitter_ok(const struct igt_fb *fb)
> >	return true;
> >  }
> >
> > +static bool hw_can_detile(const struct igt_fb *fb)
> > +{
> > +	if (fb->modifier == DRM_FORMAT_MOD_NONE)
> > +		return true;
> 
> The problem with doing this afais is that the code will next try to
> mmap_gtt() (i.e. do a linear copy via the aperture) which will also fail
> (see igt_get_cairo_surface()). So we may need to use the blitter even for
> linear copies (DRM_FORMAT_MOD_NONE).

Yes, but we'll still have a way to map the buffer directly in which case
we can avoid the copies.

> 
> May want to look at this:
> 
> https://patchwork.freedesktop.org/patch/345926/?series=71083&rev=2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-01-22  9:35 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak
2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Use render copy/blit for tiled formats on platforms w/o HW detiling Imre Deak
2020-01-21 16:19   ` Juha-Pekka Heikkila
2020-01-21 16:35     ` Imre Deak
2020-01-21 17:59       ` Juha-Pekka Heikkila
2020-01-22  6:02   ` Dixit, Ashutosh
2020-01-22  9:34     ` Imre Deak
2020-01-20 22:03 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Fix creating FBs " Imre Deak
2020-01-21 16:21   ` Juha-Pekka Heikkila
2020-01-21  4:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Patchwork
2020-01-21 19:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.