From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Corentin Labbe" <clabbe.montjoie@gmail.com> Cc: lgirdwood@gmail.com, mripard@kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com> Subject: Re: [BUG] Error applying setting, reverse things back on lot of devices Date: Mon, 2 Nov 2020 13:48:54 +0100 [thread overview] Message-ID: <8a580d12-fa4a-6cd8-4d82-3e3b784e348b@pengutronix.de> (raw) In-Reply-To: <20201024115307.GA2745@qmqm.qmqm.pl> Hello Michał, CC += linux-stm32 On 10/24/20 1:53 PM, Michał Mirosław wrote: > On Fri, Oct 23, 2020 at 10:39:43PM +0200, Corentin Labbe wrote: >> On Fri, Oct 23, 2020 at 03:42:01PM +0200, Corentin Labbe wrote: >>> On Wed, Oct 21, 2020 at 08:31:49PM +0200, Corentin Labbe wrote: >>> I have just saw thoses 3 lines which are probably the real problem. >>> I have started a new bisect with this error, but it is hitting the same "crash range" the first one. >>> >> >> I have bisected the problem to commit aea6cb99703e17019e025aa71643b4d3e0a24413 ("regulator: resolve supply after creating regulator") >> Reverting this fix my problem. The change broke boot on all the STM32MP1 boards, because the STPMIC driver has a vref_ddr regulator, which does not have a dedicated supply, but without a vref_ddr-supply property the system now no longer boots. > Can you try the hack below? > > Best Regards, > Michał Mirosław > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > index a4ffd71696da..9ad091f5f1ab 100644 > --- a/drivers/regulator/core.c > +++ b/drivers/regulator/core.c > @@ -1169,6 +1169,9 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, > } > > if (current_uV < 0) { > + if (current_uV == -EINVAL && rdev->supply_name) > + return -EPROBE_DEFER; > + This doesn't fix the issue for the STM32MP1 boards (tested on LXA MC-1). Seeing that the patch is already in stable, I think this patch should be reverted until the issues are solved in Linus' master. Cheers, Ahmad > rdev_err(rdev, > "failed to get the current voltage: %pe\n", > ERR_PTR(current_uV)); > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Corentin Labbe" <clabbe.montjoie@gmail.com> Cc: lgirdwood@gmail.com, mripard@kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, broonie@kernel.org, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [BUG] Error applying setting, reverse things back on lot of devices Date: Mon, 2 Nov 2020 13:48:54 +0100 [thread overview] Message-ID: <8a580d12-fa4a-6cd8-4d82-3e3b784e348b@pengutronix.de> (raw) In-Reply-To: <20201024115307.GA2745@qmqm.qmqm.pl> Hello Michał, CC += linux-stm32 On 10/24/20 1:53 PM, Michał Mirosław wrote: > On Fri, Oct 23, 2020 at 10:39:43PM +0200, Corentin Labbe wrote: >> On Fri, Oct 23, 2020 at 03:42:01PM +0200, Corentin Labbe wrote: >>> On Wed, Oct 21, 2020 at 08:31:49PM +0200, Corentin Labbe wrote: >>> I have just saw thoses 3 lines which are probably the real problem. >>> I have started a new bisect with this error, but it is hitting the same "crash range" the first one. >>> >> >> I have bisected the problem to commit aea6cb99703e17019e025aa71643b4d3e0a24413 ("regulator: resolve supply after creating regulator") >> Reverting this fix my problem. The change broke boot on all the STM32MP1 boards, because the STPMIC driver has a vref_ddr regulator, which does not have a dedicated supply, but without a vref_ddr-supply property the system now no longer boots. > Can you try the hack below? > > Best Regards, > Michał Mirosław > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > index a4ffd71696da..9ad091f5f1ab 100644 > --- a/drivers/regulator/core.c > +++ b/drivers/regulator/core.c > @@ -1169,6 +1169,9 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, > } > > if (current_uV < 0) { > + if (current_uV == -EINVAL && rdev->supply_name) > + return -EPROBE_DEFER; > + This doesn't fix the issue for the STM32MP1 boards (tested on LXA MC-1). Seeing that the patch is already in stable, I think this patch should be reverted until the issues are solved in Linus' master. Cheers, Ahmad > rdev_err(rdev, > "failed to get the current voltage: %pe\n", > ERR_PTR(current_uV)); > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-02 12:49 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-21 18:31 [BUG] Error applying setting, reverse things back on lot of devices Corentin Labbe 2020-10-21 18:31 ` Corentin Labbe 2020-10-23 13:42 ` Corentin Labbe 2020-10-23 13:42 ` Corentin Labbe 2020-10-23 20:39 ` Corentin Labbe 2020-10-23 20:39 ` Corentin Labbe 2020-10-24 11:40 ` Michał Miosław 2020-10-24 11:40 ` Michał Miosław 2020-10-24 11:53 ` Michał Mirosław 2020-10-24 11:53 ` Michał Mirosław 2020-11-01 1:31 ` Ondřej Jirman 2020-11-01 1:31 ` Ondřej Jirman 2020-11-02 7:40 ` Corentin Labbe 2020-11-02 7:40 ` Corentin Labbe 2020-11-02 12:48 ` Ahmad Fatoum [this message] 2020-11-02 12:48 ` Ahmad Fatoum 2020-11-02 20:27 ` Michał Mirosław 2020-11-02 20:27 ` Michał Mirosław 2020-11-04 10:28 ` Ahmad Fatoum 2020-11-04 10:28 ` Ahmad Fatoum 2020-11-04 10:50 ` [Linux-stm32] " Alexandre Torgue 2020-11-04 10:50 ` Alexandre Torgue 2020-11-05 8:47 ` Ahmad Fatoum 2020-11-05 8:47 ` Ahmad Fatoum 2020-11-05 2:57 ` Michał Mirosław 2020-11-05 2:57 ` Michał Mirosław 2020-11-05 9:11 ` Ahmad Fatoum 2020-11-05 9:11 ` Ahmad Fatoum 2020-11-08 17:08 ` Michał Mirosław 2020-11-08 17:08 ` Michał Mirosław 2020-11-10 10:57 ` Ahmad Fatoum 2020-11-10 10:57 ` Ahmad Fatoum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8a580d12-fa4a-6cd8-4d82-3e3b784e348b@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=broonie@kernel.org \ --cc=clabbe.montjoie@gmail.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mirq-linux@rere.qmqm.pl \ --cc=mripard@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.