* linux-next: Fixes tag needs some work in the ntb tree
@ 2019-03-20 20:58 Stephen Rothwell
2019-03-20 21:00 ` Logan Gunthorpe
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-03-20 20:58 UTC (permalink / raw)
To: Jon Mason, NTB Mailing List
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Logan Gunthorpe
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
Hi all,
In commit
f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")
Fixes tag
Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
has these problem(s):
- Target SHA1 does not exist
Did you mean:
c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntb tree
2019-03-20 20:58 linux-next: Fixes tag needs some work in the ntb tree Stephen Rothwell
@ 2019-03-20 21:00 ` Logan Gunthorpe
2019-03-21 19:53 ` Jon Mason
0 siblings, 1 reply; 6+ messages in thread
From: Logan Gunthorpe @ 2019-03-20 21:00 UTC (permalink / raw)
To: Stephen Rothwell, Jon Mason, NTB Mailing List
Cc: Linux Next Mailing List, Linux Kernel Mailing List
On 2019-03-20 2:58 p.m., Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")
>
> Fixes tag
>
> Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean:
>
> c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
My fault. I sent the fix patch with the fixes tag before the original
patch was merged upstream expecting them to be squashed. c59666bb32b9 is
the correct hash in upstream now.
Logan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntb tree
2019-03-20 21:00 ` Logan Gunthorpe
@ 2019-03-21 19:53 ` Jon Mason
2019-03-21 20:28 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Jon Mason @ 2019-03-21 19:53 UTC (permalink / raw)
To: Logan Gunthorpe
Cc: Stephen Rothwell, NTB Mailing List, Linux Next Mailing List,
Linux Kernel Mailing List
On Wed, Mar 20, 2019 at 5:00 PM Logan Gunthorpe <logang@deltatee.com> wrote:
>
>
>
> On 2019-03-20 2:58 p.m., Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")
> >
> > Fixes tag
> >
> > Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Did you mean:
> >
> > c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
>
> My fault. I sent the fix patch with the fixes tag before the original
> patch was merged upstream expecting them to be squashed. c59666bb32b9 is
> the correct hash in upstream now.
I've corrected the patch in my git branches and repushed.
Is there an existing set of tools/scripts I should run to prevent
things like this from happening?
Thanks,
Jon
>
> Logan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntb tree
2019-03-21 19:53 ` Jon Mason
@ 2019-03-21 20:28 ` Stephen Rothwell
2019-03-22 15:34 ` Jon Mason
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-03-21 20:28 UTC (permalink / raw)
To: Jon Mason
Cc: Logan Gunthorpe, NTB Mailing List, Linux Next Mailing List,
Linux Kernel Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]
Hi Jon,
On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason <jdmason@kudzu.us> wrote:
>
> Is there an existing set of tools/scripts I should run to prevent
> things like this from happening?
I have attached the script I run over all new commits submitted for
linux-next.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4342 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntb tree
2019-03-21 20:28 ` Stephen Rothwell
@ 2019-03-22 15:34 ` Jon Mason
0 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2019-03-22 15:34 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Logan Gunthorpe, NTB Mailing List, Linux Next Mailing List,
Linux Kernel Mailing List
On Thu, Mar 21, 2019 at 4:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Jon,
>
> On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason <jdmason@kudzu.us> wrote:
> >
> > Is there an existing set of tools/scripts I should run to prevent
> > things like this from happening?
>
> I have attached the script I run over all new commits submitted for
> linux-next.
Fantastic! I'll add a variation of this to my git tree and hopefully
prevent any future issues.
Thanks,
Jon
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the ntb tree
@ 2020-06-01 7:44 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-06-01 7:44 UTC (permalink / raw)
To: Jon Mason, NTB Mailing List
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Sanjay R Mehta, Arindam Nath, Logan Gunthorpe
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
Hi all,
In commit
eb3eabb28cf2 ("ntb_tool: pass correct struct device to dma_alloc_coherent")
Fixes tag
Fixes: 5648e56 ("NTB: ntb_perf: Add full multi-port NTB API support")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
In commit
55480afb82bd ("ntb_perf: pass correct struct device to dma_alloc_coherent")
Fixes tag
Fixes: 5648e56 ("NTB: ntb_perf: Add full multi-port NTB API support")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-01 7:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 20:58 linux-next: Fixes tag needs some work in the ntb tree Stephen Rothwell
2019-03-20 21:00 ` Logan Gunthorpe
2019-03-21 19:53 ` Jon Mason
2019-03-21 20:28 ` Stephen Rothwell
2019-03-22 15:34 ` Jon Mason
2020-06-01 7:44 Stephen Rothwell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.