From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: "Ursulin, Tvrtko" <tvrtko.ursulin@intel.com>, Zhihao Cheng <chengzhihao1@huawei.com>, "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>, "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>, "Vivi, Rodrigo" <rodrigo.vivi@intel.com>, "airlied@linux.ie" <airlied@linux.ie>, "daniel@ffwll.ch" <daniel@ffwll.ch>, "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk> Cc: "yukuai3@huawei.com" <yukuai3@huawei.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() Date: Wed, 2 Jun 2021 10:47:35 +0100 [thread overview] Message-ID: <8abf5ddf-7c08-c2c0-92d4-d6c30058763c@linux.intel.com> (raw) In-Reply-To: <33c46ef24cd547d0ad21dc106441491a@intel.com> On 01/06/2021 10:19, Ursulin, Tvrtko wrote: > > [Don't see this on intel-gfx so I have to reply with top post.] > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Pushed with commit text wrapped and Fixes: tag fixed, thanks for the patch! Regards, Tvrtko > > -----Original Message----- > From: Zhihao Cheng <chengzhihao1@huawei.com> > Sent: Saturday, May 29, 2021 5:33 AM > To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo <rodrigo.vivi@intel.com>; airlied@linux.ie; daniel@ffwll.ch; chris@chris-wilson.co.uk; Ursulin, Tvrtko <tvrtko.ursulin@intel.com> > Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; chengzhihao1@huawei.com; yukuai3@huawei.com > Subject: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() > > In case of error, the function live_context() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). > > Fixes: 52c0fdb25c7c9 ("drm/i915: Replace global breadcrumbs ...") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index ee8e753d98ce..eae0abd614cb 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1592,8 +1592,8 @@ static int live_breadcrumbs_smoketest(void *arg) > > for (n = 0; n < smoke[0].ncontexts; n++) { > smoke[0].contexts[n] = live_context(i915, file); > - if (!smoke[0].contexts[n]) { > - ret = -ENOMEM; > + if (IS_ERR(smoke[0].contexts[n])) { > + ret = PTR_ERR(smoke[0].contexts[n]); > goto out_contexts; > } > } > -- > 2.25.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: "Ursulin, Tvrtko" <tvrtko.ursulin@intel.com>, Zhihao Cheng <chengzhihao1@huawei.com>, "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>, "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>, "Vivi, Rodrigo" <rodrigo.vivi@intel.com>, "airlied@linux.ie" <airlied@linux.ie>, "daniel@ffwll.ch" <daniel@ffwll.ch>, "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk> Cc: "yukuai3@huawei.com" <yukuai3@huawei.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() Date: Wed, 2 Jun 2021 10:47:35 +0100 [thread overview] Message-ID: <8abf5ddf-7c08-c2c0-92d4-d6c30058763c@linux.intel.com> (raw) In-Reply-To: <33c46ef24cd547d0ad21dc106441491a@intel.com> On 01/06/2021 10:19, Ursulin, Tvrtko wrote: > > [Don't see this on intel-gfx so I have to reply with top post.] > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Pushed with commit text wrapped and Fixes: tag fixed, thanks for the patch! Regards, Tvrtko > > -----Original Message----- > From: Zhihao Cheng <chengzhihao1@huawei.com> > Sent: Saturday, May 29, 2021 5:33 AM > To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo <rodrigo.vivi@intel.com>; airlied@linux.ie; daniel@ffwll.ch; chris@chris-wilson.co.uk; Ursulin, Tvrtko <tvrtko.ursulin@intel.com> > Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; chengzhihao1@huawei.com; yukuai3@huawei.com > Subject: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() > > In case of error, the function live_context() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). > > Fixes: 52c0fdb25c7c9 ("drm/i915: Replace global breadcrumbs ...") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index ee8e753d98ce..eae0abd614cb 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1592,8 +1592,8 @@ static int live_breadcrumbs_smoketest(void *arg) > > for (n = 0; n < smoke[0].ncontexts; n++) { > smoke[0].contexts[n] = live_context(i915, file); > - if (!smoke[0].contexts[n]) { > - ret = -ENOMEM; > + if (IS_ERR(smoke[0].contexts[n])) { > + ret = PTR_ERR(smoke[0].contexts[n]); > goto out_contexts; > } > } > -- > 2.25.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-02 9:48 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-29 4:33 [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() Zhihao Cheng 2021-05-29 4:33 ` [Intel-gfx] " Zhihao Cheng 2021-05-29 4:33 ` Zhihao Cheng 2021-06-01 9:19 ` Ursulin, Tvrtko 2021-06-01 9:19 ` [Intel-gfx] " Ursulin, Tvrtko 2021-06-01 9:19 ` Ursulin, Tvrtko 2021-06-02 9:47 ` Tvrtko Ursulin [this message] 2021-06-02 9:47 ` [Intel-gfx] " Tvrtko Ursulin 2021-06-01 10:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-06-01 11:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-06-01 14:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8abf5ddf-7c08-c2c0-92d4-d6c30058763c@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=airlied@linux.ie \ --cc=chengzhihao1@huawei.com \ --cc=chris@chris-wilson.co.uk \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rodrigo.vivi@intel.com \ --cc=tvrtko.ursulin@intel.com \ --cc=yukuai3@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.