All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regmap: irq: cleanup comments
@ 2022-02-12 14:31 trix
  2022-02-12 16:00 ` Randy Dunlap
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: trix @ 2022-02-12 14:31 UTC (permalink / raw)
  To: broonie, gregkh, rafael; +Cc: linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

Replace the second 'which' with 'the'.
Change 'acknowleding' to 'acknowledging'.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/base/regmap/regmap-irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index d5604f497296..81f6356f0589 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -537,7 +537,7 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
 
 	/*
 	 * Ignore masked IRQs and ack if we need to; we ack early so
-	 * there is no race between handling and acknowleding the
+	 * there is no race between handling and acknowledging the
 	 * interrupt.  We assume that typically few of the interrupts
 	 * will fire simultaneously so don't worry about overhead from
 	 * doing a write per register.
@@ -1082,7 +1082,7 @@ EXPORT_SYMBOL_GPL(devm_regmap_add_irq_chip);
 /**
  * devm_regmap_del_irq_chip() - Resource managed regmap_del_irq_chip()
  *
- * @dev: Device for which which resource was allocated.
+ * @dev: Device for which the resource was allocated.
  * @irq: Primary IRQ for the device.
  * @data: &regmap_irq_chip_data allocated by regmap_add_irq_chip().
  *
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] regmap: irq: cleanup comments
  2022-02-12 14:31 [PATCH] regmap: irq: cleanup comments trix
@ 2022-02-12 16:00 ` Randy Dunlap
  2022-02-14 12:51 ` Mark Brown
  2022-02-14 14:56 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-02-12 16:00 UTC (permalink / raw)
  To: trix, broonie, gregkh, rafael; +Cc: linux-kernel



On 2/12/22 06:31, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Replace the second 'which' with 'the'.
> Change 'acknowleding' to 'acknowledging'.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/base/regmap/regmap-irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
> index d5604f497296..81f6356f0589 100644
> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -537,7 +537,7 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
>  
>  	/*
>  	 * Ignore masked IRQs and ack if we need to; we ack early so
> -	 * there is no race between handling and acknowleding the
> +	 * there is no race between handling and acknowledging the
>  	 * interrupt.  We assume that typically few of the interrupts
>  	 * will fire simultaneously so don't worry about overhead from
>  	 * doing a write per register.
> @@ -1082,7 +1082,7 @@ EXPORT_SYMBOL_GPL(devm_regmap_add_irq_chip);
>  /**
>   * devm_regmap_del_irq_chip() - Resource managed regmap_del_irq_chip()
>   *
> - * @dev: Device for which which resource was allocated.
> + * @dev: Device for which the resource was allocated.
>   * @irq: Primary IRQ for the device.
>   * @data: &regmap_irq_chip_data allocated by regmap_add_irq_chip().
>   *

-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regmap: irq: cleanup comments
  2022-02-12 14:31 [PATCH] regmap: irq: cleanup comments trix
  2022-02-12 16:00 ` Randy Dunlap
@ 2022-02-14 12:51 ` Mark Brown
  2022-02-14 14:56 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-02-14 12:51 UTC (permalink / raw)
  To: trix; +Cc: gregkh, rafael, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

On Sat, Feb 12, 2022 at 06:31:44AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Replace the second 'which' with 'the'.
> Change 'acknowleding' to 'acknowledging'.

This is two separate changes sent in a single patch, please don't do
that - send two patches if you have two changes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regmap: irq: cleanup comments
  2022-02-12 14:31 [PATCH] regmap: irq: cleanup comments trix
  2022-02-12 16:00 ` Randy Dunlap
  2022-02-14 12:51 ` Mark Brown
@ 2022-02-14 14:56 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-02-14 14:56 UTC (permalink / raw)
  To: gregkh, rafael, trix; +Cc: linux-kernel

On Sat, 12 Feb 2022 06:31:44 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Replace the second 'which' with 'the'.
> Change 'acknowleding' to 'acknowledging'.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/1] regmap: irq: cleanup comments
      commit: 2d2329787ba2e70eae330f1cecd61a9576fe65de

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-14 14:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 14:31 [PATCH] regmap: irq: cleanup comments trix
2022-02-12 16:00 ` Randy Dunlap
2022-02-14 12:51 ` Mark Brown
2022-02-14 14:56 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.