From: Adrian Hunter <adrian.hunter@intel.com> To: Kishon Vijay Abraham I <kishon@ti.com>, Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com> Cc: Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com Subject: Re: [PATCH 05/12] mmc: sdhci-omap: Workaround for Errata i802 Date: Thu, 21 Dec 2017 11:09:35 +0200 [thread overview] Message-ID: <8ada81f8-7e67-8d77-471a-502f6ec10b2b@intel.com> (raw) In-Reply-To: <20171214130941.26666-6-kishon@ti.com> On 14/12/17 15:09, Kishon Vijay Abraham I wrote: > Errata i802 in AM572x Sitara Processors Silicon Revision 2.0, 1.1 > (SPRZ429K July 2014–Revised March 2017 [1]) mentions > DCRC error interrupts (MMCHS_STAT[21] DCRC=0x1) can occur > during the tuning procedure and it has to be disabled during the > tuning procedure Implement workaround for Errata i802 here.. > > [1] -> http://www.ti.com/lit/er/sprz429k/sprz429k.pdf > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-omap.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index df8a0a472996..b20f4c79ccc6 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -266,6 +266,7 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_omap_host *omap_host; > struct device *dev; > + u32 ier = host->ier; > > pltfm_host = sdhci_priv(host); > omap_host = sdhci_pltfm_priv(pltfm_host); > @@ -283,6 +284,16 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) > reg |= DLL_SWT; > sdhci_omap_writel(omap_host, SDHCI_OMAP_DLL, reg); > > + /* > + * OMAP5/DRA74X/DRA72x Errata i802: > + * DCRC error interrupts (MMCHS_STAT[21] DCRC=0x1) can occur > + * during the tuning procedure. So disable it during the > + * tuning procedure. > + */ > + ier &= ~SDHCI_INT_DATA_CRC; > + sdhci_writel(host, ier, SDHCI_INT_ENABLE); > + sdhci_writel(host, ier, SDHCI_SIGNAL_ENABLE); > + > while (phase_delay <= MAX_PHASE_DELAY) { > sdhci_omap_set_dll(omap_host, phase_delay); > > @@ -328,6 +339,8 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) > > ret: > sdhci_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA); > + sdhci_writel(host, host->ier, SDHCI_INT_ENABLE); > + sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE); > return ret; > } > >
WARNING: multiple messages have this Message-ID (diff)
From: adrian.hunter@intel.com (Adrian Hunter) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 05/12] mmc: sdhci-omap: Workaround for Errata i802 Date: Thu, 21 Dec 2017 11:09:35 +0200 [thread overview] Message-ID: <8ada81f8-7e67-8d77-471a-502f6ec10b2b@intel.com> (raw) In-Reply-To: <20171214130941.26666-6-kishon@ti.com> On 14/12/17 15:09, Kishon Vijay Abraham I wrote: > Errata i802 in AM572x Sitara Processors Silicon Revision 2.0, 1.1 > (SPRZ429K July 2014?Revised March 2017 [1]) mentions > DCRC error interrupts (MMCHS_STAT[21] DCRC=0x1) can occur > during the tuning procedure and it has to be disabled during the > tuning procedure Implement workaround for Errata i802 here.. > > [1] -> http://www.ti.com/lit/er/sprz429k/sprz429k.pdf > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-omap.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index df8a0a472996..b20f4c79ccc6 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -266,6 +266,7 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_omap_host *omap_host; > struct device *dev; > + u32 ier = host->ier; > > pltfm_host = sdhci_priv(host); > omap_host = sdhci_pltfm_priv(pltfm_host); > @@ -283,6 +284,16 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) > reg |= DLL_SWT; > sdhci_omap_writel(omap_host, SDHCI_OMAP_DLL, reg); > > + /* > + * OMAP5/DRA74X/DRA72x Errata i802: > + * DCRC error interrupts (MMCHS_STAT[21] DCRC=0x1) can occur > + * during the tuning procedure. So disable it during the > + * tuning procedure. > + */ > + ier &= ~SDHCI_INT_DATA_CRC; > + sdhci_writel(host, ier, SDHCI_INT_ENABLE); > + sdhci_writel(host, ier, SDHCI_SIGNAL_ENABLE); > + > while (phase_delay <= MAX_PHASE_DELAY) { > sdhci_omap_set_dll(omap_host, phase_delay); > > @@ -328,6 +339,8 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) > > ret: > sdhci_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA); > + sdhci_writel(host, host->ier, SDHCI_INT_ENABLE); > + sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE); > return ret; > } > >
next prev parent reply other threads:[~2017-12-21 9:11 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-14 13:09 [PATCH 00/12] mmc: sdhci-omap: Add UHS/HS200 mode support Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` [PATCH 01/12] mmc: sdhci-omap: Update 'power_mode' outside sdhci_omap_init_74_clocks Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 8:57 ` Adrian Hunter 2017-12-21 8:57 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 02/12] mmc: sdhci-omap: Add card_busy host ops Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 8:59 ` Adrian Hunter 2017-12-21 8:59 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 03/12] mmc: sdhci-omap: Add custom set_uhs_signaling sdhci_host ops Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 9:01 ` Adrian Hunter 2017-12-21 9:01 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 04/12] mmc: sdhci-omap: Add tuning support Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 9:09 ` Adrian Hunter 2017-12-21 9:09 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 05/12] mmc: sdhci-omap: Workaround for Errata i802 Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 9:09 ` Adrian Hunter [this message] 2017-12-21 9:09 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 06/12] mmc: sdhci_omap: Add support to set IODELAY values Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 15:04 ` Tony Lindgren 2017-12-14 15:04 ` Tony Lindgren 2017-12-14 15:04 ` Tony Lindgren 2017-12-14 13:09 ` [PATCH 07/12] mmc: sdhci_omap: Fix sdhci-omap quirks Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 9:12 ` Adrian Hunter 2017-12-21 9:12 ` Adrian Hunter 2017-12-21 9:12 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 08/12] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 14:04 ` Philippe Ombredanne 2017-12-14 14:04 ` Philippe Ombredanne 2017-12-14 14:04 ` Philippe Ombredanne 2017-12-21 9:13 ` Adrian Hunter 2017-12-21 9:13 ` Adrian Hunter 2017-12-21 9:13 ` Adrian Hunter 2017-12-14 13:09 ` [RFC PATCH 09/12] mmc: sdhci: Use software timer when timeout greater than hardware capablility Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-20 14:11 ` Adrian Hunter 2017-12-20 14:11 ` Adrian Hunter 2018-01-04 12:59 ` Kishon Vijay Abraham I 2018-01-04 12:59 ` Kishon Vijay Abraham I 2018-01-04 12:59 ` Kishon Vijay Abraham I 2018-01-11 8:46 ` Adrian Hunter 2018-01-11 8:46 ` Adrian Hunter 2018-02-02 13:25 ` Kishon Vijay Abraham I 2018-02-02 13:25 ` Kishon Vijay Abraham I 2018-02-02 13:25 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` [PATCH 10/12] dt-bindings: sdhci-omap: Add K2G specific binding Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-16 16:49 ` Rob Herring 2017-12-16 16:49 ` Rob Herring 2017-12-16 16:49 ` Rob Herring 2017-12-14 13:09 ` [PATCH 11/12] mmc: sdhci-omap: Add support for MMC/SD controller in k2g SoC Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-21 9:15 ` Adrian Hunter 2017-12-21 9:15 ` Adrian Hunter 2017-12-14 13:09 ` [PATCH 12/12] ARM: OMAP2+: Use sdhci-omap specific pdata-quirks for MMC/SD on DRA74x EVM Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I 2017-12-14 13:09 ` Kishon Vijay Abraham I
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8ada81f8-7e67-8d77-471a-502f6ec10b2b@intel.com \ --to=adrian.hunter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=nsekhar@ti.com \ --cc=robh+dt@kernel.org \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.