All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Lei Yang <Lei.Yang@windriver.com>,
	mcgrof@kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] sysctl: kselftests: use kernel module instead of built-in
Date: Wed, 5 Sep 2018 10:47:54 -0600	[thread overview]
Message-ID: <8aeffc5f-ed8c-b418-5db3-ef0299456002@kernel.org> (raw)
In-Reply-To: <1536114044-31236-1-git-send-email-Lei.Yang@windriver.com>

On 09/04/2018 08:20 PM, Lei Yang wrote:
> It uses modprobe $TEST_DRIVER in sysctl.sh, so update
> config to use "m" instead
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/sysctl/config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sysctl/config b/tools/testing/selftests/sysctl/config
> index 6ca1480..fc263ef 100644
> --- a/tools/testing/selftests/sysctl/config
> +++ b/tools/testing/selftests/sysctl/config
> @@ -1 +1 @@
> -CONFIG_TEST_SYSCTL=y
> +CONFIG_TEST_SYSCTL=m
> 

What happens if it is a built-in? Can you elaborate in the changelog

On that note we might have other cases that do modprobe in scripts and
run into the same issue you are trying to solve. :)

thanks,
-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (Shuah Khan)
Subject: [PATCH] sysctl: kselftests: use kernel module instead of built-in
Date: Wed, 5 Sep 2018 10:47:54 -0600	[thread overview]
Message-ID: <8aeffc5f-ed8c-b418-5db3-ef0299456002@kernel.org> (raw)
In-Reply-To: <1536114044-31236-1-git-send-email-Lei.Yang@windriver.com>

On 09/04/2018 08:20 PM, Lei Yang wrote:
> It uses modprobe $TEST_DRIVER in sysctl.sh, so update
> config to use "m" instead
> 
> Signed-off-by: Lei Yang <Lei.Yang at windriver.com>
> ---
>  tools/testing/selftests/sysctl/config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sysctl/config b/tools/testing/selftests/sysctl/config
> index 6ca1480..fc263ef 100644
> --- a/tools/testing/selftests/sysctl/config
> +++ b/tools/testing/selftests/sysctl/config
> @@ -1 +1 @@
> -CONFIG_TEST_SYSCTL=y
> +CONFIG_TEST_SYSCTL=m
> 

What happens if it is a built-in? Can you elaborate in the changelog

On that note we might have other cases that do modprobe in scripts and
run into the same issue you are trying to solve. :)

thanks,
-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (Shuah Khan)
Subject: [PATCH] sysctl: kselftests: use kernel module instead of built-in
Date: Wed, 5 Sep 2018 10:47:54 -0600	[thread overview]
Message-ID: <8aeffc5f-ed8c-b418-5db3-ef0299456002@kernel.org> (raw)
Message-ID: <20180905164754.9_SIDRHvBrmfWboyQImyBj5osb076QoHl9xOlKpmups@z> (raw)
In-Reply-To: <1536114044-31236-1-git-send-email-Lei.Yang@windriver.com>

On 09/04/2018 08:20 PM, Lei Yang wrote:
> It uses modprobe $TEST_DRIVER in sysctl.sh, so update
> config to use "m" instead
> 
> Signed-off-by: Lei Yang <Lei.Yang at windriver.com>
> ---
>  tools/testing/selftests/sysctl/config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sysctl/config b/tools/testing/selftests/sysctl/config
> index 6ca1480..fc263ef 100644
> --- a/tools/testing/selftests/sysctl/config
> +++ b/tools/testing/selftests/sysctl/config
> @@ -1 +1 @@
> -CONFIG_TEST_SYSCTL=y
> +CONFIG_TEST_SYSCTL=m
> 

What happens if it is a built-in? Can you elaborate in the changelog

On that note we might have other cases that do modprobe in scripts and
run into the same issue you are trying to solve. :)

thanks,
-- Shuah

  reply	other threads:[~2018-09-05 16:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  2:20 [PATCH] sysctl: kselftests: use kernel module instead of built-in Lei Yang
2018-09-05  2:20 ` Lei Yang
2018-09-05  2:20 ` Lei.Yang
2018-09-05 16:47 ` Shuah Khan [this message]
2018-09-05 16:47   ` Shuah Khan
2018-09-05 16:47   ` shuah
2018-09-06  5:48   ` lei yang
2018-09-06  5:48     ` lei yang
2018-09-06  5:48     ` lei.yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aeffc5f-ed8c-b418-5db3-ef0299456002@kernel.org \
    --to=shuah@kernel.org \
    --cc=Lei.Yang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.