* [PATCH] arm64: Stop printing the virtual memory layout
@ 2017-12-19 19:28 ` Laura Abbott
0 siblings, 0 replies; 16+ messages in thread
From: Laura Abbott @ 2017-12-19 19:28 UTC (permalink / raw)
To: Will Deacon, Mark Rutland, Catalin Marinas
Cc: Laura Abbott, linux-arm-kernel, linux-kernel, Kees Cook, Ard Biesheuvel
Printing kernel addresses should be done in limited circumstances, mostly
for debugging purposes. Printing out the virtual memory layout at every
kernel bootup doesn't really fall into this category so delete the prints.
There are other ways to get the same information.
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
Follow up to my previous proposal to switch all these to %px
---
arch/arm64/mm/init.c | 43 -------------------------------------------
1 file changed, 43 deletions(-)
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index 5960bef0170d..672094ed7e07 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -599,49 +599,6 @@ void __init mem_init(void)
mem_init_print_info(NULL);
-#define MLK(b, t) b, t, ((t) - (b)) >> 10
-#define MLM(b, t) b, t, ((t) - (b)) >> 20
-#define MLG(b, t) b, t, ((t) - (b)) >> 30
-#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
-
- pr_notice("Virtual kernel memory layout:\n");
-#ifdef CONFIG_KASAN
- pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
- MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
-#endif
- pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
- MLM(MODULES_VADDR, MODULES_END));
- pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
- MLG(VMALLOC_START, VMALLOC_END));
- pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(_text, _etext));
- pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(__start_rodata, __init_begin));
- pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(__init_begin, __init_end));
- pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(_sdata, _edata));
- pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(__bss_start, __bss_stop));
- pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
- MLK(FIXADDR_START, FIXADDR_TOP));
- pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
- MLM(PCI_IO_START, PCI_IO_END));
-#ifdef CONFIG_SPARSEMEM_VMEMMAP
- pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
- MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
- pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
- MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
- (unsigned long)virt_to_page(high_memory)));
-#endif
- pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
- MLM(__phys_to_virt(memblock_start_of_DRAM()),
- (unsigned long)high_memory));
-
-#undef MLK
-#undef MLM
-#undef MLK_ROUNDUP
-
/*
* Check boundaries twice: Some fundamental inconsistencies can be
* detected at build time already.
--
2.14.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2017-12-19 19:28 ` Laura Abbott
0 siblings, 0 replies; 16+ messages in thread
From: Laura Abbott @ 2017-12-19 19:28 UTC (permalink / raw)
To: linux-arm-kernel
Printing kernel addresses should be done in limited circumstances, mostly
for debugging purposes. Printing out the virtual memory layout at every
kernel bootup doesn't really fall into this category so delete the prints.
There are other ways to get the same information.
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
Follow up to my previous proposal to switch all these to %px
---
arch/arm64/mm/init.c | 43 -------------------------------------------
1 file changed, 43 deletions(-)
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index 5960bef0170d..672094ed7e07 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -599,49 +599,6 @@ void __init mem_init(void)
mem_init_print_info(NULL);
-#define MLK(b, t) b, t, ((t) - (b)) >> 10
-#define MLM(b, t) b, t, ((t) - (b)) >> 20
-#define MLG(b, t) b, t, ((t) - (b)) >> 30
-#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
-
- pr_notice("Virtual kernel memory layout:\n");
-#ifdef CONFIG_KASAN
- pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
- MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
-#endif
- pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
- MLM(MODULES_VADDR, MODULES_END));
- pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
- MLG(VMALLOC_START, VMALLOC_END));
- pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(_text, _etext));
- pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(__start_rodata, __init_begin));
- pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(__init_begin, __init_end));
- pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(_sdata, _edata));
- pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
- MLK_ROUNDUP(__bss_start, __bss_stop));
- pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
- MLK(FIXADDR_START, FIXADDR_TOP));
- pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
- MLM(PCI_IO_START, PCI_IO_END));
-#ifdef CONFIG_SPARSEMEM_VMEMMAP
- pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
- MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
- pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
- MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
- (unsigned long)virt_to_page(high_memory)));
-#endif
- pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
- MLM(__phys_to_virt(memblock_start_of_DRAM()),
- (unsigned long)high_memory));
-
-#undef MLK
-#undef MLM
-#undef MLK_ROUNDUP
-
/*
* Check boundaries twice: Some fundamental inconsistencies can be
* detected at build time already.
--
2.14.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2017-12-19 19:28 ` Laura Abbott
@ 2017-12-19 21:04 ` Kees Cook
-1 siblings, 0 replies; 16+ messages in thread
From: Kees Cook @ 2017-12-19 21:04 UTC (permalink / raw)
To: Laura Abbott
Cc: Will Deacon, Mark Rutland, Catalin Marinas, linux-arm-kernel,
LKML, Ard Biesheuvel
On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
> Printing kernel addresses should be done in limited circumstances, mostly
> for debugging purposes. Printing out the virtual memory layout at every
> kernel bootup doesn't really fall into this category so delete the prints.
> There are other ways to get the same information.
In looking at this patch, I wonder: is there anything listed here that
is _missing_ from CONFIG_PTDUMP? I would expect all of these to
already be listed there, but I thought I'd ask...
Regardless:
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Follow up to my previous proposal to switch all these to %px
> ---
> arch/arm64/mm/init.c | 43 -------------------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5960bef0170d..672094ed7e07 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -599,49 +599,6 @@ void __init mem_init(void)
>
> mem_init_print_info(NULL);
>
> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
> -
> - pr_notice("Virtual kernel memory layout:\n");
> -#ifdef CONFIG_KASAN
> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
> -#endif
> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(MODULES_VADDR, MODULES_END));
> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(VMALLOC_START, VMALLOC_END));
> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_text, _etext));
> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__start_rodata, __init_begin));
> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__init_begin, __init_end));
> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_sdata, _edata));
> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__bss_start, __bss_stop));
> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
> - MLK(FIXADDR_START, FIXADDR_TOP));
> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(PCI_IO_START, PCI_IO_END));
> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
> - (unsigned long)virt_to_page(high_memory)));
> -#endif
> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
> - (unsigned long)high_memory));
> -
> -#undef MLK
> -#undef MLM
> -#undef MLK_ROUNDUP
> -
> /*
> * Check boundaries twice: Some fundamental inconsistencies can be
> * detected at build time already.
> --
> 2.14.3
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2017-12-19 21:04 ` Kees Cook
0 siblings, 0 replies; 16+ messages in thread
From: Kees Cook @ 2017-12-19 21:04 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
> Printing kernel addresses should be done in limited circumstances, mostly
> for debugging purposes. Printing out the virtual memory layout at every
> kernel bootup doesn't really fall into this category so delete the prints.
> There are other ways to get the same information.
In looking at this patch, I wonder: is there anything listed here that
is _missing_ from CONFIG_PTDUMP? I would expect all of these to
already be listed there, but I thought I'd ask...
Regardless:
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Follow up to my previous proposal to switch all these to %px
> ---
> arch/arm64/mm/init.c | 43 -------------------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5960bef0170d..672094ed7e07 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -599,49 +599,6 @@ void __init mem_init(void)
>
> mem_init_print_info(NULL);
>
> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
> -
> - pr_notice("Virtual kernel memory layout:\n");
> -#ifdef CONFIG_KASAN
> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
> -#endif
> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(MODULES_VADDR, MODULES_END));
> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(VMALLOC_START, VMALLOC_END));
> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_text, _etext));
> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__start_rodata, __init_begin));
> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__init_begin, __init_end));
> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_sdata, _edata));
> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__bss_start, __bss_stop));
> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
> - MLK(FIXADDR_START, FIXADDR_TOP));
> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(PCI_IO_START, PCI_IO_END));
> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
> - (unsigned long)virt_to_page(high_memory)));
> -#endif
> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
> - (unsigned long)high_memory));
> -
> -#undef MLK
> -#undef MLM
> -#undef MLK_ROUNDUP
> -
> /*
> * Check boundaries twice: Some fundamental inconsistencies can be
> * detected at build time already.
> --
> 2.14.3
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2017-12-19 21:04 ` Kees Cook
@ 2017-12-19 22:18 ` Laura Abbott
-1 siblings, 0 replies; 16+ messages in thread
From: Laura Abbott @ 2017-12-19 22:18 UTC (permalink / raw)
To: Kees Cook
Cc: Will Deacon, Mark Rutland, Catalin Marinas, linux-arm-kernel,
LKML, Ard Biesheuvel
On 12/19/2017 01:04 PM, Kees Cook wrote:
> On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
>> Printing kernel addresses should be done in limited circumstances, mostly
>> for debugging purposes. Printing out the virtual memory layout at every
>> kernel bootup doesn't really fall into this category so delete the prints.
>> There are other ways to get the same information.
>
> In looking at this patch, I wonder: is there anything listed here that
> is _missing_ from CONFIG_PTDUMP? I would expect all of these to
> already be listed there, but I thought I'd ask...
>
It doesn't print the .text etc. but those can be calculated other ways.
> Regardless:
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> -Kees
>
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>> Follow up to my previous proposal to switch all these to %px
>> ---
>> arch/arm64/mm/init.c | 43 -------------------------------------------
>> 1 file changed, 43 deletions(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 5960bef0170d..672094ed7e07 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -599,49 +599,6 @@ void __init mem_init(void)
>>
>> mem_init_print_info(NULL);
>>
>> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
>> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
>> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
>> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
>> -
>> - pr_notice("Virtual kernel memory layout:\n");
>> -#ifdef CONFIG_KASAN
>> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
>> -#endif
>> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(MODULES_VADDR, MODULES_END));
>> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(VMALLOC_START, VMALLOC_END));
>> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_text, _etext));
>> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__start_rodata, __init_begin));
>> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__init_begin, __init_end));
>> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_sdata, _edata));
>> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__bss_start, __bss_stop));
>> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
>> - MLK(FIXADDR_START, FIXADDR_TOP));
>> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(PCI_IO_START, PCI_IO_END));
>> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
>> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
>> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
>> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
>> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
>> - (unsigned long)virt_to_page(high_memory)));
>> -#endif
>> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
>> - (unsigned long)high_memory));
>> -
>> -#undef MLK
>> -#undef MLM
>> -#undef MLK_ROUNDUP
>> -
>> /*
>> * Check boundaries twice: Some fundamental inconsistencies can be
>> * detected at build time already.
>> --
>> 2.14.3
>>
>
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2017-12-19 22:18 ` Laura Abbott
0 siblings, 0 replies; 16+ messages in thread
From: Laura Abbott @ 2017-12-19 22:18 UTC (permalink / raw)
To: linux-arm-kernel
On 12/19/2017 01:04 PM, Kees Cook wrote:
> On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
>> Printing kernel addresses should be done in limited circumstances, mostly
>> for debugging purposes. Printing out the virtual memory layout at every
>> kernel bootup doesn't really fall into this category so delete the prints.
>> There are other ways to get the same information.
>
> In looking at this patch, I wonder: is there anything listed here that
> is _missing_ from CONFIG_PTDUMP? I would expect all of these to
> already be listed there, but I thought I'd ask...
>
It doesn't print the .text etc. but those can be calculated other ways.
> Regardless:
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> -Kees
>
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>> Follow up to my previous proposal to switch all these to %px
>> ---
>> arch/arm64/mm/init.c | 43 -------------------------------------------
>> 1 file changed, 43 deletions(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 5960bef0170d..672094ed7e07 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -599,49 +599,6 @@ void __init mem_init(void)
>>
>> mem_init_print_info(NULL);
>>
>> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
>> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
>> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
>> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
>> -
>> - pr_notice("Virtual kernel memory layout:\n");
>> -#ifdef CONFIG_KASAN
>> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
>> -#endif
>> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(MODULES_VADDR, MODULES_END));
>> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(VMALLOC_START, VMALLOC_END));
>> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_text, _etext));
>> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__start_rodata, __init_begin));
>> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__init_begin, __init_end));
>> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_sdata, _edata));
>> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__bss_start, __bss_stop));
>> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
>> - MLK(FIXADDR_START, FIXADDR_TOP));
>> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(PCI_IO_START, PCI_IO_END));
>> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
>> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
>> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
>> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
>> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
>> - (unsigned long)virt_to_page(high_memory)));
>> -#endif
>> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
>> - (unsigned long)high_memory));
>> -
>> -#undef MLK
>> -#undef MLM
>> -#undef MLK_ROUNDUP
>> -
>> /*
>> * Check boundaries twice: Some fundamental inconsistencies can be
>> * detected at build time already.
>> --
>> 2.14.3
>>
>
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2017-12-19 21:04 ` Kees Cook
@ 2018-01-09 23:02 ` Kees Cook
-1 siblings, 0 replies; 16+ messages in thread
From: Kees Cook @ 2018-01-09 23:02 UTC (permalink / raw)
To: Laura Abbott, Catalin Marinas
Cc: Will Deacon, Mark Rutland, linux-arm-kernel, LKML, Ard Biesheuvel
On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook <keescook@chromium.org> wrote:
> On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
>> Printing kernel addresses should be done in limited circumstances, mostly
>> for debugging purposes. Printing out the virtual memory layout at every
>> kernel bootup doesn't really fall into this category so delete the prints.
>> There are other ways to get the same information.
>
> In looking at this patch, I wonder: is there anything listed here that
> is _missing_ from CONFIG_PTDUMP? I would expect all of these to
> already be listed there, but I thought I'd ask...
>
> Regardless:
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> -Kees
>
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
Did this patch get picked up? I don't see it in -next.
-Kees
>> ---
>> Follow up to my previous proposal to switch all these to %px
>> ---
>> arch/arm64/mm/init.c | 43 -------------------------------------------
>> 1 file changed, 43 deletions(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 5960bef0170d..672094ed7e07 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -599,49 +599,6 @@ void __init mem_init(void)
>>
>> mem_init_print_info(NULL);
>>
>> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
>> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
>> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
>> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
>> -
>> - pr_notice("Virtual kernel memory layout:\n");
>> -#ifdef CONFIG_KASAN
>> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
>> -#endif
>> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(MODULES_VADDR, MODULES_END));
>> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(VMALLOC_START, VMALLOC_END));
>> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_text, _etext));
>> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__start_rodata, __init_begin));
>> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__init_begin, __init_end));
>> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_sdata, _edata));
>> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__bss_start, __bss_stop));
>> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
>> - MLK(FIXADDR_START, FIXADDR_TOP));
>> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(PCI_IO_START, PCI_IO_END));
>> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
>> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
>> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
>> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
>> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
>> - (unsigned long)virt_to_page(high_memory)));
>> -#endif
>> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
>> - (unsigned long)high_memory));
>> -
>> -#undef MLK
>> -#undef MLM
>> -#undef MLK_ROUNDUP
>> -
>> /*
>> * Check boundaries twice: Some fundamental inconsistencies can be
>> * detected at build time already.
>> --
>> 2.14.3
>>
>
>
>
> --
> Kees Cook
> Pixel Security
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2018-01-09 23:02 ` Kees Cook
0 siblings, 0 replies; 16+ messages in thread
From: Kees Cook @ 2018-01-09 23:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook <keescook@chromium.org> wrote:
> On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
>> Printing kernel addresses should be done in limited circumstances, mostly
>> for debugging purposes. Printing out the virtual memory layout at every
>> kernel bootup doesn't really fall into this category so delete the prints.
>> There are other ways to get the same information.
>
> In looking at this patch, I wonder: is there anything listed here that
> is _missing_ from CONFIG_PTDUMP? I would expect all of these to
> already be listed there, but I thought I'd ask...
>
> Regardless:
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> -Kees
>
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
Did this patch get picked up? I don't see it in -next.
-Kees
>> ---
>> Follow up to my previous proposal to switch all these to %px
>> ---
>> arch/arm64/mm/init.c | 43 -------------------------------------------
>> 1 file changed, 43 deletions(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 5960bef0170d..672094ed7e07 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -599,49 +599,6 @@ void __init mem_init(void)
>>
>> mem_init_print_info(NULL);
>>
>> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
>> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
>> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
>> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
>> -
>> - pr_notice("Virtual kernel memory layout:\n");
>> -#ifdef CONFIG_KASAN
>> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
>> -#endif
>> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(MODULES_VADDR, MODULES_END));
>> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
>> - MLG(VMALLOC_START, VMALLOC_END));
>> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_text, _etext));
>> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__start_rodata, __init_begin));
>> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__init_begin, __init_end));
>> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(_sdata, _edata));
>> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
>> - MLK_ROUNDUP(__bss_start, __bss_stop));
>> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
>> - MLK(FIXADDR_START, FIXADDR_TOP));
>> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(PCI_IO_START, PCI_IO_END));
>> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
>> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
>> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
>> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
>> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
>> - (unsigned long)virt_to_page(high_memory)));
>> -#endif
>> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
>> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
>> - (unsigned long)high_memory));
>> -
>> -#undef MLK
>> -#undef MLM
>> -#undef MLK_ROUNDUP
>> -
>> /*
>> * Check boundaries twice: Some fundamental inconsistencies can be
>> * detected at build time already.
>> --
>> 2.14.3
>>
>
>
>
> --
> Kees Cook
> Pixel Security
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2018-01-09 23:02 ` Kees Cook
@ 2018-01-15 18:18 ` Catalin Marinas
-1 siblings, 0 replies; 16+ messages in thread
From: Catalin Marinas @ 2018-01-15 18:18 UTC (permalink / raw)
To: Kees Cook
Cc: Laura Abbott, Mark Rutland, Will Deacon, LKML, linux-arm-kernel,
Ard Biesheuvel
On Tue, Jan 09, 2018 at 03:02:12PM -0800, Kees Cook wrote:
> On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook <keescook@chromium.org> wrote:
> > On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
> >> Printing kernel addresses should be done in limited circumstances, mostly
> >> for debugging purposes. Printing out the virtual memory layout at every
> >> kernel bootup doesn't really fall into this category so delete the prints.
> >> There are other ways to get the same information.
> >
> > In looking at this patch, I wonder: is there anything listed here that
> > is _missing_ from CONFIG_PTDUMP? I would expect all of these to
> > already be listed there, but I thought I'd ask...
> >
> > Regardless:
> >
> > Acked-by: Kees Cook <keescook@chromium.org>
> >
> > -Kees
> >
> >>
> >> Signed-off-by: Laura Abbott <labbott@redhat.com>
>
> Did this patch get picked up? I don't see it in -next.
I queued it now, should appear soon.
Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2018-01-15 18:18 ` Catalin Marinas
0 siblings, 0 replies; 16+ messages in thread
From: Catalin Marinas @ 2018-01-15 18:18 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 09, 2018 at 03:02:12PM -0800, Kees Cook wrote:
> On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook <keescook@chromium.org> wrote:
> > On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
> >> Printing kernel addresses should be done in limited circumstances, mostly
> >> for debugging purposes. Printing out the virtual memory layout at every
> >> kernel bootup doesn't really fall into this category so delete the prints.
> >> There are other ways to get the same information.
> >
> > In looking at this patch, I wonder: is there anything listed here that
> > is _missing_ from CONFIG_PTDUMP? I would expect all of these to
> > already be listed there, but I thought I'd ask...
> >
> > Regardless:
> >
> > Acked-by: Kees Cook <keescook@chromium.org>
> >
> > -Kees
> >
> >>
> >> Signed-off-by: Laura Abbott <labbott@redhat.com>
>
> Did this patch get picked up? I don't see it in -next.
I queued it now, should appear soon.
Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2018-01-15 18:18 ` Catalin Marinas
@ 2018-01-15 20:00 ` Kees Cook
-1 siblings, 0 replies; 16+ messages in thread
From: Kees Cook @ 2018-01-15 20:00 UTC (permalink / raw)
To: Catalin Marinas
Cc: Laura Abbott, Mark Rutland, Will Deacon, LKML, linux-arm-kernel,
Ard Biesheuvel
On Mon, Jan 15, 2018 at 10:18 AM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> On Tue, Jan 09, 2018 at 03:02:12PM -0800, Kees Cook wrote:
>> On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook <keescook@chromium.org> wrote:
>> > On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
>> >> Printing kernel addresses should be done in limited circumstances, mostly
>> >> for debugging purposes. Printing out the virtual memory layout at every
>> >> kernel bootup doesn't really fall into this category so delete the prints.
>> >> There are other ways to get the same information.
>> >
>> > In looking at this patch, I wonder: is there anything listed here that
>> > is _missing_ from CONFIG_PTDUMP? I would expect all of these to
>> > already be listed there, but I thought I'd ask...
>> >
>> > Regardless:
>> >
>> > Acked-by: Kees Cook <keescook@chromium.org>
>> >
>> > -Kees
>> >
>> >>
>> >> Signed-off-by: Laura Abbott <labbott@redhat.com>
>>
>> Did this patch get picked up? I don't see it in -next.
>
> I queued it now, should appear soon.
Great, thanks!
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2018-01-15 20:00 ` Kees Cook
0 siblings, 0 replies; 16+ messages in thread
From: Kees Cook @ 2018-01-15 20:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 15, 2018 at 10:18 AM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> On Tue, Jan 09, 2018 at 03:02:12PM -0800, Kees Cook wrote:
>> On Tue, Dec 19, 2017 at 1:04 PM, Kees Cook <keescook@chromium.org> wrote:
>> > On Tue, Dec 19, 2017 at 11:28 AM, Laura Abbott <labbott@redhat.com> wrote:
>> >> Printing kernel addresses should be done in limited circumstances, mostly
>> >> for debugging purposes. Printing out the virtual memory layout at every
>> >> kernel bootup doesn't really fall into this category so delete the prints.
>> >> There are other ways to get the same information.
>> >
>> > In looking at this patch, I wonder: is there anything listed here that
>> > is _missing_ from CONFIG_PTDUMP? I would expect all of these to
>> > already be listed there, but I thought I'd ask...
>> >
>> > Regardless:
>> >
>> > Acked-by: Kees Cook <keescook@chromium.org>
>> >
>> > -Kees
>> >
>> >>
>> >> Signed-off-by: Laura Abbott <labbott@redhat.com>
>>
>> Did this patch get picked up? I don't see it in -next.
>
> I queued it now, should appear soon.
Great, thanks!
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2017-12-19 19:28 ` Laura Abbott
@ 2018-01-18 20:01 ` Florian Fainelli
-1 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2018-01-18 20:01 UTC (permalink / raw)
To: Laura Abbott, Will Deacon, Mark Rutland, Catalin Marinas
Cc: linux-arm-kernel, linux-kernel, Kees Cook, Ard Biesheuvel
On 12/19/2017 11:28 AM, Laura Abbott wrote:
> Printing kernel addresses should be done in limited circumstances, mostly
> for debugging purposes. Printing out the virtual memory layout at every
> kernel bootup doesn't really fall into this category so delete the prints.
> There are other ways to get the same information.
This really has some value when debugging systems, could we possibly
just hide that behind an appropriate configuration option instead of
completely removing this?
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Follow up to my previous proposal to switch all these to %px
> ---
> arch/arm64/mm/init.c | 43 -------------------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5960bef0170d..672094ed7e07 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -599,49 +599,6 @@ void __init mem_init(void)
>
> mem_init_print_info(NULL);
>
> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
> -
> - pr_notice("Virtual kernel memory layout:\n");
> -#ifdef CONFIG_KASAN
> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
> -#endif
> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(MODULES_VADDR, MODULES_END));
> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(VMALLOC_START, VMALLOC_END));
> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_text, _etext));
> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__start_rodata, __init_begin));
> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__init_begin, __init_end));
> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_sdata, _edata));
> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__bss_start, __bss_stop));
> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
> - MLK(FIXADDR_START, FIXADDR_TOP));
> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(PCI_IO_START, PCI_IO_END));
> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
> - (unsigned long)virt_to_page(high_memory)));
> -#endif
> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
> - (unsigned long)high_memory));
> -
> -#undef MLK
> -#undef MLM
> -#undef MLK_ROUNDUP
> -
> /*
> * Check boundaries twice: Some fundamental inconsistencies can be
> * detected at build time already.
>
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2018-01-18 20:01 ` Florian Fainelli
0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2018-01-18 20:01 UTC (permalink / raw)
To: linux-arm-kernel
On 12/19/2017 11:28 AM, Laura Abbott wrote:
> Printing kernel addresses should be done in limited circumstances, mostly
> for debugging purposes. Printing out the virtual memory layout at every
> kernel bootup doesn't really fall into this category so delete the prints.
> There are other ways to get the same information.
This really has some value when debugging systems, could we possibly
just hide that behind an appropriate configuration option instead of
completely removing this?
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Follow up to my previous proposal to switch all these to %px
> ---
> arch/arm64/mm/init.c | 43 -------------------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5960bef0170d..672094ed7e07 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -599,49 +599,6 @@ void __init mem_init(void)
>
> mem_init_print_info(NULL);
>
> -#define MLK(b, t) b, t, ((t) - (b)) >> 10
> -#define MLM(b, t) b, t, ((t) - (b)) >> 20
> -#define MLG(b, t) b, t, ((t) - (b)) >> 30
> -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K)
> -
> - pr_notice("Virtual kernel memory layout:\n");
> -#ifdef CONFIG_KASAN
> - pr_notice(" kasan : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(KASAN_SHADOW_START, KASAN_SHADOW_END));
> -#endif
> - pr_notice(" modules : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(MODULES_VADDR, MODULES_END));
> - pr_notice(" vmalloc : 0x%16lx - 0x%16lx (%6ld GB)\n",
> - MLG(VMALLOC_START, VMALLOC_END));
> - pr_notice(" .text : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_text, _etext));
> - pr_notice(" .rodata : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__start_rodata, __init_begin));
> - pr_notice(" .init : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__init_begin, __init_end));
> - pr_notice(" .data : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(_sdata, _edata));
> - pr_notice(" .bss : 0x%p" " - 0x%p" " (%6ld KB)\n",
> - MLK_ROUNDUP(__bss_start, __bss_stop));
> - pr_notice(" fixed : 0x%16lx - 0x%16lx (%6ld KB)\n",
> - MLK(FIXADDR_START, FIXADDR_TOP));
> - pr_notice(" PCI I/O : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(PCI_IO_START, PCI_IO_END));
> -#ifdef CONFIG_SPARSEMEM_VMEMMAP
> - pr_notice(" vmemmap : 0x%16lx - 0x%16lx (%6ld GB maximum)\n",
> - MLG(VMEMMAP_START, VMEMMAP_START + VMEMMAP_SIZE));
> - pr_notice(" 0x%16lx - 0x%16lx (%6ld MB actual)\n",
> - MLM((unsigned long)phys_to_page(memblock_start_of_DRAM()),
> - (unsigned long)virt_to_page(high_memory)));
> -#endif
> - pr_notice(" memory : 0x%16lx - 0x%16lx (%6ld MB)\n",
> - MLM(__phys_to_virt(memblock_start_of_DRAM()),
> - (unsigned long)high_memory));
> -
> -#undef MLK
> -#undef MLM
> -#undef MLK_ROUNDUP
> -
> /*
> * Check boundaries twice: Some fundamental inconsistencies can be
> * detected at build time already.
>
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: Stop printing the virtual memory layout
2018-01-18 20:01 ` Florian Fainelli
@ 2018-01-18 20:20 ` Russell King - ARM Linux
-1 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2018-01-18 20:20 UTC (permalink / raw)
To: Florian Fainelli
Cc: Laura Abbott, Will Deacon, Mark Rutland, Catalin Marinas,
Ard Biesheuvel, linux-kernel, linux-arm-kernel, Kees Cook
On Thu, Jan 18, 2018 at 12:01:31PM -0800, Florian Fainelli wrote:
> On 12/19/2017 11:28 AM, Laura Abbott wrote:
> > Printing kernel addresses should be done in limited circumstances, mostly
> > for debugging purposes. Printing out the virtual memory layout at every
> > kernel bootup doesn't really fall into this category so delete the prints.
> > There are other ways to get the same information.
>
> This really has some value when debugging systems, could we possibly
> just hide that behind an appropriate configuration option instead of
> completely removing this?
I've already ended up having to revert the vsprintf() change nobbling
%p for that very reason when debugging the BPF code. It's easier to
do that while debugging than remember about the %px thing - and lets
face it, probably less error prone if it leaks out.
Otherwise we'll just end up with everyone spelling %p as %px in their
debug statements... or using %lx and casting to unsigned long.
So yes, I do think a Kconfig option (defaulting to obscuring kernel
addresses of course) would have been very sensible for this.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] arm64: Stop printing the virtual memory layout
@ 2018-01-18 20:20 ` Russell King - ARM Linux
0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2018-01-18 20:20 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 18, 2018 at 12:01:31PM -0800, Florian Fainelli wrote:
> On 12/19/2017 11:28 AM, Laura Abbott wrote:
> > Printing kernel addresses should be done in limited circumstances, mostly
> > for debugging purposes. Printing out the virtual memory layout at every
> > kernel bootup doesn't really fall into this category so delete the prints.
> > There are other ways to get the same information.
>
> This really has some value when debugging systems, could we possibly
> just hide that behind an appropriate configuration option instead of
> completely removing this?
I've already ended up having to revert the vsprintf() change nobbling
%p for that very reason when debugging the BPF code. It's easier to
do that while debugging than remember about the %px thing - and lets
face it, probably less error prone if it leaks out.
Otherwise we'll just end up with everyone spelling %p as %px in their
debug statements... or using %lx and casting to unsigned long.
So yes, I do think a Kconfig option (defaulting to obscuring kernel
addresses of course) would have been very sensible for this.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2018-01-18 20:21 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 19:28 [PATCH] arm64: Stop printing the virtual memory layout Laura Abbott
2017-12-19 19:28 ` Laura Abbott
2017-12-19 21:04 ` Kees Cook
2017-12-19 21:04 ` Kees Cook
2017-12-19 22:18 ` Laura Abbott
2017-12-19 22:18 ` Laura Abbott
2018-01-09 23:02 ` Kees Cook
2018-01-09 23:02 ` Kees Cook
2018-01-15 18:18 ` Catalin Marinas
2018-01-15 18:18 ` Catalin Marinas
2018-01-15 20:00 ` Kees Cook
2018-01-15 20:00 ` Kees Cook
2018-01-18 20:01 ` Florian Fainelli
2018-01-18 20:01 ` Florian Fainelli
2018-01-18 20:20 ` Russell King - ARM Linux
2018-01-18 20:20 ` Russell King - ARM Linux
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.