All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff
Date: Wed, 22 Apr 2020 15:35:06 +0200	[thread overview]
Message-ID: <8b72369a-482c-a32f-648d-050c22dadf2e@redhat.com> (raw)
In-Reply-To: <20200422130719.28225-13-armbru@redhat.com>

Hi Markus,

On 4/22/20 3:07 PM, Markus Armbruster wrote:
> Fixes: 58e19e6e7914354242a67442d0006f9e31684d1a
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   tests/test-logging.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-logging.c b/tests/test-logging.c
> index 6387e4933f..8580b82420 100644
> --- a/tests/test-logging.c
> +++ b/tests/test-logging.c
> @@ -73,10 +73,10 @@ static void test_parse_range(void)
>       g_assert(qemu_log_in_addr_range(UINT64_MAX));
>       g_assert_false(qemu_log_in_addr_range(UINT64_MAX - 1));
>   
> -    qemu_set_dfilter_ranges("0..0xffffffffffffffff", &err);
> +    qemu_set_dfilter_ranges("0..0xffffffffffffffff", &error_abort);

Why sometime use this form, ...

>       g_assert(qemu_log_in_addr_range(0));
>       g_assert(qemu_log_in_addr_range(UINT64_MAX));
> -
> +
>       qemu_set_dfilter_ranges("2..1", &err);
>       error_free_or_abort(&err);

... and then this other form?

>   
> 



  reply	other threads:[~2020-04-22 13:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 13:07 [PATCH v2 00/14] Miscellaneous error handling fixes Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 01/14] cryptodev: Fix cryptodev_builtin_cleanup() error API violation Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 02/14] block/file-posix: Fix check_cache_dropped() error handling Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 03/14] cpus: Fix configure_icount() error API violation Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 04/14] cpus: Proper range-checking for -icount shift=N Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 05/14] arm/virt: Fix virt_machine_device_plug_cb() error API violation Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 06/14] fdc: Fix fallback=auto error handling Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 07/14] bochs-display: Fix vgamem=SIZE " Markus Armbruster
2020-04-23 11:30   ` Gerd Hoffmann
2020-04-22 13:07 ` [PATCH v2 08/14] virtio-net: Fix duplex=... and speed=... " Markus Armbruster
2020-04-22 14:24   ` Michael S. Tsirkin
2020-04-22 13:07 ` [PATCH v2 09/14] xen/pt: Fix flawed conversion to realize() Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 10/14] io: Fix qio_channel_socket_close() error handling Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 11/14] migration/colo: Fix qmp_xen_colo_do_checkpoint() " Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff Markus Armbruster
2020-04-22 13:35   ` Philippe Mathieu-Daudé [this message]
2020-04-22 14:49     ` Eric Blake
2020-04-22 16:28       ` Philippe Mathieu-Daudé
2020-04-22 15:19     ` Markus Armbruster
2020-04-22 16:30       ` Philippe Mathieu-Daudé
2020-04-22 13:07 ` [PATCH v2 13/14] qga: Fix qmp_guest_get_memory_blocks() error handling Markus Armbruster
2020-04-22 13:14   ` Eric Blake
2020-04-22 13:07 ` [PATCH v2 14/14] qga: Fix qmp_guest_suspend_{disk, ram}() " Markus Armbruster
2020-04-22 13:19   ` Eric Blake
2020-04-22 13:41   ` Philippe Mathieu-Daudé
2020-04-22 15:17     ` Markus Armbruster
2020-04-22 16:07       ` Philippe Mathieu-Daudé
2020-04-23  8:35         ` Markus Armbruster
2020-04-22 20:21 ` [PATCH v2 00/14] Miscellaneous error handling fixes no-reply
2020-04-29  7:14 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b72369a-482c-a32f-648d-050c22dadf2e@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.