All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 14/14] qga: Fix qmp_guest_suspend_{disk, ram}() error handling
Date: Wed, 22 Apr 2020 08:19:09 -0500	[thread overview]
Message-ID: <bc42cda9-fb61-c12f-c64f-b2c358c60519@redhat.com> (raw)
In-Reply-To: <20200422130719.28225-15-armbru@redhat.com>

On 4/22/20 8:07 AM, Markus Armbruster wrote:
> The Error ** argument must be NULL, &error_abort, &error_fatal, or a
> pointer to a variable containing NULL.  Passing an argument of the
> latter kind twice without clearing it in between is wrong: if the
> first call sets an error, it no longer points to NULL for the second
> 
> qmp_guest_suspend_disk() and qmp_guest_suspend_ram() pass @local_err
> first to check_suspend_mode(), then to acquire_privilege(), then to
> execute_async().  Continuing after errors here can only end in tears.
> For instance, we risk tripping error_setv()'s assertion.
> 
> Fixes: aa59637ea1c6a4c83430933f9c44c43e6c3f1b69
> Fixes: f54603b6aa765514b2519e74114a2f417759d727
> Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   qga/commands-win32.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2020-04-22 13:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 13:07 [PATCH v2 00/14] Miscellaneous error handling fixes Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 01/14] cryptodev: Fix cryptodev_builtin_cleanup() error API violation Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 02/14] block/file-posix: Fix check_cache_dropped() error handling Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 03/14] cpus: Fix configure_icount() error API violation Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 04/14] cpus: Proper range-checking for -icount shift=N Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 05/14] arm/virt: Fix virt_machine_device_plug_cb() error API violation Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 06/14] fdc: Fix fallback=auto error handling Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 07/14] bochs-display: Fix vgamem=SIZE " Markus Armbruster
2020-04-23 11:30   ` Gerd Hoffmann
2020-04-22 13:07 ` [PATCH v2 08/14] virtio-net: Fix duplex=... and speed=... " Markus Armbruster
2020-04-22 14:24   ` Michael S. Tsirkin
2020-04-22 13:07 ` [PATCH v2 09/14] xen/pt: Fix flawed conversion to realize() Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 10/14] io: Fix qio_channel_socket_close() error handling Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 11/14] migration/colo: Fix qmp_xen_colo_do_checkpoint() " Markus Armbruster
2020-04-22 13:07 ` [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff Markus Armbruster
2020-04-22 13:35   ` Philippe Mathieu-Daudé
2020-04-22 14:49     ` Eric Blake
2020-04-22 16:28       ` Philippe Mathieu-Daudé
2020-04-22 15:19     ` Markus Armbruster
2020-04-22 16:30       ` Philippe Mathieu-Daudé
2020-04-22 13:07 ` [PATCH v2 13/14] qga: Fix qmp_guest_get_memory_blocks() error handling Markus Armbruster
2020-04-22 13:14   ` Eric Blake
2020-04-22 13:07 ` [PATCH v2 14/14] qga: Fix qmp_guest_suspend_{disk, ram}() " Markus Armbruster
2020-04-22 13:19   ` Eric Blake [this message]
2020-04-22 13:41   ` Philippe Mathieu-Daudé
2020-04-22 15:17     ` Markus Armbruster
2020-04-22 16:07       ` Philippe Mathieu-Daudé
2020-04-23  8:35         ` Markus Armbruster
2020-04-22 20:21 ` [PATCH v2 00/14] Miscellaneous error handling fixes no-reply
2020-04-29  7:14 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc42cda9-fb61-c12f-c64f-b2c358c60519@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.