Re: [PATCH 1/2] lttng-tools ptest: add missing dependencies

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2019-03-12 at 21:13 +0000, Jonathan Rajotte wrote:
> Multiple tests are failing due to missing dependencies on a bare
> core-image-minimal build with only lttng-tools ptest present.
> 
> "getconf LONG_BIT" is used to get the bitness of the host to run the
> correct consumerd. Depend on glibc-utils.
> 
> perl-module-overloading is needed to validate trace. babelstats.pl
> 
> "head -c" is used to generate a random string. It is easier to
> depends
> on coreutils to get a feature complete "head" than to enable to
> "fancy
> head" feature of busybox. See utils.sh randstring.
> 
> "taskset" is used in a couple of scripts to ensure that events
> generated
> finish in the same buffer. Depend on util-linux.
> 
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com
> >
> ---
> 
> I also submitted the following patches [1] [2] to lttng upstream. It
> should help get the ptest sucess ratio up when they are merged. They
> should be released in the upcoming month.
> 
> [1] 
> https://lists.lttng.org/pipermail/lttng-dev/2019-March/028573.html
> [2] 
> https://lists.lttng.org/pipermail/lttng-dev/2019-March/028574.html
> 
> ---
>  meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> index 9d21fb00bf..3324959cc3 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>  
>  DEPENDS = "liburcu popt libxml2 util-linux"
>  RDEPENDS_${PN} = "libgcc"
> -RDEPENDS_${PN}-ptest += "make perl bash gawk ${PN} babeltrace procps"
> +RDEPENDS_${PN}-ptest += "make perl bash gawk ${PN} babeltrace procps glibc-utils perl-module-overloading coreutils util-linux"
>  # babelstats.pl wants getopt-long
>  RDEPENDS_${PN}-ptest += "perl-module-getopt-long"

Firstly, I wanted to say thanks for looking at this, there are some
really great fixes in here.

It failed in automated testing as glibc-utils is glibc specific and
musl builds couldn't cope with that.

We can certainly do:

RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"

but I'm not sure what that would mean for lttng on musl or if lttng
ptest on musl even makes sense.

I'm travelling so haven't been able to dig any further so sorry for
being terse but just wanted to give a heads up on this.

Autobuilder failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/396

Cheers,

Richard