Re: [PATCH 1/2] lttng-tools ptest: add missing dependencies

From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] lttng-tools ptest: add missing dependencies
Date: Mon, 18 Mar 2019 12:37:54 +0000	[thread overview]
Message-ID: <e23a55b1a840f9a55ae1bf7aa5037fca2d54fe27.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190315144058.GA6994@joraj-alpa>

On Fri, 2019-03-15 at 10:40 -0400, Jonathan Rajotte-Julien wrote:
> > Firstly, I wanted to say thanks for looking at this, there are some
> > really great fixes in here.
> > 
> > It failed in automated testing as glibc-utils is glibc specific and
> > musl builds couldn't cope with that.
> > 
> > We can certainly do:
> > 
> > RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
> 
> Sure, since we mostly need getconf from glibc-utils, we can use musl-
> utils to provide it when building with musl.
> 
> RDEPENDS_${PN}-ptest_append_libc-musl = " musl-utils"

Thanks for confirmation of that.

Since the patches with a couple of fixes were passing the tests, I've
merged the patches with the glibc/muslc tweak and also a tweak to make
disabled ust work. I'd normally wait for v2 resubmission but I wanted
to get this fix into M3 and the M3 build is already behind schedule.

I was at a conference last week so a bit distracted, just catching up
now.

> Also, I saw that lttng-ust is removed from PACKAGECONFIG when using
> musl, not sure why the commit history is not particularly verbose
> regarding why it was a problem. Still, it seems to build fine but we
> are seeing issue regarding musl.

I think when we originally merged musl, lttng didn't build with it or
there were some kind of issues. I suspect lttng-ust still doesn't work
on all the architectures we build for so we likely need to be able to
optionally disable it. I'd be happy to see patches enabling it where it
does work though.

> We checked with Alpine since they also use musl and see similar
> problem. I'm investigating on that front. I'll let you know what I
> find.
> 
> Side note, gdb simply segfault (at start) for me on a core-image-
> minirmnal build using musl.
> How would someone open the corefile generated on the build system
> with the proper libs and all?

I saw other discussion about this so it looks like you're making
progress on this front. If not, Khem would be the person to ask about
this as our musl expert...

Cheers,

Richard