[PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()

* [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
@ 2018-12-11 23:56 Lyude Paul
  2018-12-12  5:46   ` Sasha Levin
  0 siblings, 1 reply; 4+ messages in thread
From: Lyude Paul @ 2018-12-11 23:56 UTC (permalink / raw)
  To: nouveau
  Cc: dri-devel, stable, Ben Skeggs, David Airlie, Daniel Vetter,
	Sean Paul, Ilia Mirkin, linux-kernel

Noticed this while working on redoing the reference counting scheme in
the DP MST helpers. Nouveau doesn't attempt to call
drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of
the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports.

Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v4.10+
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index d153ea2a08ac..a634b3d0b6a1 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1254,6 +1254,7 @@ nv50_mstm_del(struct nv50_mstm **pmstm)
 {
 	struct nv50_mstm *mstm = *pmstm;
 	if (mstm) {
+		drm_dp_mst_topology_mgr_destroy(&mstm->mgr);
 		kfree(*pmstm);
 		*pmstm = NULL;
 	}
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread