From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> To: Kees Cook <keescook@chromium.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] usb: iowarrior: replace kmalloc with kmalloc_array Date: Thu, 23 Aug 2018 12:51:11 -0500 [thread overview] Message-ID: <8bb74251-7dcd-cafc-0811-4cc55c2b1ce1@embeddedor.com> (raw) In-Reply-To: <CAGXu5jJY71FoVrQBXZ=Vx1O90bL3BoyAVBwugfh4XJL84=my0Q@mail.gmail.com> On 8/23/18 12:43 PM, Kees Cook wrote: > On Thu, Aug 23, 2018 at 10:31 AM, Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> A common flaw in the kernel is integer overflow during memory allocation >> size calculations. In an effort to reduce the frequency of these bugs, >> kmalloc_array was implemented, which allocates memory for an array, >> while at the same time detects integer overflow. >> >> This patch replaces cases of: >> >> kmalloc(a * b, gfp) >> >> with: >> kmalloc_array(a * b, gfp) > > nit: this should be "kmalloc_array(a, b, gfp)" (This was a typo from > my treewide commit message... :P) > Oops... OK. V3 is on the way. :P >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/usb/misc/iowarrior.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c >> index c2991b8..7a22400 100644 >> --- a/drivers/usb/misc/iowarrior.c >> +++ b/drivers/usb/misc/iowarrior.c >> @@ -808,7 +808,7 @@ static int iowarrior_probe(struct usb_interface *interface, >> dev->int_in_endpoint->bInterval); >> /* create an internal buffer for interrupt data from the device */ >> dev->read_queue = >> - kmalloc(((dev->report_size + 1) * MAX_INTERRUPT_BUFFER), >> + kmalloc_array(dev->report_size + 1, MAX_INTERRUPT_BUFFER, >> GFP_KERNEL); > > For this patch with the commit log updated: > > Reviewed-by: Kees Cook <keescook@chromium.org> > Thanks! -- Gustavo
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> To: Kees Cook <keescook@chromium.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: usb: iowarrior: replace kmalloc with kmalloc_array Date: Thu, 23 Aug 2018 12:51:11 -0500 [thread overview] Message-ID: <8bb74251-7dcd-cafc-0811-4cc55c2b1ce1@embeddedor.com> (raw) On 8/23/18 12:43 PM, Kees Cook wrote: > On Thu, Aug 23, 2018 at 10:31 AM, Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> A common flaw in the kernel is integer overflow during memory allocation >> size calculations. In an effort to reduce the frequency of these bugs, >> kmalloc_array was implemented, which allocates memory for an array, >> while at the same time detects integer overflow. >> >> This patch replaces cases of: >> >> kmalloc(a * b, gfp) >> >> with: >> kmalloc_array(a * b, gfp) > > nit: this should be "kmalloc_array(a, b, gfp)" (This was a typo from > my treewide commit message... :P) > Oops... OK. V3 is on the way. :P >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/usb/misc/iowarrior.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c >> index c2991b8..7a22400 100644 >> --- a/drivers/usb/misc/iowarrior.c >> +++ b/drivers/usb/misc/iowarrior.c >> @@ -808,7 +808,7 @@ static int iowarrior_probe(struct usb_interface *interface, >> dev->int_in_endpoint->bInterval); >> /* create an internal buffer for interrupt data from the device */ >> dev->read_queue = >> - kmalloc(((dev->report_size + 1) * MAX_INTERRUPT_BUFFER), >> + kmalloc_array(dev->report_size + 1, MAX_INTERRUPT_BUFFER, >> GFP_KERNEL); > > For this patch with the commit log updated: > > Reviewed-by: Kees Cook <keescook@chromium.org> > Thanks! --- Gustavo
next prev parent reply other threads:[~2018-08-23 17:51 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-23 17:31 [PATCH] usb: iowarrior: replace kmalloc with kmalloc_array Gustavo A. R. Silva 2018-08-23 17:31 ` Gustavo A. R. Silva 2018-08-23 17:42 ` [PATCH] " Gustavo A. R. Silva 2018-08-23 17:42 ` Gustavo A. R. Silva 2018-08-23 17:43 ` [PATCH] " Kees Cook 2018-08-23 17:51 ` Gustavo A. R. Silva [this message] 2018-08-23 17:51 ` Gustavo A. R. Silva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8bb74251-7dcd-cafc-0811-4cc55c2b1ce1@embeddedor.com \ --to=gustavo@embeddedor.com \ --cc=gregkh@linuxfoundation.org \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.