From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Alexander Sverdlin <alexander.sverdlin@gmail.com>, linux-iio@vger.kernel.org Cc: Hartley Sweeten <hsweeten@visionengravers.com>, Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Date: Thu, 15 Dec 2022 09:42:33 +0100 [thread overview] Message-ID: <8bb988fc-54d2-2528-e34f-0097c0654b7d@linaro.org> (raw) In-Reply-To: <20221214222024.951984-1-alexander.sverdlin@gmail.com> On 14/12/2022 23:20, Alexander Sverdlin wrote: > Add device tree bindings for Cirrus Logic EP9301/EP9302 internal SoCs' ADC > block. > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > .../bindings/iio/adc/cirrus,ep9301-adc.yaml | 58 +++++++++++++++++++ > MAINTAINERS | 2 + > 2 files changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml b/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > new file mode 100644 > index 000000000000..d0fd24d1be04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/cirrus,ep9301-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP930x internal ADC > + > +description: | > + Cirrus Logic EP9301/EP9302 SoCs' internal ADC block. > + > + User's manual: > + https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-adc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ep93xx-adc One entry with same name as device is not really useful, so maybe just drop it? > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/cirrus,ep93xx-clock.h> > + soc { > + #address-cells = <1>; > + #size-cells = <1>; I think you do not need the soc node as examples are built with address/size-cells=1 Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Alexander Sverdlin <alexander.sverdlin@gmail.com>, linux-iio@vger.kernel.org Cc: Hartley Sweeten <hsweeten@visionengravers.com>, Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Date: Thu, 15 Dec 2022 09:42:33 +0100 [thread overview] Message-ID: <8bb988fc-54d2-2528-e34f-0097c0654b7d@linaro.org> (raw) In-Reply-To: <20221214222024.951984-1-alexander.sverdlin@gmail.com> On 14/12/2022 23:20, Alexander Sverdlin wrote: > Add device tree bindings for Cirrus Logic EP9301/EP9302 internal SoCs' ADC > block. > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > .../bindings/iio/adc/cirrus,ep9301-adc.yaml | 58 +++++++++++++++++++ > MAINTAINERS | 2 + > 2 files changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml b/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > new file mode 100644 > index 000000000000..d0fd24d1be04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/cirrus,ep9301-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP930x internal ADC > + > +description: | > + Cirrus Logic EP9301/EP9302 SoCs' internal ADC block. > + > + User's manual: > + https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: cirrus,ep9301-adc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ep93xx-adc One entry with same name as device is not really useful, so maybe just drop it? > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/cirrus,ep93xx-clock.h> > + soc { > + #address-cells = <1>; > + #size-cells = <1>; I think you do not need the soc node as examples are built with address/size-cells=1 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-15 8:42 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-14 22:20 [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Alexander Sverdlin 2022-12-14 22:20 ` Alexander Sverdlin 2022-12-14 22:20 ` [PATCH 2/2] iio: adc: ep93xx: Add OF support Alexander Sverdlin 2022-12-14 22:20 ` Alexander Sverdlin 2022-12-15 8:42 ` Krzysztof Kozlowski [this message] 2022-12-15 8:42 ` [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Krzysztof Kozlowski 2022-12-15 13:24 ` Rob Herring 2022-12-15 13:24 ` Rob Herring 2022-12-15 16:18 ` Rob Herring 2022-12-15 16:18 ` Rob Herring 2022-12-15 16:25 ` Alexander Sverdlin 2022-12-15 16:25 ` Alexander Sverdlin 2022-12-16 11:40 ` Krzysztof Kozlowski 2022-12-16 11:40 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8bb988fc-54d2-2528-e34f-0097c0654b7d@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=alexander.sverdlin@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=hsweeten@visionengravers.com \ --cc=jic23@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.