All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Javier Herrero <jherrero@hvsistemas.es>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH v3] input/keyboard: new OpenCores Keyboard Controller  driver
Date: Tue, 15 Sep 2009 12:39:04 -0400	[thread overview]
Message-ID: <8bd0f97a0909150939u1cd7787dw412b733d168e27d6@mail.gmail.com> (raw)
In-Reply-To: <20090915162349.GA29241@core.coreip.homeip.net>

On Tue, Sep 15, 2009 at 12:23, Dmitry Torokhov wrote:
> On Tue, Sep 15, 2009 at 07:16:25AM -0400, Mike Frysinger wrote:
>> On Tue, Sep 15, 2009 at 01:52, Dmitry Torokhov wrote:
>> > OK, below is what I have now... One concern though - don't we need to do
>> > request_mem_region/ioremap for the addr_res?
>>
>> i think so ... these operations are nops on a Blackfin CPU which is
>> probably why it "just works".
>
> Surely request_mem_region is not a nop? I think even if uoremap is a nop
> we need to convert the driver since it does not have to be on a
> Blackfin, does it?

i wasnt suggesting we not add these calls.  i was just stating why
they hadnt already been added -- things work fine on a Blackfin system
w/out ioremap calls because we're a no-mmu system.

>> the input layer can handle input even if it's not registered ?
>
> The device can survive input events as soon as it was allocated with
> input_allocate_device() but of course the event will not get anywhere.
> This is a property that I intend to keep since it is very convenient.

that's fine, i was just curious
-mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Frysinger <vapier.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Javier Herrero <jherrero@hvsistemas.es>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH v3] input/keyboard: new OpenCores Keyboard Controller driver
Date: Tue, 15 Sep 2009 12:39:04 -0400	[thread overview]
Message-ID: <8bd0f97a0909150939u1cd7787dw412b733d168e27d6@mail.gmail.com> (raw)
In-Reply-To: <20090915162349.GA29241@core.coreip.homeip.net>

On Tue, Sep 15, 2009 at 12:23, Dmitry Torokhov wrote:
> On Tue, Sep 15, 2009 at 07:16:25AM -0400, Mike Frysinger wrote:
>> On Tue, Sep 15, 2009 at 01:52, Dmitry Torokhov wrote:
>> > OK, below is what I have now... One concern though - don't we need to do
>> > request_mem_region/ioremap for the addr_res?
>>
>> i think so ... these operations are nops on a Blackfin CPU which is
>> probably why it "just works".
>
> Surely request_mem_region is not a nop? I think even if uoremap is a nop
> we need to convert the driver since it does not have to be on a
> Blackfin, does it?

i wasnt suggesting we not add these calls.  i was just stating why
they hadnt already been added -- things work fine on a Blackfin system
w/out ioremap calls because we're a no-mmu system.

>> the input layer can handle input even if it's not registered ?
>
> The device can survive input events as soon as it was allocated with
> input_allocate_device() but of course the event will not get anywhere.
> This is a property that I intend to keep since it is very convenient.

that's fine, i was just curious
-mike

  reply	other threads:[~2009-09-15 16:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14  2:17 [PATCH] input/keyboard: new OpenCores Keyboard Controller driver Mike Frysinger
2009-09-14  6:17 ` Andrey Panin
2009-09-14  7:04 ` [PATCH v2] " Mike Frysinger
2009-09-14  7:25   ` Joe Perches
2009-09-14 17:40   ` [PATCH v3] " Mike Frysinger
2009-09-14 17:49     ` Dmitry Torokhov
2009-09-14 18:02       ` Mike Frysinger
2009-09-14 18:02         ` Mike Frysinger
2009-09-14 18:18         ` Javier Herrero
2009-09-15  5:52           ` Dmitry Torokhov
2009-09-15 11:16             ` Mike Frysinger
2009-09-15 11:16               ` Mike Frysinger
2009-09-15 16:23               ` Dmitry Torokhov
2009-09-15 16:23                 ` Dmitry Torokhov
2009-09-15 16:39                 ` Mike Frysinger [this message]
2009-09-15 16:39                   ` Mike Frysinger
2009-09-16  2:00             ` [PATCH v4] " Mike Frysinger
2009-09-16  3:45               ` Dmitry Torokhov
2009-09-16  3:57                 ` Mike Frysinger
2009-09-16  3:57                   ` Mike Frysinger
2009-09-16  4:10                 ` [PATCH v5] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0909150939u1cd7787dw412b733d168e27d6@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=cooloney@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jherrero@hvsistemas.es \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.