From: Mike Frysinger <vapier.adi@gmail.com> To: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Cc: greg@kroah.com, linux-kbuild@vger.kernel.org, carmelo73@gmail.com, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au Subject: Re: [PATCH 04/10] module: make MODULE_SYMBOL_PREFIX into a CONFIG option Date: Tue, 3 Nov 2009 07:30:20 -0500 [thread overview] Message-ID: <8bd0f97a0911030430s3ecb2467hc52ebac658c39ccd@mail.gmail.com> (raw) In-Reply-To: <4AF01F18.8040807@tuffmail.co.uk> On Tue, Nov 3, 2009 at 07:16, Alan Jenkins wrote: > Mike Frysinger wrote: >> On Tue, Nov 3, 2009 at 05:06, Alan Jenkins wrote: >>> The next commit will require the use of MODULE_SYMBOL_PREFIX in >>> .tmp_exports-asm.S. Currently it is mixed in with C structure >>> definitions in "asm/module.h". Move the definition of this arch option >>> into Kconfig, so it can be easily accessed by any code. >>> >>> This also lets modpost.c use the same definition. Previously modpost >>> relied on a hardcoded list of architectures in mk_elfconfig.c. >> >> this should also let us push VMLINUX_SYMBOL() out of >> arch/*/kernel/vmlinux.lds.S and into asm-generic/vmlinux.lds.h ... > > I don't think that's possible. > > #define VMLINUX_SYMBOL(_sym_) _##_sym_ > > I don't know any "unstringify" operation. So I can't convert a string value > of CONFIG_SYMBOL_PREFIX to the unquoted underscore we neeed for this macro. > The same applies for the SYM() macro I use. let the build system do the unstringify operation. qstrip = $(strip $(subst ",,$(1))) CPPFLAGS_vmlinux.lds += -DVMLINUX_SYMBOL_PREFIX=$(call qstrip,CONFIG_SYMBOL_PREFIX) > If we positively want to keep the generality, I guess I should put > MODULE_SYMBOL_PREFIX in a header file of it's own. The disadvantage is that > it makes it inaccessible to host programs again, like modpost (which > currently hardcodes the list of affected architectures in mk_elfconfig.c). having it in the arch Kconfig removes any and all possible limitations, and it keeps the cruft out of the common init/Kconfig and in the arch-specific Kconfig, and avoids a dead symbol (HAVE_SYMBOL_PREFIX) -mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Frysinger <vapier.adi@gmail.com> To: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Cc: greg@kroah.com, linux-kbuild@vger.kernel.org, carmelo73@gmail.com, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au Subject: Re: [PATCH 04/10] module: make MODULE_SYMBOL_PREFIX into a CONFIG option Date: Tue, 3 Nov 2009 07:30:20 -0500 [thread overview] Message-ID: <8bd0f97a0911030430s3ecb2467hc52ebac658c39ccd@mail.gmail.com> (raw) In-Reply-To: <4AF01F18.8040807@tuffmail.co.uk> On Tue, Nov 3, 2009 at 07:16, Alan Jenkins wrote: > Mike Frysinger wrote: >> On Tue, Nov 3, 2009 at 05:06, Alan Jenkins wrote: >>> The next commit will require the use of MODULE_SYMBOL_PREFIX in >>> .tmp_exports-asm.S. Currently it is mixed in with C structure >>> definitions in "asm/module.h". Move the definition of this arch option >>> into Kconfig, so it can be easily accessed by any code. >>> >>> This also lets modpost.c use the same definition. Previously modpost >>> relied on a hardcoded list of architectures in mk_elfconfig.c. >> >> this should also let us push VMLINUX_SYMBOL() out of >> arch/*/kernel/vmlinux.lds.S and into asm-generic/vmlinux.lds.h ... > > I don't think that's possible. > > #define VMLINUX_SYMBOL(_sym_) _##_sym_ > > I don't know any "unstringify" operation. So I can't convert a string value > of CONFIG_SYMBOL_PREFIX to the unquoted underscore we neeed for this macro. > The same applies for the SYM() macro I use. let the build system do the unstringify operation. qstrip = $(strip $(subst ",,$(1))) CPPFLAGS_vmlinux.lds += -DVMLINUX_SYMBOL_PREFIX=$(call qstrip,CONFIG_SYMBOL_PREFIX) > If we positively want to keep the generality, I guess I should put > MODULE_SYMBOL_PREFIX in a header file of it's own. The disadvantage is that > it makes it inaccessible to host programs again, like modpost (which > currently hardcodes the list of affected architectures in mk_elfconfig.c). having it in the arch Kconfig removes any and all possible limitations, and it keeps the cruft out of the common init/Kconfig and in the arch-specific Kconfig, and avoids a dead symbol (HAVE_SYMBOL_PREFIX) -mike
next prev parent reply other threads:[~2009-11-03 12:30 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-11-02 16:52 Fast LKM symbol resolution Alan Jenkins 2009-11-03 3:55 ` Greg KH 2009-11-03 10:06 ` [PATCH 0/10] module: Speed up symbol resolution during module loading (using binary search) Alan Jenkins 2009-11-03 15:58 ` Greg KH 2009-11-05 12:17 ` Rusty Russell 2009-11-03 10:06 ` [PATCH 01/10] ARM: use unified discard definition in linker script Alan Jenkins 2009-11-03 10:06 ` [PATCH 02/10] ARM: unexport symbols used to implement floating point emulation Alan Jenkins 2009-11-03 10:06 ` [PATCH 03/10] module: extract __EXPORT_SYMBOL from module.h into mod_export.h Alan Jenkins 2009-11-03 10:06 ` [PATCH 04/10] module: make MODULE_SYMBOL_PREFIX into a CONFIG option Alan Jenkins 2009-11-03 10:19 ` Mike Frysinger 2009-11-03 10:19 ` Mike Frysinger 2009-11-03 12:16 ` Alan Jenkins 2009-11-03 12:30 ` Mike Frysinger [this message] 2009-11-03 12:30 ` Mike Frysinger 2009-11-03 13:29 ` Paul Mundt 2009-11-03 13:39 ` Mike Frysinger 2009-11-03 13:39 ` Mike Frysinger 2009-11-03 13:46 ` Paul Mundt 2009-11-03 13:58 ` Mike Frysinger 2009-11-03 13:58 ` Mike Frysinger 2009-11-03 14:07 ` Paul Mundt 2009-11-03 10:06 ` [PATCH 05/10] kbuild: sort the list of symbols exported by the kernel (__ksymtab) Alan Jenkins 2009-11-04 8:19 ` Rusty Russell 2009-11-04 10:00 ` Alan Jenkins 2009-11-04 11:12 ` Mike Frysinger 2009-11-04 11:12 ` Mike Frysinger 2009-11-04 17:19 ` Sam Ravnborg 2009-11-05 14:24 ` Alan Jenkins 2009-11-05 16:17 ` Mike Frysinger 2009-11-05 16:17 ` Mike Frysinger 2009-11-09 3:17 ` Rusty Russell 2009-11-20 22:20 ` Tony Luck 2009-11-20 22:20 ` Tony Luck 2009-11-21 0:02 ` Alan Jenkins 2009-11-23 19:53 ` Alex Chiang 2009-11-23 22:44 ` Alan Jenkins 2009-11-24 0:57 ` Rusty Russell 2009-11-24 5:39 ` James Bottomley 2009-11-24 9:28 ` Alan Jenkins 2009-11-24 22:43 ` James Bottomley 2009-11-25 9:15 ` Alan Jenkins 2009-11-25 15:08 ` James Bottomley 2009-11-25 17:01 ` Alan Jenkins 2009-11-27 11:03 ` Rusty Russell 2009-11-26 0:40 ` Andrew Morton 2009-11-26 17:14 ` Alan Jenkins 2009-11-03 10:06 ` [PATCH 06/10] module: refactor symbol tables and try to reduce code size of each_symbol() Alan Jenkins 2009-11-04 8:28 ` Rusty Russell 2009-11-04 9:45 ` Alan Jenkins 2009-11-03 10:06 ` [PATCH 07/10] lib: Add generic binary search function to the kernel Alan Jenkins 2009-11-03 10:06 ` [PATCH 08/10] lib: bsearch - remove redundant special case for arrays of size 0 Alan Jenkins 2009-11-03 10:06 ` [PATCH 09/10] module: speed up find_symbol() using binary search on the builtin symbol tables Alan Jenkins 2009-11-04 8:31 ` Rusty Russell 2009-11-03 10:06 ` [PATCH 10/10] module: fix is_exported() to return true for all types of exports Alan Jenkins 2009-11-04 8:32 ` Rusty Russell 2009-11-06 5:37 ` Fast LKM symbol resolution Carmelo Amoroso
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8bd0f97a0911030430s3ecb2467hc52ebac658c39ccd@mail.gmail.com \ --to=vapier.adi@gmail.com \ --cc=alan-jenkins@tuffmail.co.uk \ --cc=carmelo73@gmail.com \ --cc=greg@kroah.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rusty@rustcorp.com.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.