From: Joe Perches <joe@perches.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Przemyslaw Sroka <psroka@cadence.com>,
Arkadiusz Golec <agolec@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
Alicja Jurasik-Urbaniak <alicja@cadence.com>,
Cyprian Wronka <cwronka@cadence.com>,
Suresh Punnoose <sureshp@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland>
Subject: Re: [PATCH v5 09/10] gpio: Add a driver for Cadence I3C GPIO expander
Date: Wed, 27 Jun 2018 15:54:21 -0700 [thread overview]
Message-ID: <8bf36e4025b6ec5198a668edda6bcbef3b06e97b.camel@perches.com> (raw)
In-Reply-To: <20180627213617.51e10712@bbrezillon>
On Wed, 2018-06-27 at 21:36 +0200, Boris Brezillon wrote:
> I mean, kzalloc() is not deprecated AFAIK and I don't really see the
> benefit of using kmalloc_array(), but if that makes you happy, let's go
> for kmalloc_array().
kcalloc
> I do run checkpatch --strict and fix most of the thing reported except
> those hurting readability. I don't remember seeing checkpatch complain
> about kzalloc() usage, and I guess it's not smart enough to detect that
> for_each_bit_set() can be used to replace the "for() if (BIT(x) & val)"
> pattern.
That would not an appropriate conversion suggestion in any case.
coccinelle could at least look at whether or not x is allocated
as a bitmap via DECLARE_BITMAP or bitmap_alloc
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Przemyslaw Sroka <psroka@cadence.com>,
Arkadiusz Golec <agolec@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
Alicja Jurasik-Urbaniak <alicja@cadence.com>,
Cyprian Wronka <cwronka@cadence.com>,
Suresh Punnoose <sureshp@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vitor Soares <Vitor.Soares@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
Xiang Lin <Xiang.Lin@synaptics.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Przemyslaw Gaj <pgaj@cadence.com>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v5 09/10] gpio: Add a driver for Cadence I3C GPIO expander
Date: Wed, 27 Jun 2018 15:54:21 -0700 [thread overview]
Message-ID: <8bf36e4025b6ec5198a668edda6bcbef3b06e97b.camel@perches.com> (raw)
In-Reply-To: <20180627213617.51e10712@bbrezillon>
On Wed, 2018-06-27 at 21:36 +0200, Boris Brezillon wrote:
> I mean, kzalloc() is not deprecated AFAIK and I don't really see the
> benefit of using kmalloc_array(), but if that makes you happy, let's go
> for kmalloc_array().
kcalloc
> I do run checkpatch --strict and fix most of the thing reported except
> those hurting readability. I don't remember seeing checkpatch complain
> about kzalloc() usage, and I guess it's not smart enough to detect that
> for_each_bit_set() can be used to replace the "for() if (BIT(x) & val)"
> pattern.
That would not an appropriate conversion suggestion in any case.
coccinelle could at least look at whether or not x is allocated
as a bitmap via DECLARE_BITMAP or bitmap_alloc
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Przemyslaw Sroka <psroka@cadence.com>,
Arkadiusz Golec <agolec@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
Alicja Jurasik-Urbaniak <alicja@cadence.com>,
Cyprian Wronka <cwronka@cadence.com>,
Suresh Punnoose <sureshp@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vitor Soares <Vitor.Soares@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
Xiang Lin <Xiang.Lin@synaptics.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Przemyslaw Gaj <pgaj@cadence.com>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v5 09/10] gpio: Add a driver for Cadence I3C GPIO expander
Date: Wed, 27 Jun 2018 15:54:21 -0700 [thread overview]
Message-ID: <8bf36e4025b6ec5198a668edda6bcbef3b06e97b.camel@perches.com> (raw)
In-Reply-To: <20180627213617.51e10712@bbrezillon>
On Wed, 2018-06-27 at 21:36 +0200, Boris Brezillon wrote:
> I mean, kzalloc() is not deprecated AFAIK and I don't really see the
> benefit of using kmalloc_array(), but if that makes you happy, let's go
> for kmalloc_array().
kcalloc
> I do run checkpatch --strict and fix most of the thing reported except
> those hurting readability. I don't remember seeing checkpatch complain
> about kzalloc() usage, and I guess it's not smart enough to detect that
> for_each_bit_set() can be used to replace the "for() if (BIT(x) & val)"
> pattern.
That would not an appropriate conversion suggestion in any case.
coccinelle could at least look at whether or not x is allocated
as a bitmap via DECLARE_BITMAP or bitmap_alloc
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-27 22:54 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 10:49 [PATCH v5 00/10] Add the I3C subsystem Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` [PATCH v5 01/10] i3c: Add core I3C infrastructure Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 21:35 ` Peter Rosin
2018-06-22 21:35 ` Peter Rosin
2018-06-22 21:35 ` Peter Rosin
2018-06-23 10:17 ` Boris Brezillon
2018-06-23 10:17 ` Boris Brezillon
2018-06-23 10:17 ` Boris Brezillon
2018-06-23 21:40 ` Peter Rosin
2018-06-23 21:40 ` Peter Rosin
2018-06-23 21:40 ` Peter Rosin
2018-06-24 12:02 ` Boris Brezillon
2018-06-24 12:02 ` Boris Brezillon
2018-06-24 12:02 ` Boris Brezillon
2018-06-24 21:55 ` Peter Rosin
2018-06-24 21:55 ` Peter Rosin
2018-06-24 21:55 ` Peter Rosin
2018-06-25 8:03 ` Boris Brezillon
2018-06-25 8:03 ` Boris Brezillon
2018-06-25 8:03 ` Boris Brezillon
2018-06-28 15:38 ` vitor
2018-06-28 15:38 ` vitor
2018-06-28 15:38 ` vitor
2018-06-28 21:02 ` Boris Brezillon
2018-06-28 21:02 ` Boris Brezillon
2018-06-28 21:02 ` Boris Brezillon
2018-07-11 14:05 ` Arnd Bergmann
2018-07-11 14:05 ` Arnd Bergmann
2018-07-11 14:05 ` Arnd Bergmann
2018-06-22 10:49 ` [PATCH v5 02/10] docs: driver-api: Add I3C documentation Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-26 21:07 ` Randy Dunlap
2018-06-26 21:07 ` Randy Dunlap
2018-06-26 21:07 ` Randy Dunlap
2018-06-27 7:20 ` Boris Brezillon
2018-06-27 7:20 ` Boris Brezillon
2018-06-27 7:20 ` Boris Brezillon
2018-06-22 10:49 ` [PATCH v5 03/10] i3c: Add sysfs ABI spec Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` [PATCH v5 04/10] dt-bindings: i3c: Document core bindings Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-07-11 14:10 ` Arnd Bergmann
2018-07-11 14:10 ` Arnd Bergmann
2018-07-11 14:10 ` Arnd Bergmann
2018-07-11 14:45 ` Boris Brezillon
2018-07-11 14:45 ` Boris Brezillon
2018-07-11 14:45 ` Boris Brezillon
2018-07-11 14:56 ` Arnd Bergmann
2018-07-11 14:56 ` Arnd Bergmann
2018-07-11 14:56 ` Arnd Bergmann
2018-06-22 10:49 ` [PATCH v5 05/10] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` [PATCH v5 06/10] MAINTAINERS: Add myself as the I3C subsystem maintainer Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` [PATCH v5 07/10] i3c: master: Add driver for Cadence IP Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-07-11 14:19 ` Arnd Bergmann
2018-07-11 14:19 ` Arnd Bergmann
2018-07-11 14:19 ` Arnd Bergmann
2018-06-22 10:49 ` [PATCH v5 08/10] dt-bindings: i3c: Document Cadence I3C master bindings Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` [PATCH v5 09/10] gpio: Add a driver for Cadence I3C GPIO expander Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 16:04 ` Randy Dunlap
2018-06-22 16:04 ` Randy Dunlap
2018-06-22 16:04 ` Randy Dunlap
2018-06-22 18:35 ` Boris Brezillon
2018-06-22 18:35 ` Boris Brezillon
2018-06-22 18:35 ` Boris Brezillon
2018-06-26 19:07 ` Andy Shevchenko
2018-06-26 19:07 ` Andy Shevchenko
2018-06-26 19:07 ` Andy Shevchenko
2018-06-26 19:56 ` Boris Brezillon
2018-06-26 19:56 ` Boris Brezillon
2018-06-26 19:56 ` Boris Brezillon
2018-06-26 20:44 ` Andy Shevchenko
2018-06-26 20:44 ` Andy Shevchenko
2018-06-26 20:44 ` Andy Shevchenko
2018-06-26 21:46 ` Boris Brezillon
2018-06-26 21:46 ` Boris Brezillon
2018-06-26 21:46 ` Boris Brezillon
2018-06-27 17:53 ` Andy Shevchenko
2018-06-27 17:53 ` Andy Shevchenko
2018-06-27 17:53 ` Andy Shevchenko
2018-06-27 19:36 ` Boris Brezillon
2018-06-27 19:36 ` Boris Brezillon
2018-06-27 19:36 ` Boris Brezillon
2018-06-27 22:54 ` Joe Perches [this message]
2018-06-27 22:54 ` Joe Perches
2018-06-27 22:54 ` Joe Perches
2018-06-28 0:00 ` Andy Shevchenko
2018-06-28 0:00 ` Andy Shevchenko
2018-06-28 0:00 ` Andy Shevchenko
2018-06-28 0:50 ` Joe Perches
2018-06-28 0:50 ` Joe Perches
2018-06-28 0:50 ` Joe Perches
2018-06-27 22:14 ` Linus Walleij
2018-06-27 22:14 ` Linus Walleij
2018-06-27 22:14 ` Linus Walleij
2018-06-28 4:08 ` Wolfram Sang
2018-06-28 4:08 ` Wolfram Sang
2018-06-22 10:49 ` [PATCH v5 10/10] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
2018-06-22 10:49 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf36e4025b6ec5198a668edda6bcbef3b06e97b.camel@perches.com \
--to=joe@perches.com \
--cc=adouglas@cadence.com \
--cc=agolec@cadence.com \
--cc=alicja@cadence.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bfolta@cadence.com \
--cc=boris.brezillon@bootlin.com \
--cc=corbet@lwn.net \
--cc=cwronka@cadence.com \
--cc=dkos@cadence.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=psroka@cadence.com \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sureshp@cadence.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.