All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "kernel test robot" <lkp@intel.com>,
	dri-devel@lists.freedesktop.org,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
	kbuild-all@lists.01.org, David Airlie <airlied@linux.ie>,
	Sandy Huang <hjc@rock-chips.com>,
	Philippe Cornu <philippe.cornu@st.com>,
	Yannick Fertre <yannick.fertre@st.com>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v2 2/2] drm: automatic legacy gamma support
Date: Fri, 11 Dec 2020 13:24:49 +0200	[thread overview]
Message-ID: <8c0fa5f2-9751-ca11-686d-8876a3a9d633@ti.com> (raw)
In-Reply-To: <202012110104.ZPkkhoVT-lkp@intel.com>

On 10/12/2020 20:06, kernel test robot wrote:
> Hi Tomi,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on drm-intel/for-linux-next]
> [also build test WARNING on linus/master v5.10-rc7]
> [cannot apply to drm-tip/drm-tip anholt/for-next next-20201210]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Tomi-Valkeinen/drm-fix-and-cleanup-legacy-gamma-support/20201208-215917
> base:   git://anongit.freedesktop.org/drm-intel for-linux-next
> config: i386-randconfig-m021-20201209 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> New smatch warnings:
> drivers/gpu/drm/drm_color_mgmt.c:307 drm_crtc_legacy_gamma_set() error: potential null dereference 'blob'.  (drm_property_create_blob returns null)

I don't see how this could happen. There's no code path I see where drm_property_create_blob could
return null...

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 2/2] drm: automatic legacy gamma support
Date: Fri, 11 Dec 2020 13:24:49 +0200	[thread overview]
Message-ID: <8c0fa5f2-9751-ca11-686d-8876a3a9d633@ti.com> (raw)
In-Reply-To: <202012110104.ZPkkhoVT-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

On 10/12/2020 20:06, kernel test robot wrote:
> Hi Tomi,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on drm-intel/for-linux-next]
> [also build test WARNING on linus/master v5.10-rc7]
> [cannot apply to drm-tip/drm-tip anholt/for-next next-20201210]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Tomi-Valkeinen/drm-fix-and-cleanup-legacy-gamma-support/20201208-215917
> base:   git://anongit.freedesktop.org/drm-intel for-linux-next
> config: i386-randconfig-m021-20201209 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> New smatch warnings:
> drivers/gpu/drm/drm_color_mgmt.c:307 drm_crtc_legacy_gamma_set() error: potential null dereference 'blob'.  (drm_property_create_blob returns null)

I don't see how this could happen. There's no code path I see where drm_property_create_blob could
return null...

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-12-11 11:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 13:57 [PATCH v2 0/2] drm: fix and cleanup legacy gamma support Tomi Valkeinen
2020-12-08 13:57 ` [PATCH v2 1/2] drm: add legacy support for using degamma for gamma Tomi Valkeinen
2020-12-08 15:55   ` Laurent Pinchart
2020-12-09  0:51     ` Daniel Vetter
2020-12-09 11:17       ` Tomi Valkeinen
2020-12-09 12:39         ` Daniel Vetter
2020-12-08 13:57 ` [PATCH v2 2/2] drm: automatic legacy gamma support Tomi Valkeinen
2020-12-08 15:59   ` Laurent Pinchart
2020-12-09  5:20   ` kernel test robot
2020-12-09  5:20     ` kernel test robot
2020-12-10 18:06   ` kernel test robot
2020-12-10 18:06     ` kernel test robot
2020-12-11 11:24     ` Tomi Valkeinen [this message]
2020-12-11 11:24       ` Tomi Valkeinen
2020-12-11 14:42       ` Ville Syrjälä
2020-12-11 14:42         ` Ville Syrjälä
2020-12-12  8:54         ` [kbuild-all] " Philip Li
2020-12-12  8:54           ` Philip Li
2020-12-14 18:49           ` [kbuild-all] " Dan Carpenter
2020-12-14 18:49             ` Dan Carpenter
2020-12-16  1:06             ` [kbuild-all] " Philip Li
2020-12-16  1:06               ` Philip Li
2020-12-16  7:34               ` [kbuild-all] " Dan Carpenter
2020-12-16  7:34                 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c0fa5f2-9751-ca11-686d-8876a3a9d633@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=kbuild-all@lists.01.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux@armlinux.org.uk \
    --cc=lkp@intel.com \
    --cc=paul@crapouillou.net \
    --cc=philippe.cornu@st.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.