* [PATCH] nvme_fc: correct port role bits
@ 2017-05-05 23:13 jsmart2021
2017-05-08 11:03 ` Johannes Thumshirn
0 siblings, 1 reply; 3+ messages in thread
From: jsmart2021 @ 2017-05-05 23:13 UTC (permalink / raw)
From: James Smart <jsmart2021@gmail.com>
FC Port roles is a bit mask, not individual values.
Correct nvme definitions to unique bits.
Signed-off-by: James Smart <james.smart at broadcom.com>
---
include/linux/nvme-fc-driver.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/nvme-fc-driver.h b/include/linux/nvme-fc-driver.h
index abcefb708008..00b164288e80 100644
--- a/include/linux/nvme-fc-driver.h
+++ b/include/linux/nvme-fc-driver.h
@@ -27,8 +27,8 @@
/* FC Port role bitmask - can merge with FC Port Roles in fc transport */
#define FC_PORT_ROLE_NVME_INITIATOR 0x10
-#define FC_PORT_ROLE_NVME_TARGET 0x11
-#define FC_PORT_ROLE_NVME_DISCOVERY 0x12
+#define FC_PORT_ROLE_NVME_TARGET 0x20
+#define FC_PORT_ROLE_NVME_DISCOVERY 0x40
/**
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme_fc: correct port role bits
2017-05-05 23:13 [PATCH] nvme_fc: correct port role bits jsmart2021
@ 2017-05-08 11:03 ` Johannes Thumshirn
2017-05-10 17:09 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Thumshirn @ 2017-05-08 11:03 UTC (permalink / raw)
On 05/06/2017 01:13 AM, jsmart2021@gmail.com wrote:
> From: James Smart <jsmart2021 at gmail.com>
>
> FC Port roles is a bit mask, not individual values.
> Correct nvme definitions to unique bits.
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
Although it really should be merged into scsi/scsi_transport_fc.h some day.
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme_fc: correct port role bits
2017-05-08 11:03 ` Johannes Thumshirn
@ 2017-05-10 17:09 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-05-10 17:09 UTC (permalink / raw)
On Mon, May 08, 2017@01:03:21PM +0200, Johannes Thumshirn wrote:
> On 05/06/2017 01:13 AM, jsmart2021@gmail.com wrote:
> > From: James Smart <jsmart2021 at gmail.com>
> >
> > FC Port roles is a bit mask, not individual values.
> > Correct nvme definitions to unique bits.
> >
> > Signed-off-by: James Smart <james.smart at broadcom.com>
> > ---
>
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
>
> Although it really should be merged into scsi/scsi_transport_fc.h some day.
Agreed. Maybe we just need a fc_common.h header or so.
But for now I've applied the patch to nvme-4.12
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-10 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-05 23:13 [PATCH] nvme_fc: correct port role bits jsmart2021
2017-05-08 11:03 ` Johannes Thumshirn
2017-05-10 17:09 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.