All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/psr: Adds psrwake options for all platforms
@ 2018-06-12  5:19 vathsala nagaraju
  2018-06-12  5:44 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 22+ messages in thread
From: vathsala nagaraju @ 2018-06-12  5:19 UTC (permalink / raw)
  To: jani.nikula, rodrigo.vivi
  Cc: Puthikorn Voravootivat, intel-gfx, Dhinakaran Pandiyan

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

Adds new psrwake options defined in the below table.
Platform	PSR wake options vbt version
KBL/CFL/WHL	All
SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
BXT		Uses old interpretation.
CNL/ICL+	All
GLK		All

For SKL, we will continue to use older interpretation for the above reason.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..010ff68 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if ((INTEL_GEN(dev_priv) >= 10) ||
+	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH] drm/i915/psr: Adds psrwake options for all platforms
@ 2018-06-13  8:03 vathsala nagaraju
  0 siblings, 0 replies; 22+ messages in thread
From: vathsala nagaraju @ 2018-06-13  8:03 UTC (permalink / raw)
  To: rodrigo.vivi, jani.nikula
  Cc: Puthikorn Voravootivat, intel-gfx, Dhinakaran Pandiyan

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

Adds new psrwake options defined in the below table.
Platform	PSR wake options vbt version
KBL/CFL/WHL	All
SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
BXT		Uses old interpretation.
CNL/ICL+	All
GLK		All

For SKL, we will continue to use older interpretation for the above reason.

v2: Jani
    Keep the bdb version check.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..5517ca7 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 209 && ((INTEL_GEN(dev_priv) >= 10) ||
+	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv)))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH] drm/i915/psr: Adds psrwake options for all platforms
@ 2018-06-18  6:12 vathsala nagaraju
  2018-06-18 22:43 ` Dhinakaran Pandiyan
  0 siblings, 1 reply; 22+ messages in thread
From: vathsala nagaraju @ 2018-06-18  6:12 UTC (permalink / raw)
  To: dhinakaran.pandiyan, jani.nikula
  Cc: Ashutosh D Shukla, Jani Nikula, intel-gfx, Rodrigo Vivi,
	Puthikorn Voravootivat, Maulik V Vaghela

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

Adds new psrwake options defined in the below table.
Platform	PSR wake options vbt version
KBL/CFL/WHL	All(205+)
BXT		Uses old interpretation.
CNL/ICL+	All(205+)
GLK		All(205+)
SKL		All PV releases (Check for 205+ might help but cannot be foolproof)

We will continue with newer interpretation for SKL from 205.

v2: Jani
    Keep the bdb version check.
v3:
    Apply newer version for skl from 205+(DK).
    Add (version check && platform list) (Jani).
    Add bdb version for each platform in commit message(DK).

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Ashutosh D Shukla <ashutosh.d.shukla@intel.com>
Cc: Maulik V Vaghela <maulik.v.vaghela@intel.com>

Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 465dff4..9ef0464 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
 	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
 	 * Old decimal value is wake up time in multiples of 100 us.
 	 */
-	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
+	if (bdb->version >= 205 && (IS_GEN9_BC(dev_priv) ||
+	    IS_GEMINILAKE(dev_priv) || (INTEL_GEN(dev_priv) >= 10))) {
 		switch (psr_table->tp1_wakeup_time) {
 		case 0:
 			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2018-06-19  8:46 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12  5:19 [PATCH] drm/i915/psr: Adds psrwake options for all platforms vathsala nagaraju
2018-06-12  5:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-12  6:36 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-12  9:00 ` [PATCH] " Jani Nikula
2018-06-13  6:30   ` Nagaraju, Vathsala
2018-06-13  6:41     ` Jani Nikula
2018-06-13 17:32       ` Dhinakaran Pandiyan
2018-06-13 17:40         ` Dhinakaran Pandiyan
2018-06-14  6:29           ` Nagaraju, Vathsala
2018-06-14 16:00             ` Pandiyan, Dhinakaran
2018-06-14 16:48               ` Rodrigo Vivi
2018-06-14 16:56               ` Nagaraju, Vathsala
2018-06-14 17:28                 ` Dhinakaran Pandiyan
2018-06-15  8:10                   ` Jani Nikula
2018-06-15 18:14                     ` Dhinakaran Pandiyan
2018-06-14  7:38           ` Nagaraju, Vathsala
2018-06-14  7:46           ` Nagaraju, Vathsala
2018-06-13 10:42 ` Ville Syrjälä
2018-06-13  8:03 vathsala nagaraju
2018-06-18  6:12 vathsala nagaraju
2018-06-18 22:43 ` Dhinakaran Pandiyan
2018-06-19  8:46   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.