All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: comedi: Removed not necessary braces for single block
@ 2019-01-15 15:36 Jitendra Khasdev
  2019-01-16 10:44 ` Ian Abbott
  0 siblings, 1 reply; 5+ messages in thread
From: Jitendra Khasdev @ 2019-01-15 15:36 UTC (permalink / raw)
  To: abbotti, hsweeten, gregkh, devel, linux-kernel

This patch is used to remove not necessary braces for single if block.

Signed-off-by: Jitendra Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 5d2fcbfe02af..38980fad8be4 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
 	unsigned int n_data = MIN_SAMPLES;
 	int ret = 0;
 
-	if (copy_from_user(&insn, arg, sizeof(insn))) {
+	if (copy_from_user(&insn, arg, sizeof(insn)))
 		return -EFAULT;
-	}
+
 
 	n_data = max(n_data, insn.n);
 
-- 
2.13.6


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: comedi: Removed not necessary braces for single block
  2019-01-15 15:36 [PATCH] staging: comedi: Removed not necessary braces for single block Jitendra Khasdev
@ 2019-01-16 10:44 ` Ian Abbott
  0 siblings, 0 replies; 5+ messages in thread
From: Ian Abbott @ 2019-01-16 10:44 UTC (permalink / raw)
  To: Jitendra Khasdev, hsweeten, gregkh, devel, linux-kernel

On 15/01/2019 15:36, Jitendra Khasdev wrote:
> This patch is used to remove not necessary braces for single if block.
> 
> Signed-off-by: Jitendra Khasdev <jkhasdev@gmail.com>
> ---
>   drivers/staging/comedi/comedi_fops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 5d2fcbfe02af..38980fad8be4 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
>   	unsigned int n_data = MIN_SAMPLES;
>   	int ret = 0;
>   
> -	if (copy_from_user(&insn, arg, sizeof(insn))) {
> +	if (copy_from_user(&insn, arg, sizeof(insn)))
>   		return -EFAULT;
> -	}
> +
>   
>   	n_data = max(n_data, insn.n);
>   
> 

The patch looks fine. Thanks for the fix!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: comedi: Removed not necessary braces for single block
  2019-01-15 15:20 ` Greg KH
@ 2019-01-15 19:48   ` Jitendra
  0 siblings, 0 replies; 5+ messages in thread
From: Jitendra @ 2019-01-15 19:48 UTC (permalink / raw)
  To: Greg KH, abbotti, hsweeten, devel, linux-kernel

>
>"interesting" email name you used here :)
>
>Please fix up, it has to match the signed-off-by line.
>

I fixed and resent the patch again.

---
Jitendra

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: comedi: Removed not necessary braces for single block
  2019-01-15 14:51 root
@ 2019-01-15 15:20 ` Greg KH
  2019-01-15 19:48   ` Jitendra
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-01-15 15:20 UTC (permalink / raw)
  To: root; +Cc: abbotti, hsweeten, devel, linux-kernel

On Tue, Jan 15, 2019 at 08:21:08PM +0530, root wrote:
> This patch is used to remove not necessary braces for single if block.
> 
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

"interesting" email name you used here :)

Please fix up, it has to match the signed-off-by line.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] staging: comedi: Removed not necessary braces for single block
@ 2019-01-15 14:51 root
  2019-01-15 15:20 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: root @ 2019-01-15 14:51 UTC (permalink / raw)
  To: abbotti, hsweeten, gregkh, devel, linux-kernel; +Cc: Jitendra Kumar Khasdev

This patch is used to remove not necessary braces for single if block.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 5d2fcbfe02af..0caae4a5c471 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1605,9 +1605,8 @@ static int do_insn_ioctl(struct comedi_device *dev,
 	unsigned int n_data = MIN_SAMPLES;
 	int ret = 0;

-	if (copy_from_user(&insn, arg, sizeof(insn))) {
+	if (copy_from_user(&insn, arg, sizeof(insn)))
 		return -EFAULT;
-	}

 	n_data = max(n_data, insn.n);

--
2.13.6


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-16 10:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 15:36 [PATCH] staging: comedi: Removed not necessary braces for single block Jitendra Khasdev
2019-01-16 10:44 ` Ian Abbott
  -- strict thread matches above, loose matches on Subject: below --
2019-01-15 14:51 root
2019-01-15 15:20 ` Greg KH
2019-01-15 19:48   ` Jitendra

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.